All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Cc: kexec@lists.infradead.org, ebiederm@xmission.com,
	Jianglei Nie <niejianglei2021@163.com>,
	Baoquan He <bhe@redhat.com>
Subject: [PATCH RESEND 1/4] proc/vmcore: fix potential memory leak in vmcore_init()
Date: Thu, 29 Sep 2022 12:29:33 +0800	[thread overview]
Message-ID: <20220929042936.22012-2-bhe@redhat.com> (raw)
In-Reply-To: <20220929042936.22012-1-bhe@redhat.com>

From: Jianglei Nie <niejianglei2021@163.com>

elfcorehdr_alloc() allocates a memory chunk for elfcorehdr_addr with
kzalloc(). If is_vmcore_usable() returns false, elfcorehdr_addr is a
predefined value. If parse_crash_elf_headers() gets some error and
returns a negetive value, the elfcorehdr_addr should be released with
elfcorehdr_free().

Fix it by calling elfcorehdr_free() when parse_crash_elf_headers() fails.

Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Acked-by: Baoquan He <bhe@redhat.com>
Signed-off-by: Baoquan He <bhe@redhat.com>
---
 fs/proc/vmcore.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c
index f2aa86c421f2..74747571d58e 100644
--- a/fs/proc/vmcore.c
+++ b/fs/proc/vmcore.c
@@ -1567,6 +1567,7 @@ static int __init vmcore_init(void)
 		return rc;
 	rc = parse_crash_elf_headers();
 	if (rc) {
+		elfcorehdr_free(elfcorehdr_addr);
 		pr_warn("Kdump: vmcore not initialized\n");
 		return rc;
 	}
-- 
2.34.1


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Cc: kexec@lists.infradead.org, ebiederm@xmission.com,
	Jianglei Nie <niejianglei2021@163.com>,
	Baoquan He <bhe@redhat.com>
Subject: [PATCH RESEND 1/4] proc/vmcore: fix potential memory leak in vmcore_init()
Date: Thu, 29 Sep 2022 12:29:33 +0800	[thread overview]
Message-ID: <20220929042936.22012-2-bhe@redhat.com> (raw)
In-Reply-To: <20220929042936.22012-1-bhe@redhat.com>

From: Jianglei Nie <niejianglei2021@163.com>

elfcorehdr_alloc() allocates a memory chunk for elfcorehdr_addr with
kzalloc(). If is_vmcore_usable() returns false, elfcorehdr_addr is a
predefined value. If parse_crash_elf_headers() gets some error and
returns a negetive value, the elfcorehdr_addr should be released with
elfcorehdr_free().

Fix it by calling elfcorehdr_free() when parse_crash_elf_headers() fails.

Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Acked-by: Baoquan He <bhe@redhat.com>
Signed-off-by: Baoquan He <bhe@redhat.com>
---
 fs/proc/vmcore.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c
index f2aa86c421f2..74747571d58e 100644
--- a/fs/proc/vmcore.c
+++ b/fs/proc/vmcore.c
@@ -1567,6 +1567,7 @@ static int __init vmcore_init(void)
 		return rc;
 	rc = parse_crash_elf_headers();
 	if (rc) {
+		elfcorehdr_free(elfcorehdr_addr);
 		pr_warn("Kdump: vmcore not initialized\n");
 		return rc;
 	}
-- 
2.34.1


  reply	other threads:[~2022-09-29  4:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29  4:29 [PATCH RESEND 0/4] Some minor cleanup patches resent Baoquan He
2022-09-29  4:29 ` Baoquan He
2022-09-29  4:29 ` Baoquan He [this message]
2022-09-29  4:29   ` [PATCH RESEND 1/4] proc/vmcore: fix potential memory leak in vmcore_init() Baoquan He
2022-09-29  4:29 ` [PATCH RESEND 2/4] kexec: Remove the unneeded result variable Baoquan He
2022-09-29  4:29   ` Baoquan He
2022-09-29  4:29 ` [PATCH RESEND 3/4] kexec: replace crash_mem_range with range Baoquan He
2022-09-29  4:29   ` Baoquan He
2022-09-29  4:29   ` Baoquan He
2022-09-29  4:29 ` [PATCH RESEND 4/4] ARM: kexec: Make machine_crash_nonpanic_core() static Baoquan He
2022-09-29  4:29   ` Baoquan He
2022-09-29  4:29   ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220929042936.22012-2-bhe@redhat.com \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=niejianglei2021@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.