From: Jakub Kicinski <kuba@kernel.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, robh@kernel.org, johannes@sipsolutions.net,
ecree.xilinx@gmail.com, stephen@networkplumber.org,
sdf@google.com, f.fainelli@gmail.com, fw@strlen.de,
linux-doc@vger.kernel.org, razor@blackwall.org,
gnault@redhat.com
Subject: Re: [PATCH net-next 4/6] netlink: add a proto specification for FOU
Date: Thu, 29 Sep 2022 07:41:05 -0700 [thread overview]
Message-ID: <20220929074105.168d944e@kernel.org> (raw)
In-Reply-To: <6c64b772-7b2b-77f8-4523-4408e0b3bf8a@6wind.com>
On Thu, 29 Sep 2022 11:02:51 +0200 Nicolas Dichtel wrote:
> > +operations:
> > + list:
> > + -
> > + name: unspec
> > + doc: unused
>
> To what correspond this name?
> It helps to name the generated operations array?
> Something else than 'const struct genl_small_ops fou_ops[3]'?
Same as the attr, it just reserves zero FWIW, never actually used in
the code I've grepped:
linux$ git grep FOU_CMD_UNSPEC
include/uapi/linux/fou.h: FOU_CMD_UNSPEC,
iproute2$ git grep FOU_CMD_UNSPEC
include/uapi/linux/fou.h: FOU_CMD_UNSPEC,
BTW thanks for asking, I noticed I mistyped the documentation,
type is 'unused', in the docs I said 'unspec'.
next prev parent reply other threads:[~2022-09-29 14:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 1:11 [PATCH net-next 0/6] Netlink protocol specs Jakub Kicinski
2022-09-29 1:11 ` [PATCH net-next 1/6] docs: add more netlink docs (incl. spec docs) Jakub Kicinski
2022-09-29 8:15 ` Bagas Sanjaya
2022-09-29 9:43 ` Nicolas Dichtel
2022-09-29 13:34 ` Guillaume Nault
2022-09-29 14:32 ` Jakub Kicinski
2022-09-29 15:11 ` Guillaume Nault
2022-09-29 15:47 ` Jakub Kicinski
2022-09-29 15:52 ` Guillaume Nault
2022-09-29 1:11 ` [PATCH net-next 2/6] netlink: add schemas for YAML specs Jakub Kicinski
2022-09-29 1:11 ` [PATCH net-next 3/6] net: add basic C code generators for Netlink Jakub Kicinski
2022-09-29 1:11 ` [PATCH net-next 4/6] netlink: add a proto specification for FOU Jakub Kicinski
2022-09-29 9:02 ` Nicolas Dichtel
2022-09-29 9:06 ` Nicolas Dichtel
2022-09-29 14:41 ` Jakub Kicinski [this message]
2022-09-29 1:11 ` [PATCH net-next 5/6] net: fou: regenerate the uAPI from the spec Jakub Kicinski
2022-09-29 1:11 ` [PATCH net-next 6/6] net: fou: use policy and operation tables generated " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929074105.168d944e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=fw@strlen.de \
--cc=gnault@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=robh@kernel.org \
--cc=sdf@google.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.