* [PATCH V2 1/3] dt-bindings: gpio: Convert Unisoc GPIO controller binding to yaml
2022-09-30 8:24 [PATCH V2 0/3] Convert Unisoc GPIO bindings to yaml and add support for UMS512 Chunyan Zhang
@ 2022-09-30 8:24 ` Chunyan Zhang
2022-09-30 11:07 ` Krzysztof Kozlowski
2022-09-30 8:24 ` [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC " Chunyan Zhang
2022-09-30 8:24 ` [PATCH V2 3/3] dt-bindings: gpio: Add compatible string to support Unisoc UMS512 Chunyan Zhang
2 siblings, 1 reply; 10+ messages in thread
From: Chunyan Zhang @ 2022-09-30 8:24 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski
Cc: linux-gpio, devicetree, Baolin Wang, Orson Zhai, Chunyan Zhang,
Chunyan Zhang, LKML
From: Chunyan Zhang <chunyan.zhang@unisoc.com>
Convert the Unisoc gpio controller binding to DT schema format.
Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
---
.../devicetree/bindings/gpio/gpio-sprd.txt | 28 --------
.../devicetree/bindings/gpio/sprd,gpio.yaml | 70 +++++++++++++++++++
2 files changed, 70 insertions(+), 28 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-sprd.txt
create mode 100644 Documentation/devicetree/bindings/gpio/sprd,gpio.yaml
diff --git a/Documentation/devicetree/bindings/gpio/gpio-sprd.txt b/Documentation/devicetree/bindings/gpio/gpio-sprd.txt
deleted file mode 100644
index eca97d45388f..000000000000
--- a/Documentation/devicetree/bindings/gpio/gpio-sprd.txt
+++ /dev/null
@@ -1,28 +0,0 @@
-Spreadtrum GPIO controller bindings
-
-The controller's registers are organized as sets of sixteen 16-bit
-registers with each set controlling a bank of up to 16 pins. A single
-interrupt is shared for all of the banks handled by the controller.
-
-Required properties:
-- compatible: Should be "sprd,sc9860-gpio".
-- reg: Define the base and range of the I/O address space containing
-the GPIO controller registers.
-- gpio-controller: Marks the device node as a GPIO controller.
-- #gpio-cells: Should be <2>. The first cell is the gpio number and
-the second cell is used to specify optional parameters.
-- interrupt-controller: Marks the device node as an interrupt controller.
-- #interrupt-cells: Should be <2>. Specifies the number of cells needed
-to encode interrupt source.
-- interrupts: Should be the port interrupt shared by all the gpios.
-
-Example:
- ap_gpio: gpio@40280000 {
- compatible = "sprd,sc9860-gpio";
- reg = <0 0x40280000 0 0x1000>;
- gpio-controller;
- #gpio-cells = <2>;
- interrupt-controller;
- #interrupt-cells = <2>;
- interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>;
- };
diff --git a/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml b/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml
new file mode 100644
index 000000000000..c0cd1ed9809b
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml
@@ -0,0 +1,70 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright 2022 Unisoc Inc.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/sprd,gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Unisoc GPIO controller
+
+maintainers:
+ - Orson Zhai <orsonzhai@gmail.com>
+ - Baolin Wang <baolin.wang7@gmail.com>
+ - Chunyan Zhang <zhang.lyra@gmail.com>
+
+description:
+ The controller's registers are organized as sets of sixteen 16-bit
+ registers with each set controlling a bank of up to 16 pins. A single
+ interrupt is shared for all of the banks handled by the controller.
+
+properties:
+ compatible:
+ const: sprd,sc9860-gpio
+
+ reg:
+ maxItems: 1
+
+ gpio-controller: true
+
+ "#gpio-cells":
+ const: 2
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+ const: 2
+
+ interrupts:
+ maxItems: 1
+ description: The interrupt shared by all GPIO lines for this controller.
+
+required:
+ - compatible
+ - reg
+ - gpio-controller
+ - "#gpio-cells"
+ - interrupt-controller
+ - "#interrupt-cells"
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ ap_gpio: gpio@40280000 {
+ compatible = "sprd,sc9860-gpio";
+ reg = <0 0x40280000 0 0x1000>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ };
+...
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH V2 1/3] dt-bindings: gpio: Convert Unisoc GPIO controller binding to yaml
2022-09-30 8:24 ` [PATCH V2 1/3] dt-bindings: gpio: Convert Unisoc GPIO controller binding to yaml Chunyan Zhang
@ 2022-09-30 11:07 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-30 11:07 UTC (permalink / raw)
To: Chunyan Zhang, Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski
Cc: linux-gpio, devicetree, Baolin Wang, Orson Zhai, Chunyan Zhang,
LKML
On 30/09/2022 10:24, Chunyan Zhang wrote:
> From: Chunyan Zhang <chunyan.zhang@unisoc.com>
>
> Convert the Unisoc gpio controller binding to DT schema format.
>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC controller binding to yaml
2022-09-30 8:24 [PATCH V2 0/3] Convert Unisoc GPIO bindings to yaml and add support for UMS512 Chunyan Zhang
2022-09-30 8:24 ` [PATCH V2 1/3] dt-bindings: gpio: Convert Unisoc GPIO controller binding to yaml Chunyan Zhang
@ 2022-09-30 8:24 ` Chunyan Zhang
2022-09-30 11:09 ` Krzysztof Kozlowski
2022-09-30 21:41 ` Rob Herring
2022-09-30 8:24 ` [PATCH V2 3/3] dt-bindings: gpio: Add compatible string to support Unisoc UMS512 Chunyan Zhang
2 siblings, 2 replies; 10+ messages in thread
From: Chunyan Zhang @ 2022-09-30 8:24 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski
Cc: linux-gpio, devicetree, Baolin Wang, Orson Zhai, Chunyan Zhang,
Chunyan Zhang, LKML
From: Chunyan Zhang <chunyan.zhang@unisoc.com>
Convert the Unisoc EIC controller binding to DT schema format.
Update the maxItems of 'reg' property, since the current gpio-eic-sprd
driver supports 3 reg items. Also remove three redundant examples.
Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
---
.../bindings/gpio/gpio-eic-sprd.txt | 97 --------------
.../bindings/gpio/sprd,gpio-eic.yaml | 119 ++++++++++++++++++
2 files changed, 119 insertions(+), 97 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
create mode 100644 Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
diff --git a/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt b/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
deleted file mode 100644
index 54040a2bfe3a..000000000000
--- a/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
+++ /dev/null
@@ -1,97 +0,0 @@
-Spreadtrum EIC controller bindings
-
-The EIC is the abbreviation of external interrupt controller, which can
-be used only in input mode. The Spreadtrum platform has 2 EIC controllers,
-one is in digital chip, and another one is in PMIC. The digital chip EIC
-controller contains 4 sub-modules: EIC-debounce, EIC-latch, EIC-async and
-EIC-sync. But the PMIC EIC controller contains only one EIC-debounce sub-
-module.
-
-The EIC-debounce sub-module provides up to 8 source input signal
-connections. A debounce mechanism is used to capture the input signals'
-stable status (millisecond resolution) and a single-trigger mechanism
-is introduced into this sub-module to enhance the input event detection
-reliability. In addition, this sub-module's clock can be shut off
-automatically to reduce power dissipation. Moreover the debounce range
-is from 1ms to 4s with a step size of 1ms. The input signal will be
-ignored if it is asserted for less than 1 ms.
-
-The EIC-latch sub-module is used to latch some special power down signals
-and generate interrupts, since the EIC-latch does not depend on the APB
-clock to capture signals.
-
-The EIC-async sub-module uses a 32kHz clock to capture the short signals
-(microsecond resolution) to generate interrupts by level or edge trigger.
-
-The EIC-sync is similar with GPIO's input function, which is a synchronized
-signal input register. It can generate interrupts by level or edge trigger
-when detecting input signals.
-
-Required properties:
-- compatible: Should be one of the following:
- "sprd,sc9860-eic-debounce",
- "sprd,sc9860-eic-latch",
- "sprd,sc9860-eic-async",
- "sprd,sc9860-eic-sync",
- "sprd,sc2731-eic".
-- reg: Define the base and range of the I/O address space containing
- the GPIO controller registers.
-- gpio-controller: Marks the device node as a GPIO controller.
-- #gpio-cells: Should be <2>. The first cell is the gpio number and
- the second cell is used to specify optional parameters.
-- interrupt-controller: Marks the device node as an interrupt controller.
-- #interrupt-cells: Should be <2>. Specifies the number of cells needed
- to encode interrupt source.
-- interrupts: Should be the port interrupt shared by all the gpios.
-
-Example:
- eic_debounce: gpio@40210000 {
- compatible = "sprd,sc9860-eic-debounce";
- reg = <0 0x40210000 0 0x80>;
- gpio-controller;
- #gpio-cells = <2>;
- interrupt-controller;
- #interrupt-cells = <2>;
- interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
- };
-
- eic_latch: gpio@40210080 {
- compatible = "sprd,sc9860-eic-latch";
- reg = <0 0x40210080 0 0x20>;
- gpio-controller;
- #gpio-cells = <2>;
- interrupt-controller;
- #interrupt-cells = <2>;
- interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
- };
-
- eic_async: gpio@402100a0 {
- compatible = "sprd,sc9860-eic-async";
- reg = <0 0x402100a0 0 0x20>;
- gpio-controller;
- #gpio-cells = <2>;
- interrupt-controller;
- #interrupt-cells = <2>;
- interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
- };
-
- eic_sync: gpio@402100c0 {
- compatible = "sprd,sc9860-eic-sync";
- reg = <0 0x402100c0 0 0x20>;
- gpio-controller;
- #gpio-cells = <2>;
- interrupt-controller;
- #interrupt-cells = <2>;
- interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
- };
-
- pmic_eic: gpio@300 {
- compatible = "sprd,sc2731-eic";
- reg = <0x300>;
- interrupt-parent = <&sc2731_pmic>;
- interrupts = <5 IRQ_TYPE_LEVEL_HIGH>;
- gpio-controller;
- #gpio-cells = <2>;
- interrupt-controller;
- #interrupt-cells = <2>;
- };
diff --git a/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml b/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
new file mode 100644
index 000000000000..c288a8dd44c8
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
@@ -0,0 +1,119 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright 2022 Unisoc Inc.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/sprd,gpio-eic.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Unisoc EIC controller
+
+maintainers:
+ - Orson Zhai <orsonzhai@gmail.com>
+ - Baolin Wang <baolin.wang7@gmail.com>
+ - Chunyan Zhang <zhang.lyra@gmail.com>
+
+description:
+ The EIC is the abbreviation of external interrupt controller, which can
+ be used only in input mode. The Spreadtrum platform has 2 EIC controllers,
+ one is in digital chip, and another one is in PMIC. The digital chip EIC
+ controller contains 4 sub-modules, i.e. EIC-debounce, EIC-latch, EIC-async and
+ EIC-sync. But the PMIC EIC controller contains only one EIC-debounce sub-
+ module.
+
+ The EIC-debounce sub-module provides up to 8 source input signal
+ connections. A debounce mechanism is used to capture the input signals'
+ stable status (millisecond resolution) and a single-trigger mechanism
+ is introduced into this sub-module to enhance the input event detection
+ reliability. In addition, this sub-module's clock can be shut off
+ automatically to reduce power dissipation. Moreover the debounce range
+ is from 1ms to 4s with a step size of 1ms. The input signal will be
+ ignored if it is asserted for less than 1 ms.
+
+ The EIC-latch sub-module is used to latch some special power down signals
+ and generate interrupts, since the EIC-latch does not depend on the APB
+ clock to capture signals.
+
+ The EIC-async sub-module uses a 32kHz clock to capture the short signals
+ (microsecond resolution) to generate interrupts by level or edge trigger.
+
+ The EIC-sync is similar with GPIO's input function, which is a synchronized
+ signal input register. It can generate interrupts by level or edge trigger
+ when detecting input signals.
+
+properties:
+ compatible:
+ enum:
+ - sprd,sc9860-eic-debounce
+ - sprd,sc9860-eic-latch
+ - sprd,sc9860-eic-async
+ - sprd,sc9860-eic-sync
+ - sprd,sc2731-eic
+
+ reg:
+ minItems: 1
+ maxItems: 3
+ description:
+ EIC controller can support maximum 3 banks which has its own
+ address base.
+
+ gpio-controller: true
+
+ "#gpio-cells":
+ const: 2
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+ const: 2
+
+ interrupts:
+ maxItems: 1
+ description:
+ The interrupt shared by all GPIO lines for this controller.
+
+required:
+ - compatible
+ - reg
+ - gpio-controller
+ - "#gpio-cells"
+ - interrupt-controller
+ - "#interrupt-cells"
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ eic_debounce: gpio@40210000 {
+ compatible = "sprd,sc9860-eic-debounce";
+ reg = <0 0x40210000 0 0x80>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ };
+
+ sc2730_pmic {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic_eic: gpio@300 {
+ compatible = "sprd,sc2731-eic";
+ reg = <0x300>;
+ interrupt-parent = <&sc2731_pmic>;
+ interrupts = <5 IRQ_TYPE_LEVEL_HIGH>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+ };
+...
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC controller binding to yaml
2022-09-30 8:24 ` [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC " Chunyan Zhang
@ 2022-09-30 11:09 ` Krzysztof Kozlowski
2022-10-08 2:57 ` Chunyan Zhang
2022-09-30 21:41 ` Rob Herring
1 sibling, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-30 11:09 UTC (permalink / raw)
To: Chunyan Zhang, Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski
Cc: linux-gpio, devicetree, Baolin Wang, Orson Zhai, Chunyan Zhang,
LKML
On 30/09/2022 10:24, Chunyan Zhang wrote:
> From: Chunyan Zhang <chunyan.zhang@unisoc.com>
>
> Convert the Unisoc EIC controller binding to DT schema format.
> Update the maxItems of 'reg' property, since the current gpio-eic-sprd
> driver supports 3 reg items. Also remove three redundant examples.
>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> ---
> .../bindings/gpio/gpio-eic-sprd.txt | 97 --------------
> .../bindings/gpio/sprd,gpio-eic.yaml | 119 ++++++++++++++++++
> 2 files changed, 119 insertions(+), 97 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
> create mode 100644 Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt b/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
> deleted file mode 100644
> index 54040a2bfe3a..000000000000
> --- a/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
> +++ /dev/null
> @@ -1,97 +0,0 @@
> -Spreadtrum EIC controller bindings
> -
> -The EIC is the abbreviation of external interrupt controller, which can
> -be used only in input mode. The Spreadtrum platform has 2 EIC controllers,
> -one is in digital chip, and another one is in PMIC. The digital chip EIC
> -controller contains 4 sub-modules: EIC-debounce, EIC-latch, EIC-async and
> -EIC-sync. But the PMIC EIC controller contains only one EIC-debounce sub-
> -module.
> -
> -The EIC-debounce sub-module provides up to 8 source input signal
> -connections. A debounce mechanism is used to capture the input signals'
> -stable status (millisecond resolution) and a single-trigger mechanism
> -is introduced into this sub-module to enhance the input event detection
> -reliability. In addition, this sub-module's clock can be shut off
> -automatically to reduce power dissipation. Moreover the debounce range
> -is from 1ms to 4s with a step size of 1ms. The input signal will be
> -ignored if it is asserted for less than 1 ms.
> -
> -The EIC-latch sub-module is used to latch some special power down signals
> -and generate interrupts, since the EIC-latch does not depend on the APB
> -clock to capture signals.
> -
> -The EIC-async sub-module uses a 32kHz clock to capture the short signals
> -(microsecond resolution) to generate interrupts by level or edge trigger.
> -
> -The EIC-sync is similar with GPIO's input function, which is a synchronized
> -signal input register. It can generate interrupts by level or edge trigger
> -when detecting input signals.
> -
> -Required properties:
> -- compatible: Should be one of the following:
> - "sprd,sc9860-eic-debounce",
> - "sprd,sc9860-eic-latch",
> - "sprd,sc9860-eic-async",
> - "sprd,sc9860-eic-sync",
> - "sprd,sc2731-eic".
> -- reg: Define the base and range of the I/O address space containing
> - the GPIO controller registers.
> -- gpio-controller: Marks the device node as a GPIO controller.
> -- #gpio-cells: Should be <2>. The first cell is the gpio number and
> - the second cell is used to specify optional parameters.
> -- interrupt-controller: Marks the device node as an interrupt controller.
> -- #interrupt-cells: Should be <2>. Specifies the number of cells needed
> - to encode interrupt source.
> -- interrupts: Should be the port interrupt shared by all the gpios.
> -
> -Example:
> - eic_debounce: gpio@40210000 {
> - compatible = "sprd,sc9860-eic-debounce";
> - reg = <0 0x40210000 0 0x80>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> - };
> -
> - eic_latch: gpio@40210080 {
> - compatible = "sprd,sc9860-eic-latch";
> - reg = <0 0x40210080 0 0x20>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> - };
> -
> - eic_async: gpio@402100a0 {
> - compatible = "sprd,sc9860-eic-async";
> - reg = <0 0x402100a0 0 0x20>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> - };
> -
> - eic_sync: gpio@402100c0 {
> - compatible = "sprd,sc9860-eic-sync";
> - reg = <0 0x402100c0 0 0x20>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> - };
> -
> - pmic_eic: gpio@300 {
> - compatible = "sprd,sc2731-eic";
> - reg = <0x300>;
> - interrupt-parent = <&sc2731_pmic>;
> - interrupts = <5 IRQ_TYPE_LEVEL_HIGH>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - };
> diff --git a/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml b/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
> new file mode 100644
> index 000000000000..c288a8dd44c8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
> @@ -0,0 +1,119 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2022 Unisoc Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/sprd,gpio-eic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Unisoc EIC controller
> +
> +maintainers:
> + - Orson Zhai <orsonzhai@gmail.com>
> + - Baolin Wang <baolin.wang7@gmail.com>
> + - Chunyan Zhang <zhang.lyra@gmail.com>
> +
> +description:
> + The EIC is the abbreviation of external interrupt controller, which can
> + be used only in input mode. The Spreadtrum platform has 2 EIC controllers,
> + one is in digital chip, and another one is in PMIC. The digital chip EIC
> + controller contains 4 sub-modules, i.e. EIC-debounce, EIC-latch, EIC-async and
> + EIC-sync. But the PMIC EIC controller contains only one EIC-debounce sub-
> + module.
> +
> + The EIC-debounce sub-module provides up to 8 source input signal
> + connections. A debounce mechanism is used to capture the input signals'
> + stable status (millisecond resolution) and a single-trigger mechanism
> + is introduced into this sub-module to enhance the input event detection
> + reliability. In addition, this sub-module's clock can be shut off
> + automatically to reduce power dissipation. Moreover the debounce range
> + is from 1ms to 4s with a step size of 1ms. The input signal will be
> + ignored if it is asserted for less than 1 ms.
> +
> + The EIC-latch sub-module is used to latch some special power down signals
> + and generate interrupts, since the EIC-latch does not depend on the APB
> + clock to capture signals.
> +
> + The EIC-async sub-module uses a 32kHz clock to capture the short signals
> + (microsecond resolution) to generate interrupts by level or edge trigger.
> +
> + The EIC-sync is similar with GPIO's input function, which is a synchronized
> + signal input register. It can generate interrupts by level or edge trigger
> + when detecting input signals.
> +
> +properties:
> + compatible:
> + enum:
> + - sprd,sc9860-eic-debounce
> + - sprd,sc9860-eic-latch
> + - sprd,sc9860-eic-async
> + - sprd,sc9860-eic-sync
> + - sprd,sc2731-eic
> +
> + reg:
> + minItems: 1
> + maxItems: 3
> + description:
> + EIC controller can support maximum 3 banks which has its own
> + address base.
> +
> + gpio-controller: true
> +
> + "#gpio-cells":
> + const: 2
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 2
> +
> + interrupts:
> + maxItems: 1
> + description:
> + The interrupt shared by all GPIO lines for this controller.
> +
> +required:
> + - compatible
> + - reg
> + - gpio-controller
> + - "#gpio-cells"
> + - interrupt-controller
> + - "#interrupt-cells"
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + eic_debounce: gpio@40210000 {
> + compatible = "sprd,sc9860-eic-debounce";
> + reg = <0 0x40210000 0 0x80>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> + };
> + };
> +
> + sc2730_pmic {
If you insisted to keep it, at least should be correct, so just pmic.
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic_eic: gpio@300 {
It's exactly the same example as above - all same properties. Drop it or
bring some differences.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC controller binding to yaml
2022-09-30 11:09 ` Krzysztof Kozlowski
@ 2022-10-08 2:57 ` Chunyan Zhang
2022-10-09 15:14 ` Krzysztof Kozlowski
0 siblings, 1 reply; 10+ messages in thread
From: Chunyan Zhang @ 2022-10-08 2:57 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, linux-gpio, devicetree, Baolin Wang,
Orson Zhai, Chunyan Zhang, LKML
On Fri, 30 Sept 2022 at 19:09, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 30/09/2022 10:24, Chunyan Zhang wrote:
> > From: Chunyan Zhang <chunyan.zhang@unisoc.com>
> >
> > Convert the Unisoc EIC controller binding to DT schema format.
> > Update the maxItems of 'reg' property, since the current gpio-eic-sprd
> > driver supports 3 reg items. Also remove three redundant examples.
> >
> > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> > ---
> > .../bindings/gpio/gpio-eic-sprd.txt | 97 --------------
> > .../bindings/gpio/sprd,gpio-eic.yaml | 119 ++++++++++++++++++
> > 2 files changed, 119 insertions(+), 97 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
> > create mode 100644 Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
[snip]
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > + soc {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + eic_debounce: gpio@40210000 {
> > + compatible = "sprd,sc9860-eic-debounce";
> > + reg = <0 0x40210000 0 0x80>;
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > + interrupt-controller;
> > + #interrupt-cells = <2>;
> > + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> > + };
> > + };
> > +
> > + sc2730_pmic {
>
> If you insisted to keep it, at least should be correct, so just pmic.
>
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + pmic_eic: gpio@300 {
>
> It's exactly the same example as above - all same properties. Drop it or
> bring some differences.
The differences are on #address-cells and #size-cells.
Thanks for the review,
Chunyan
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC controller binding to yaml
2022-10-08 2:57 ` Chunyan Zhang
@ 2022-10-09 15:14 ` Krzysztof Kozlowski
2022-10-10 1:52 ` Chunyan Zhang
0 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-09 15:14 UTC (permalink / raw)
To: Chunyan Zhang
Cc: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, linux-gpio, devicetree, Baolin Wang,
Orson Zhai, Chunyan Zhang, LKML
On 08/10/2022 04:57, Chunyan Zhang wrote:
>>> + eic_debounce: gpio@40210000 {
>>> + compatible = "sprd,sc9860-eic-debounce";
>>> + reg = <0 0x40210000 0 0x80>;
>>> + gpio-controller;
>>> + #gpio-cells = <2>;
>>> + interrupt-controller;
>>> + #interrupt-cells = <2>;
>>> + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
>>> + };
>>> + };
>>> +
>>> + sc2730_pmic {
>>
>> If you insisted to keep it, at least should be correct, so just pmic.
>>
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + pmic_eic: gpio@300 {
>>
>> It's exactly the same example as above - all same properties. Drop it or
>> bring some differences.
>
> The differences are on #address-cells and #size-cells.
>
Which don't really matter...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC controller binding to yaml
2022-10-09 15:14 ` Krzysztof Kozlowski
@ 2022-10-10 1:52 ` Chunyan Zhang
0 siblings, 0 replies; 10+ messages in thread
From: Chunyan Zhang @ 2022-10-10 1:52 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, linux-gpio, devicetree, Baolin Wang,
Orson Zhai, Chunyan Zhang, LKML
On Sun, 9 Oct 2022 at 23:17, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 08/10/2022 04:57, Chunyan Zhang wrote:
> >>> + eic_debounce: gpio@40210000 {
> >>> + compatible = "sprd,sc9860-eic-debounce";
> >>> + reg = <0 0x40210000 0 0x80>;
> >>> + gpio-controller;
> >>> + #gpio-cells = <2>;
> >>> + interrupt-controller;
> >>> + #interrupt-cells = <2>;
> >>> + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> >>> + };
> >>> + };
> >>> +
> >>> + sc2730_pmic {
> >>
> >> If you insisted to keep it, at least should be correct, so just pmic.
> >>
> >>> + #address-cells = <1>;
> >>> + #size-cells = <0>;
> >>> +
> >>> + pmic_eic: gpio@300 {
> >>
> >> It's exactly the same example as above - all same properties. Drop it or
> >> bring some differences.
> >
> > The differences are on #address-cells and #size-cells.
> >
>
> Which don't really matter...
Alright, will drop it in the next version.
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC controller binding to yaml
2022-09-30 8:24 ` [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC " Chunyan Zhang
2022-09-30 11:09 ` Krzysztof Kozlowski
@ 2022-09-30 21:41 ` Rob Herring
1 sibling, 0 replies; 10+ messages in thread
From: Rob Herring @ 2022-09-30 21:41 UTC (permalink / raw)
To: Chunyan Zhang
Cc: Linus Walleij, Bartosz Golaszewski, Krzysztof Kozlowski,
linux-gpio, devicetree, Baolin Wang, Orson Zhai, Chunyan Zhang,
LKML
On Fri, Sep 30, 2022 at 04:24:04PM +0800, Chunyan Zhang wrote:
> From: Chunyan Zhang <chunyan.zhang@unisoc.com>
>
> Convert the Unisoc EIC controller binding to DT schema format.
> Update the maxItems of 'reg' property, since the current gpio-eic-sprd
> driver supports 3 reg items. Also remove three redundant examples.
>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> ---
> .../bindings/gpio/gpio-eic-sprd.txt | 97 --------------
> .../bindings/gpio/sprd,gpio-eic.yaml | 119 ++++++++++++++++++
> 2 files changed, 119 insertions(+), 97 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
> create mode 100644 Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt b/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
> deleted file mode 100644
> index 54040a2bfe3a..000000000000
> --- a/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
> +++ /dev/null
> @@ -1,97 +0,0 @@
> -Spreadtrum EIC controller bindings
> -
> -The EIC is the abbreviation of external interrupt controller, which can
> -be used only in input mode. The Spreadtrum platform has 2 EIC controllers,
> -one is in digital chip, and another one is in PMIC. The digital chip EIC
> -controller contains 4 sub-modules: EIC-debounce, EIC-latch, EIC-async and
> -EIC-sync. But the PMIC EIC controller contains only one EIC-debounce sub-
> -module.
> -
> -The EIC-debounce sub-module provides up to 8 source input signal
> -connections. A debounce mechanism is used to capture the input signals'
> -stable status (millisecond resolution) and a single-trigger mechanism
> -is introduced into this sub-module to enhance the input event detection
> -reliability. In addition, this sub-module's clock can be shut off
> -automatically to reduce power dissipation. Moreover the debounce range
> -is from 1ms to 4s with a step size of 1ms. The input signal will be
> -ignored if it is asserted for less than 1 ms.
> -
> -The EIC-latch sub-module is used to latch some special power down signals
> -and generate interrupts, since the EIC-latch does not depend on the APB
> -clock to capture signals.
> -
> -The EIC-async sub-module uses a 32kHz clock to capture the short signals
> -(microsecond resolution) to generate interrupts by level or edge trigger.
> -
> -The EIC-sync is similar with GPIO's input function, which is a synchronized
> -signal input register. It can generate interrupts by level or edge trigger
> -when detecting input signals.
> -
> -Required properties:
> -- compatible: Should be one of the following:
> - "sprd,sc9860-eic-debounce",
> - "sprd,sc9860-eic-latch",
> - "sprd,sc9860-eic-async",
> - "sprd,sc9860-eic-sync",
> - "sprd,sc2731-eic".
> -- reg: Define the base and range of the I/O address space containing
> - the GPIO controller registers.
> -- gpio-controller: Marks the device node as a GPIO controller.
> -- #gpio-cells: Should be <2>. The first cell is the gpio number and
> - the second cell is used to specify optional parameters.
> -- interrupt-controller: Marks the device node as an interrupt controller.
> -- #interrupt-cells: Should be <2>. Specifies the number of cells needed
> - to encode interrupt source.
> -- interrupts: Should be the port interrupt shared by all the gpios.
> -
> -Example:
> - eic_debounce: gpio@40210000 {
> - compatible = "sprd,sc9860-eic-debounce";
> - reg = <0 0x40210000 0 0x80>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> - };
> -
> - eic_latch: gpio@40210080 {
> - compatible = "sprd,sc9860-eic-latch";
> - reg = <0 0x40210080 0 0x20>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> - };
> -
> - eic_async: gpio@402100a0 {
> - compatible = "sprd,sc9860-eic-async";
> - reg = <0 0x402100a0 0 0x20>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> - };
> -
> - eic_sync: gpio@402100c0 {
> - compatible = "sprd,sc9860-eic-sync";
> - reg = <0 0x402100c0 0 0x20>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> - };
> -
> - pmic_eic: gpio@300 {
> - compatible = "sprd,sc2731-eic";
> - reg = <0x300>;
> - interrupt-parent = <&sc2731_pmic>;
> - interrupts = <5 IRQ_TYPE_LEVEL_HIGH>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - };
> diff --git a/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml b/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
> new file mode 100644
> index 000000000000..c288a8dd44c8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
> @@ -0,0 +1,119 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2022 Unisoc Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/sprd,gpio-eic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Unisoc EIC controller
> +
> +maintainers:
> + - Orson Zhai <orsonzhai@gmail.com>
> + - Baolin Wang <baolin.wang7@gmail.com>
> + - Chunyan Zhang <zhang.lyra@gmail.com>
> +
> +description:
If you want the formatting maintained, you need '|' on the end.
> + The EIC is the abbreviation of external interrupt controller, which can
> + be used only in input mode. The Spreadtrum platform has 2 EIC controllers,
> + one is in digital chip, and another one is in PMIC. The digital chip EIC
> + controller contains 4 sub-modules, i.e. EIC-debounce, EIC-latch, EIC-async and
> + EIC-sync. But the PMIC EIC controller contains only one EIC-debounce sub-
> + module.
> +
> + The EIC-debounce sub-module provides up to 8 source input signal
> + connections. A debounce mechanism is used to capture the input signals'
> + stable status (millisecond resolution) and a single-trigger mechanism
> + is introduced into this sub-module to enhance the input event detection
> + reliability. In addition, this sub-module's clock can be shut off
> + automatically to reduce power dissipation. Moreover the debounce range
> + is from 1ms to 4s with a step size of 1ms. The input signal will be
> + ignored if it is asserted for less than 1 ms.
> +
> + The EIC-latch sub-module is used to latch some special power down signals
> + and generate interrupts, since the EIC-latch does not depend on the APB
> + clock to capture signals.
> +
> + The EIC-async sub-module uses a 32kHz clock to capture the short signals
> + (microsecond resolution) to generate interrupts by level or edge trigger.
> +
> + The EIC-sync is similar with GPIO's input function, which is a synchronized
> + signal input register. It can generate interrupts by level or edge trigger
> + when detecting input signals.
> +
> +properties:
> + compatible:
> + enum:
> + - sprd,sc9860-eic-debounce
> + - sprd,sc9860-eic-latch
> + - sprd,sc9860-eic-async
> + - sprd,sc9860-eic-sync
> + - sprd,sc2731-eic
> +
> + reg:
> + minItems: 1
> + maxItems: 3
> + description:
> + EIC controller can support maximum 3 banks which has its own
> + address base.
> +
> + gpio-controller: true
> +
> + "#gpio-cells":
> + const: 2
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 2
> +
> + interrupts:
> + maxItems: 1
> + description:
> + The interrupt shared by all GPIO lines for this controller.
> +
> +required:
> + - compatible
> + - reg
> + - gpio-controller
> + - "#gpio-cells"
> + - interrupt-controller
> + - "#interrupt-cells"
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + eic_debounce: gpio@40210000 {
> + compatible = "sprd,sc9860-eic-debounce";
> + reg = <0 0x40210000 0 0x80>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> + };
> + };
> +
> + sc2730_pmic {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic_eic: gpio@300 {
> + compatible = "sprd,sc2731-eic";
> + reg = <0x300>;
> + interrupt-parent = <&sc2731_pmic>;
> + interrupts = <5 IRQ_TYPE_LEVEL_HIGH>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> + };
> +...
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V2 3/3] dt-bindings: gpio: Add compatible string to support Unisoc UMS512
2022-09-30 8:24 [PATCH V2 0/3] Convert Unisoc GPIO bindings to yaml and add support for UMS512 Chunyan Zhang
2022-09-30 8:24 ` [PATCH V2 1/3] dt-bindings: gpio: Convert Unisoc GPIO controller binding to yaml Chunyan Zhang
2022-09-30 8:24 ` [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC " Chunyan Zhang
@ 2022-09-30 8:24 ` Chunyan Zhang
2 siblings, 0 replies; 10+ messages in thread
From: Chunyan Zhang @ 2022-09-30 8:24 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski
Cc: linux-gpio, devicetree, Baolin Wang, Orson Zhai, Chunyan Zhang,
Chunyan Zhang, LKML
From: Chunyan Zhang <chunyan.zhang@unisoc.com>
UMS512 use the same GPIO and EIC controller IP with SC9860.
Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/gpio/sprd,gpio-eic.yaml | 33 +++++++++++++++----
.../devicetree/bindings/gpio/sprd,gpio.yaml | 7 +++-
2 files changed, 33 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml b/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
index c288a8dd44c8..3b7d338d44fb 100644
--- a/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
+++ b/Documentation/devicetree/bindings/gpio/sprd,gpio-eic.yaml
@@ -42,12 +42,33 @@ description:
properties:
compatible:
- enum:
- - sprd,sc9860-eic-debounce
- - sprd,sc9860-eic-latch
- - sprd,sc9860-eic-async
- - sprd,sc9860-eic-sync
- - sprd,sc2731-eic
+ oneOf:
+ - enum:
+ - sprd,sc9860-eic-debounce
+ - sprd,sc9860-eic-latch
+ - sprd,sc9860-eic-async
+ - sprd,sc9860-eic-sync
+ - sprd,sc2731-eic
+ - items:
+ - enum:
+ - sprd,ums512-eic-debounce
+ - const: sprd,sc9860-eic-debounce
+ - items:
+ - enum:
+ - sprd,ums512-eic-latch
+ - const: sprd,sc9860-eic-latch
+ - items:
+ - enum:
+ - sprd,ums512-eic-async
+ - const: sprd,sc9860-eic-async
+ - items:
+ - enum:
+ - sprd,ums512-eic-sync
+ - const: sprd,sc9860-eic-sync
+ - items:
+ - enum:
+ - sprd,sc2730-eic
+ - const: sprd,sc2731-eic
reg:
minItems: 1
diff --git a/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml b/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml
index c0cd1ed9809b..a1ecb2b96a76 100644
--- a/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml
@@ -19,7 +19,12 @@ description:
properties:
compatible:
- const: sprd,sc9860-gpio
+ oneOf:
+ - const: sprd,sc9860-gpio
+ - items:
+ - enum:
+ - sprd,ums512-gpio
+ - const: sprd,sc9860-gpio
reg:
maxItems: 1
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread