All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Stafford Horne <shorne@gmail.com>
Cc: openrisc@lists.librecores.org, gcc-patches@gcc.gnu.org,
	Yann Morin <yann.morin@orange.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] or1k: Only define TARGET_HAVE_TLS when HAVE_AS_TLS
Date: Sat, 1 Oct 2022 19:53:32 +0200	[thread overview]
Message-ID: <20221001175332.GN30794@scaer> (raw)
In-Reply-To: <YzgmG9Ihqt6xC7CA@oscomms1>

Stafford, All,

On 2022-10-01 11:35 +0000, Stafford Horne spake thusly:
> On Thu, Sep 29, 2022 at 03:57:40PM +0100, Stafford Horne wrote:
> > This was found when testing buildroot with linuxthreads enabled.  In
> > this case, the build passes --disable-tls to the toolchain during
> > configuration.  After building the OpenRISC toolchain it was still
> > generating TLS code sequences and causing linker failures such as:
> > 
> >  ..../or1k-buildroot-linux-uclibc-gcc -o gpsd-3.24/gpsctl .... -lusb-1.0 -lm -lrt -lnsl
> >  ..../ld: ..../sysroot/usr/lib/libusb-1.0.so: undefined reference to `__tls_get_addr'
> > 
> > This patch fixes this by disabling tls for the OpenRISC target when requested
> > via --disable-tls.
> > 
> > Tested-by: Yann E. MORIN <yann.morin@orange.com>
> > 
> > gcc/ChangeLog:
> > 
> > 	* config/or1k/or1k.cc (TARGET_HAVE_TLS): Only define if
> > 	HAVE_AS_TLS is defined.
> 
> I have pushed this upstream now.  Adding buildroot patches should be easy to do
> now.

That's great, thanks for fixing this! :-)

I'll poke my work alter-ego on Monday to look at providing the backports
for Buildroot.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

WARNING: multiple messages have this Message-ID (diff)
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Stafford Horne <shorne@gmail.com>
Cc: openrisc@lists.librecores.org, gcc-patches@gcc.gnu.org,
	Yann Morin <yann.morin@orange.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] or1k: Only define TARGET_HAVE_TLS when HAVE_AS_TLS
Date: Sat, 1 Oct 2022 19:53:32 +0200	[thread overview]
Message-ID: <20221001175332.GN30794@scaer> (raw)
In-Reply-To: <YzgmG9Ihqt6xC7CA@oscomms1>

Stafford, All,

On 2022-10-01 11:35 +0000, Stafford Horne spake thusly:
> On Thu, Sep 29, 2022 at 03:57:40PM +0100, Stafford Horne wrote:
> > This was found when testing buildroot with linuxthreads enabled.  In
> > this case, the build passes --disable-tls to the toolchain during
> > configuration.  After building the OpenRISC toolchain it was still
> > generating TLS code sequences and causing linker failures such as:
> > 
> >  ..../or1k-buildroot-linux-uclibc-gcc -o gpsd-3.24/gpsctl .... -lusb-1.0 -lm -lrt -lnsl
> >  ..../ld: ..../sysroot/usr/lib/libusb-1.0.so: undefined reference to `__tls_get_addr'
> > 
> > This patch fixes this by disabling tls for the OpenRISC target when requested
> > via --disable-tls.
> > 
> > Tested-by: Yann E. MORIN <yann.morin@orange.com>
> > 
> > gcc/ChangeLog:
> > 
> > 	* config/or1k/or1k.cc (TARGET_HAVE_TLS): Only define if
> > 	HAVE_AS_TLS is defined.
> 
> I have pushed this upstream now.  Adding buildroot patches should be easy to do
> now.

That's great, thanks for fixing this! :-)

I'll poke my work alter-ego on Monday to look at providing the backports
for Buildroot.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2022-10-01 17:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29 14:57 [PATCH] or1k: Only define TARGET_HAVE_TLS when HAVE_AS_TLS Stafford Horne
2022-10-01 11:35 ` [Buildroot] " Stafford Horne
2022-10-01 11:35   ` Stafford Horne
2022-10-01 17:53   ` Yann E. MORIN [this message]
2022-10-01 17:53     ` [Buildroot] " Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221001175332.GN30794@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=openrisc@lists.librecores.org \
    --cc=shorne@gmail.com \
    --cc=yann.morin@orange.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.