From: Jakub Kicinski <kuba@kernel.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH net-next] once: add DO_ONCE_SLOW() for sleepable contexts
Date: Mon, 3 Oct 2022 10:25:20 -0700 [thread overview]
Message-ID: <20221003102520.75fc51b4@kernel.org> (raw)
In-Reply-To: <YzjCzGGGE3WUsQr0@zx2c4.com>
On Sun, 2 Oct 2022 00:44:28 +0200 Jason A. Donenfeld wrote:
> So instead, why not just branch on whether or not we can sleep here, if
> that can be worked out dynamically?
IDK if we can dynamically work out if _all_ _possible_ callers are
in a specific context, can we?
> If not, and if you really do need two sets of macros and functions,
> at least you can call the new one something other than "slow"? Maybe
> something about being _SLEEPABLE() instead?
+1 for s/SLOW/SLEEPABLE/. I was about to suggest s/SLOW/TASK/.
But I guess it's already applied..
next prev parent reply other threads:[~2022-10-03 17:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 20:51 [PATCH net-next] once: add DO_ONCE_SLOW() for sleepable contexts Eric Dumazet
2022-10-01 21:15 ` Willy Tarreau
2022-10-01 22:50 ` Jason A. Donenfeld
2022-10-02 5:38 ` Willy Tarreau
2022-10-01 22:44 ` Jason A. Donenfeld
2022-10-01 22:50 ` Eric Dumazet
2022-10-03 17:25 ` Jakub Kicinski [this message]
2022-10-03 17:43 ` Jason A. Donenfeld
2022-10-03 18:14 ` [PATCH net-next] once: rename _SLOW to _SLEEPABLE Jason A. Donenfeld
2022-10-03 18:14 ` [PATCH] " Jason A. Donenfeld
2022-10-03 22:50 ` Eric Dumazet
2022-10-02 8:58 ` [PATCH net-next] once: add DO_ONCE_SLOW() for sleepable contexts Christophe Leroy
2022-10-03 12:40 ` patchwork-bot+netdevbpf
2026-01-07 20:59 ` Luck, Tony
2026-01-07 21:17 ` Eric Dumazet
2026-01-07 22:34 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221003102520.75fc51b4@kernel.org \
--to=kuba@kernel.org \
--cc=Jason@zx2c4.com \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.