Re: [PATCH net-next] once: add DO_ONCE_SLOW() for sleepable contexts

["Luck, Tony" <tony.luck@intel.com>]

On Sat, Oct 01, 2022 at 01:51:02PM -0700, Eric Dumazet wrote:
> +void __do_once_slow_done(bool *done, struct static_key_true *once_key,
> +			 struct module *mod)
> +	__releases(once_mutex)
> +{
> +	*done = true;
> +	mutex_unlock(&once_mutex);
> +	once_disable_jump(once_key, mod);

This seems to have been cut & pasted from __do_once_done(). But is there
a reason for the "sleepable" version to defer resetting the static key
in a work queue? Can't we just inline do:

	BUG_ON(!static_key_enabled(once_key));
	static_branch_disable(once_key);

> +}

-Tony

Credit to Reinette for raising this question. Blame me if I didn't spot
why a work queue is needed.