* [merged mm-stable] mm-damon-lru_sort-deduplicate-hot-cold-schemes-generators.patch removed from -mm tree
@ 2022-10-03 21:07 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2022-10-03 21:07 UTC (permalink / raw)
To: mm-commits, sj, akpm
The quilt patch titled
Subject: mm/damon/lru_sort: deduplicate hot/cold schemes generators
has been removed from the -mm tree. Its filename was
mm-damon-lru_sort-deduplicate-hot-cold-schemes-generators.patch
This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: SeongJae Park <sj@kernel.org>
Subject: mm/damon/lru_sort: deduplicate hot/cold schemes generators
Date: Tue, 13 Sep 2022 17:44:49 +0000
damon_lru_sort_new_{hot,cold}_scheme() have quite a lot of duplicates.
This commit factors out the duplicate to a separate function and use it
for reducing the duplicate.
Link: https://lkml.kernel.org/r/20220913174449.50645-23-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/damon/lru_sort.c | 45 +++++++++++++++++++-----------------------
1 file changed, 21 insertions(+), 24 deletions(-)
--- a/mm/damon/lru_sort.c~mm-damon-lru_sort-deduplicate-hot-cold-schemes-generators
+++ a/mm/damon/lru_sort.c
@@ -135,6 +135,25 @@ DEFINE_DAMON_MODULES_DAMOS_STATS_PARAMS(
static struct damon_ctx *ctx;
static struct damon_target *target;
+static struct damos *damon_lru_sort_new_scheme(
+ struct damos_access_pattern *pattern, enum damos_action action)
+{
+ struct damos_quota quota = damon_lru_sort_quota;
+
+ /* Use half of total quota for hot/cold pages sorting */
+ quota.ms = quota.ms / 2;
+
+ return damon_new_scheme(
+ /* find the pattern, and */
+ pattern,
+ /* (de)prioritize on LRU-lists */
+ action,
+ /* under the quota. */
+ "a,
+ /* (De)activate this according to the watermarks. */
+ &damon_lru_sort_wmarks);
+}
+
/* Create a DAMON-based operation scheme for hot memory regions */
static struct damos *damon_lru_sort_new_hot_scheme(unsigned int hot_thres)
{
@@ -149,19 +168,8 @@ static struct damos *damon_lru_sort_new_
.min_age_region = 0,
.max_age_region = UINT_MAX,
};
- struct damos_quota quota = damon_lru_sort_quota;
-
- /* Use half of total quota for hot pages sorting */
- quota.ms = quota.ms / 2;
- return damon_new_scheme(
- &pattern,
- /* prioritize those on LRU lists, as soon as found */
- DAMOS_LRU_PRIO,
- /* under the quota. */
- "a,
- /* (De)activate this according to the watermarks. */
- &damon_lru_sort_wmarks);
+ return damon_lru_sort_new_scheme(&pattern, DAMOS_LRU_PRIO);
}
/* Create a DAMON-based operation scheme for cold memory regions */
@@ -178,19 +186,8 @@ static struct damos *damon_lru_sort_new_
.min_age_region = cold_thres,
.max_age_region = UINT_MAX,
};
- struct damos_quota quota = damon_lru_sort_quota;
- /* Use half of total quota for cold pages sorting */
- quota.ms = quota.ms / 2;
-
- return damon_new_scheme(
- &pattern,
- /* mark those as not accessed, as soon as found */
- DAMOS_LRU_DEPRIO,
- /* under the quota. */
- "a,
- /* (De)activate this according to the watermarks. */
- &damon_lru_sort_wmarks);
+ return damon_lru_sort_new_scheme(&pattern, DAMOS_LRU_DEPRIO);
}
static int damon_lru_sort_apply_parameters(void)
_
Patches currently in -mm which might be from sj@kernel.org are
mm-damon-core-initialize-damon_target-list-in-damon_new_target.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-03 21:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-03 21:07 [merged mm-stable] mm-damon-lru_sort-deduplicate-hot-cold-schemes-generators.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.