From: Sascha Hauer <s.hauer@pengutronix.de>
To: Dan Johansen <strit@manjaro.org>
Cc: "Heiko Stübner" <heiko@sntech.de>,
"Sandy Huang" <hjc@rock-chips.com>,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
"Michael Riesch" <michael.riesch@wolfvision.net>,
kernel@pengutronix.de, "Robin Murphy" <robin.murphy@arm.com>
Subject: Re: [PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support
Date: Wed, 5 Oct 2022 13:10:04 +0200 [thread overview]
Message-ID: <20221005111004.GS986@pengutronix.de> (raw)
In-Reply-To: <7721ac8b-7e8d-5131-70aa-7579d912a2bb@manjaro.org>
On Wed, Oct 05, 2022 at 12:51:57PM +0200, Dan Johansen wrote:
>
> Den 05.10.2022 kl. 12.06 skrev Sascha Hauer:
> > On Wed, Sep 28, 2022 at 10:39:27AM +0200, Dan Johansen wrote:
> > > Den 28.09.2022 kl. 10.37 skrev Sascha Hauer:
> > > > On Tue, Sep 27, 2022 at 07:53:54PM +0200, Dan Johansen wrote:
> > > > > Den 26.09.2022 kl. 12.30 skrev Michael Riesch:
> > > > > > Hi Sascha,
> > > > > >
> > > > > > On 9/26/22 10:04, Sascha Hauer wrote:
> > > > > > > This series adds support for 4k@30 to the rockchip HDMI controller. This
> > > > > > > has been tested on a rk3568 rock3a board. It should be possible to add
> > > > > > > 4k@60 support the same way, but it doesn't work for me, so let's add
> > > > > > > 4k@30 as a first step.
> > > > > > > Sascha
> > > > > > >
> > > > > > > Changes since v1:
> > > > > > > - Allow non standard clock rates only on Synopsys phy as suggested by
> > > > > > > Robin Murphy
> > > > > > >
> > > > > > > Sascha Hauer (2):
> > > > > > > drm/rockchip: dw_hdmi: relax mode_valid hook
> > > > > > > drm/rockchip: dw_hdmi: Add support for 4k@30 resolution
> > > > > > >
> > > > > > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++-----
> > > > > > > 1 file changed, 27 insertions(+), 7 deletions(-)
> > > > > > Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor
> > > > > >
> > > > > > Tested-by: Michael Riesch <michael.riesch@wolfvision.net>
> > > > > Sadly this still doesn't give my display out on my 2k monitor. Not even just
> > > > > 1080p picture like the old current implementation does.
> > > > By "like the old current implementation" you mean that this patchset
> > > > introduces a regression for you?
> > > Yes. What currently in the kernel at least shows as 1080p on my 2K monitor,
> > > while this patchset turns off the screen.
> > Which SoC are you testing this on? I assume RK3568, right? Which patch
> > introduces that regression, the first or the second one?
> I tested on the Odroid M, which is rk3568.
> I have only applied them both, as I was under the impression that both are
> needed for the 4k support.
Yes, both I needed, but I am interested which one introduces the
regression as I can't reproduce it.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Dan Johansen <strit@manjaro.org>
Cc: Sandy Huang <hjc@rock-chips.com>,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
Michael Riesch <michael.riesch@wolfvision.net>,
kernel@pengutronix.de, Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support
Date: Wed, 5 Oct 2022 13:10:04 +0200 [thread overview]
Message-ID: <20221005111004.GS986@pengutronix.de> (raw)
In-Reply-To: <7721ac8b-7e8d-5131-70aa-7579d912a2bb@manjaro.org>
On Wed, Oct 05, 2022 at 12:51:57PM +0200, Dan Johansen wrote:
>
> Den 05.10.2022 kl. 12.06 skrev Sascha Hauer:
> > On Wed, Sep 28, 2022 at 10:39:27AM +0200, Dan Johansen wrote:
> > > Den 28.09.2022 kl. 10.37 skrev Sascha Hauer:
> > > > On Tue, Sep 27, 2022 at 07:53:54PM +0200, Dan Johansen wrote:
> > > > > Den 26.09.2022 kl. 12.30 skrev Michael Riesch:
> > > > > > Hi Sascha,
> > > > > >
> > > > > > On 9/26/22 10:04, Sascha Hauer wrote:
> > > > > > > This series adds support for 4k@30 to the rockchip HDMI controller. This
> > > > > > > has been tested on a rk3568 rock3a board. It should be possible to add
> > > > > > > 4k@60 support the same way, but it doesn't work for me, so let's add
> > > > > > > 4k@30 as a first step.
> > > > > > > Sascha
> > > > > > >
> > > > > > > Changes since v1:
> > > > > > > - Allow non standard clock rates only on Synopsys phy as suggested by
> > > > > > > Robin Murphy
> > > > > > >
> > > > > > > Sascha Hauer (2):
> > > > > > > drm/rockchip: dw_hdmi: relax mode_valid hook
> > > > > > > drm/rockchip: dw_hdmi: Add support for 4k@30 resolution
> > > > > > >
> > > > > > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++-----
> > > > > > > 1 file changed, 27 insertions(+), 7 deletions(-)
> > > > > > Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor
> > > > > >
> > > > > > Tested-by: Michael Riesch <michael.riesch@wolfvision.net>
> > > > > Sadly this still doesn't give my display out on my 2k monitor. Not even just
> > > > > 1080p picture like the old current implementation does.
> > > > By "like the old current implementation" you mean that this patchset
> > > > introduces a regression for you?
> > > Yes. What currently in the kernel at least shows as 1080p on my 2K monitor,
> > > while this patchset turns off the screen.
> > Which SoC are you testing this on? I assume RK3568, right? Which patch
> > introduces that regression, the first or the second one?
> I tested on the Odroid M, which is rk3568.
> I have only applied them both, as I was under the impression that both are
> needed for the 4k support.
Yes, both I needed, but I am interested which one introduces the
regression as I can't reproduce it.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-10-05 11:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 8:04 [PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support Sascha Hauer
2022-09-26 8:04 ` Sascha Hauer
2022-09-26 8:04 ` [PATCH v2 1/2] drm/rockchip: dw_hdmi: relax mode_valid hook Sascha Hauer
2022-09-26 8:04 ` Sascha Hauer
2022-09-26 8:04 ` [PATCH v2 2/2] drm/rockchip: dw_hdmi: Add support for 4k@30 resolution Sascha Hauer
2022-09-26 8:04 ` Sascha Hauer
2022-09-26 10:30 ` [PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support Michael Riesch
2022-09-26 10:30 ` Michael Riesch
2022-09-27 17:53 ` Dan Johansen
2022-09-27 17:53 ` Dan Johansen
2022-09-28 8:37 ` Sascha Hauer
2022-09-28 8:37 ` Sascha Hauer
2022-09-28 8:39 ` Dan Johansen
2022-09-28 8:39 ` Dan Johansen
2022-10-05 10:06 ` Sascha Hauer
2022-10-05 10:06 ` Sascha Hauer
2022-10-05 10:51 ` Dan Johansen
2022-10-05 10:51 ` Dan Johansen
2022-10-05 11:10 ` Sascha Hauer [this message]
2022-10-05 11:10 ` Sascha Hauer
2022-10-05 12:28 ` Robin Murphy
2022-10-05 12:28 ` Robin Murphy
2022-10-18 15:05 ` Dan Johansen
2022-10-18 15:05 ` Dan Johansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221005111004.GS986@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kernel@pengutronix.de \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=robin.murphy@arm.com \
--cc=strit@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.