[OE-core][PATCH] psplash: add psplash-default in rdepends

[OE-core][PATCH] psplash: add psplash-default in rdepends

[thomas.perrot]

From: Thomas Perrot <thomas.perrot@bootlin.com>

Otherwise when the installation of recommended packages is prevented
(NO_RECOMMENDATIONS = "1"), then splash screen will not be cast.

Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
---
 meta/recipes-core/psplash/psplash_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/psplash/psplash_git.bb b/meta/recipes-core/psplash/psplash_git.bb
index edc0ac1d8961..9532ed1534a6 100644
--- a/meta/recipes-core/psplash/psplash_git.bb
+++ b/meta/recipes-core/psplash/psplash_git.bb
@@ -58,7 +58,7 @@ python __anonymous() {
         d.setVarFlag("ALTERNATIVE_TARGET_%s" % ep, 'psplash', '${bindir}/%s' % p)
         d.appendVar("RDEPENDS:%s" % ep, " %s" % pn)
         if p == "psplash-default":
-            d.appendVar("RRECOMMENDS:%s" % pn, " %s" % ep)
+            d.appendVar("RDEPENDS:%s" % pn, " %s" % ep)
 }
 
 S = "${WORKDIR}/git"
-- 
2.37.3

Re: [OE-core][PATCH] psplash: add psplash-default in rdepends

[Michael Opdenacker]

On 05.10.22 19:19, Thomas Perrot via lists.openembedded.org wrote:
> From: Thomas Perrot <thomas.perrot@bootlin.com>
>
> Otherwise when the installation of recommended packages is prevented
> (NO_RECOMMENDATIONS = "1"), then splash screen will not be cast.
>
> Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> ---
>   meta/recipes-core/psplash/psplash_git.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/psplash/psplash_git.bb b/meta/recipes-core/psplash/psplash_git.bb
> index edc0ac1d8961..9532ed1534a6 100644
> --- a/meta/recipes-core/psplash/psplash_git.bb
> +++ b/meta/recipes-core/psplash/psplash_git.bb
> @@ -58,7 +58,7 @@ python __anonymous() {
>           d.setVarFlag("ALTERNATIVE_TARGET_%s" % ep, 'psplash', '${bindir}/%s' % p)
>           d.appendVar("RDEPENDS:%s" % ep, " %s" % pn)
>           if p == "psplash-default":
> -            d.appendVar("RRECOMMENDS:%s" % pn, " %s" % ep)
> +            d.appendVar("RDEPENDS:%s" % pn, " %s" % ep)
>   }
>   
>   S = "${WORKDIR}/git"


Thanks Thomas. I confirm that the patch applies well now. You have a 
correct identity as a git commit author.
Thanks again
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[OE-core][PATCH] psplash: add psplash-default in rdepends

[Thomas Perrot]

Otherwise when the installation of recommended packages is prevented
(NO_RECOMMENDATIONS = "1"), then splash screen will not be cast.

Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
---
 meta/recipes-core/psplash/psplash_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/psplash/psplash_git.bb b/meta/recipes-core/psplash/psplash_git.bb
index edc0ac1d8961..9532ed1534a6 100644
--- a/meta/recipes-core/psplash/psplash_git.bb
+++ b/meta/recipes-core/psplash/psplash_git.bb
@@ -58,7 +58,7 @@ python __anonymous() {
         d.setVarFlag("ALTERNATIVE_TARGET_%s" % ep, 'psplash', '${bindir}/%s' % p)
         d.appendVar("RDEPENDS:%s" % ep, " %s" % pn)
         if p == "psplash-default":
-            d.appendVar("RRECOMMENDS:%s" % pn, " %s" % ep)
+            d.appendVar("RDEPENDS:%s" % pn, " %s" % ep)
 }
 
 S = "${WORKDIR}/git"
-- 
2.37.3

Re: [OE-core][PATCH] psplash: add psplash-default in rdepends

[Michael Opdenacker]

Hello Thomas

Thanks for the patch!

On 05.10.22 16:57, Thomas Perrot via lists.openembedded.org wrote:
> Otherwise when the installation of recommended packages is prevented
> (NO_RECOMMENDATIONS = "1"), then splash screen will not be cast.
>
> Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>


There's a problem with the way you send your patches though. I used to 
have the same one.

If I apply your patch through "git am", the author of the commit is:
Thomas Perrot via lists.openembedded.org 
<thomas.perrot=bootlin.com@lists.openembedded.org>
instead of
Thomas Perrot <thomas.perrot@bootlin.com>

Because of this issue, the maintainer has to manually fix this field 
when accepting your patch. Worse, if he doesn't catch this, that's 
harder to fix afterwards.

You should be able to fix this by running:

git config --global sendemail.from "thomas.perrot@bootlin.com"

At least this worked for me from the same domain ;-) See 
https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Sending_using_git-send-email

Could you try to send an update? You could send it to me again through 
private-mail first.

Thanks in advance
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com