Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Sep 28, 2022 at 11:36:51AM +0530, Ani Sinha wrote:
> On Wed, Sep 28, 2022 at 9:28 AM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Wed, Sep 28, 2022 at 08:38:54AM +0530, Ani Sinha wrote:
> > > > I don't really care where we upload them but only having the
> > > > latest version is just going to break anything expecting
> > > > the old binary.
> > >
> > > In fairness, I am not entirely certain if there is a tight coupling
> > > between the qemu tests and the bits binaries. I have written the test
> > > framework in a way such that test modifications and new tests can be
> > > pushed into the bits binaries and the iso gets regenerated with the
> > > new tests from QEMU itself before running the tests. Only when we need
> > > bits bugfixes or say upgrade to new acpica that we would need to
> > > regenerate the bits binaries.
> >
> > Theoretically, that's correct. But if we did not have bugs we would
> > not need tests.
> 
> Hmm, you might have a point. Curious, do we keep versioned binaries of
> edk for example?

We keep them in git, don't we? Under pc-bios.

> If so, why we can't do the same for bits?

What can I say - let's get this upstream in some form and
then worry about improving the infrastructure.




-- 
MST