All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Frieder Schrempf <frieder.schrempf@kontron.de>
Cc: mikhail.kshevetskiy@iopsys.eu, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH] spi-nand: add Winbond W25N02KV flash support, fix Winbond flashes identifications
Date: Thu, 6 Oct 2022 11:32:07 +0200	[thread overview]
Message-ID: <20221006113207.7b81d45b@xps-13> (raw)
In-Reply-To: <d55465ac-fe0b-130c-31ae-0ce62af3eb5f@kontron.de>

Hi Frieder,

frieder.schrempf@kontron.de wrote on Thu, 6 Oct 2022 11:26:45 +0200:

> Am 06.10.22 um 05:32 schrieb mikhail.kshevetskiy@iopsys.eu:
> > 
> > From: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
> > 
> > Winbond uses 3 bytes to identify flash: vendor_id, dev_id_0, dev_id_1,
> > but current driver uses only first 2 bytes of it for devices
> > idenfification. As result Winbond W25N02KV flash (id_bytes: EF, AA, 22)
> > is identified as W25N01GV (id_bytes: EF, AA, 21).
> > 
> > Fix this and add W25N02KV flash support.
> > 
> > Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>  
> 
> Thanks for the patch. We have a similar change in our downstream kernel,
> that I failed to push upstream so far. But your version looks even better.
> 
> Can you change the subject prefix to "mtd: spinand: winbond:", please?
> 
> And I also would like to ask you to split this into two patches. The
> first one to add the third byte in the ids of the existing devices and
> the second one to add support for the new device.

Agreed on both comments, thanks Frieder!

> With these two changes you can add:
> 
> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>

Cheers,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Frieder Schrempf <frieder.schrempf@kontron.de>
Cc: mikhail.kshevetskiy@iopsys.eu, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH] spi-nand: add Winbond W25N02KV flash support, fix Winbond flashes identifications
Date: Thu, 6 Oct 2022 11:32:07 +0200	[thread overview]
Message-ID: <20221006113207.7b81d45b@xps-13> (raw)
In-Reply-To: <d55465ac-fe0b-130c-31ae-0ce62af3eb5f@kontron.de>

Hi Frieder,

frieder.schrempf@kontron.de wrote on Thu, 6 Oct 2022 11:26:45 +0200:

> Am 06.10.22 um 05:32 schrieb mikhail.kshevetskiy@iopsys.eu:
> > 
> > From: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
> > 
> > Winbond uses 3 bytes to identify flash: vendor_id, dev_id_0, dev_id_1,
> > but current driver uses only first 2 bytes of it for devices
> > idenfification. As result Winbond W25N02KV flash (id_bytes: EF, AA, 22)
> > is identified as W25N01GV (id_bytes: EF, AA, 21).
> > 
> > Fix this and add W25N02KV flash support.
> > 
> > Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>  
> 
> Thanks for the patch. We have a similar change in our downstream kernel,
> that I failed to push upstream so far. But your version looks even better.
> 
> Can you change the subject prefix to "mtd: spinand: winbond:", please?
> 
> And I also would like to ask you to split this into two patches. The
> first one to add the third byte in the ids of the existing devices and
> the second one to add support for the new device.

Agreed on both comments, thanks Frieder!

> With these two changes you can add:
> 
> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>

Cheers,
Miquèl

  reply	other threads:[~2022-10-06  9:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06  3:32 [PATCH] spi-nand: add Winbond W25N02KV flash support, fix Winbond flashes identifications mikhail.kshevetskiy
2022-10-06  3:32 ` mikhail.kshevetskiy
2022-10-06  9:26 ` Frieder Schrempf
2022-10-06  9:26   ` Frieder Schrempf
2022-10-06  9:32   ` Miquel Raynal [this message]
2022-10-06  9:32     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221006113207.7b81d45b@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mikhail.kshevetskiy@iopsys.eu \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.