* [PATCH 1/1] arm64: allwinner: a64: enable Bluetooth on Pinebook
@ 2022-10-07 23:45 ` Bastian Germann
0 siblings, 0 replies; 8+ messages in thread
From: Bastian Germann @ 2022-10-07 23:45 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-kernel
Cc: Vasily Khoruzhick, Bastian Germann
From: Vasily Khoruzhick <anarsoul@gmail.com>
Pinebook has an RTL8723CS WiFi + BT chip. BT is connected to UART1
and uses PL5 as device wake GPIO and PL6 as host wake GPIO.
The I2C controlling signals are connected to R_I2C bus.
Enable it in the device tree.
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Signed-off-by: Bastian Germann <bage@debian.org>
---
.../boot/dts/allwinner/sun50i-a64-pinebook.dts | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
index 620cb3ef5f6c..19ba87c411ed 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
@@ -406,6 +406,19 @@ &uart0 {
status = "okay";
};
+&uart1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>;
+ uart-has-rtscts;
+ status = "okay";
+
+ bluetooth {
+ compatible = "realtek,rtl8723cs-bt";
+ device-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL5 */
+ host-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
+ };
+};
+
&usb_otg {
dr_mode = "host";
};
--
2.37.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/1] arm64: allwinner: a64: enable Bluetooth on Pinebook
2022-10-07 23:45 ` Bastian Germann
@ 2022-11-04 23:42 ` Bastian Germann
-1 siblings, 0 replies; 8+ messages in thread
From: Bastian Germann @ 2022-11-04 23:42 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-kernel
Cc: Vasily Khoruzhick
On 08.10.22 at 01:45 Bastian Germann wrote:
> Pinebook has an RTL8723CS WiFi + BT chip. BT is connected to UART1
> and uses PL5 as device wake GPIO and PL6 as host wake GPIO.
> The I2C controlling signals are connected to R_I2C bus.
>
> Enable it in the device tree.
Hey,
Any chance you have a look at this patch? It has been a month and it was the third time the patch hit the list.
If there is something wrong with it I would appreciate a comment.
Thanks,
Bastian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] arm64: allwinner: a64: enable Bluetooth on Pinebook
@ 2022-11-04 23:42 ` Bastian Germann
0 siblings, 0 replies; 8+ messages in thread
From: Bastian Germann @ 2022-11-04 23:42 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-kernel
Cc: Vasily Khoruzhick
On 08.10.22 at 01:45 Bastian Germann wrote:
> Pinebook has an RTL8723CS WiFi + BT chip. BT is connected to UART1
> and uses PL5 as device wake GPIO and PL6 as host wake GPIO.
> The I2C controlling signals are connected to R_I2C bus.
>
> Enable it in the device tree.
Hey,
Any chance you have a look at this patch? It has been a month and it was the third time the patch hit the list.
If there is something wrong with it I would appreciate a comment.
Thanks,
Bastian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] arm64: allwinner: a64: enable Bluetooth on Pinebook
2022-10-07 23:45 ` Bastian Germann
@ 2022-11-05 2:32 ` Samuel Holland
-1 siblings, 0 replies; 8+ messages in thread
From: Samuel Holland @ 2022-11-05 2:32 UTC (permalink / raw)
To: Bastian Germann
Cc: Vasily Khoruzhick, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi, Jernej Skrabec
Hi Bastian,
Please make sure you include the sunxi platform maintainers (as reported
by get_maintainers.pl) when sending your patch, so it gets in our inboxes.
Subject prefix should be "arm64: dts: allwinner: a64:" (with "dts:").
On 10/7/22 18:45, Bastian Germann wrote:
> From: Vasily Khoruzhick <anarsoul@gmail.com>
>
> Pinebook has an RTL8723CS WiFi + BT chip. BT is connected to UART1
> and uses PL5 as device wake GPIO and PL6 as host wake GPIO.
> The I2C controlling signals are connected to R_I2C bus.
Please remove this sentence; it doesn't make sense. The RTL8723CS does
not have any I2C connection.
> Enable it in the device tree.
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> Signed-off-by: Bastian Germann <bage@debian.org>
> ---
> .../boot/dts/allwinner/sun50i-a64-pinebook.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
> index 620cb3ef5f6c..19ba87c411ed 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
> @@ -406,6 +406,19 @@ &uart0 {
> status = "okay";
> };
>
> +&uart1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>;
> + uart-has-rtscts;
> + status = "okay";
> +
> + bluetooth {
> + compatible = "realtek,rtl8723cs-bt";
> + device-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL5 */
You also need:
enable-gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
(this is BT-RST-N in the schematic).
The rest looks good to me.
Regards,
Samuel
> + host-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
> + };
> +};
> +
> &usb_otg {
> dr_mode = "host";
> };
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/1] arm64: allwinner: a64: enable Bluetooth on Pinebook
@ 2022-11-05 2:32 ` Samuel Holland
0 siblings, 0 replies; 8+ messages in thread
From: Samuel Holland @ 2022-11-05 2:32 UTC (permalink / raw)
To: Bastian Germann
Cc: Vasily Khoruzhick, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi, Jernej Skrabec
Hi Bastian,
Please make sure you include the sunxi platform maintainers (as reported
by get_maintainers.pl) when sending your patch, so it gets in our inboxes.
Subject prefix should be "arm64: dts: allwinner: a64:" (with "dts:").
On 10/7/22 18:45, Bastian Germann wrote:
> From: Vasily Khoruzhick <anarsoul@gmail.com>
>
> Pinebook has an RTL8723CS WiFi + BT chip. BT is connected to UART1
> and uses PL5 as device wake GPIO and PL6 as host wake GPIO.
> The I2C controlling signals are connected to R_I2C bus.
Please remove this sentence; it doesn't make sense. The RTL8723CS does
not have any I2C connection.
> Enable it in the device tree.
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> Signed-off-by: Bastian Germann <bage@debian.org>
> ---
> .../boot/dts/allwinner/sun50i-a64-pinebook.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
> index 620cb3ef5f6c..19ba87c411ed 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
> @@ -406,6 +406,19 @@ &uart0 {
> status = "okay";
> };
>
> +&uart1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>;
> + uart-has-rtscts;
> + status = "okay";
> +
> + bluetooth {
> + compatible = "realtek,rtl8723cs-bt";
> + device-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL5 */
You also need:
enable-gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
(this is BT-RST-N in the schematic).
The rest looks good to me.
Regards,
Samuel
> + host-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
> + };
> +};
> +
> &usb_otg {
> dr_mode = "host";
> };
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread