All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht, asahi@lists.linux.dev,
	Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	martin.botka@somainline.org,
	angelogioacchino.delregno@somainline.org,
	marijn.suijten@somainline.org, jamipkettunen@somainline.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: apple,aic: Document A7-A11 compatibles
Date: Mon, 10 Oct 2022 07:27:27 -0500	[thread overview]
Message-ID: <20221010122727.GA432201-robh@kernel.org> (raw)
In-Reply-To: <20221007200022.22844-2-konrad.dybcio@somainline.org>

On Fri, Oct 07, 2022 at 10:00:21PM +0200, Konrad Dybcio wrote:
> Document the compatibles for Apple A7-A11 SoCs.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> Changes since v3:
> - Bindings: A7-A10+M1 only get SoC compat and generic fallback,
> A11 gets M1 fallback and generic fallback (removed A11 compatible)

I have no idea if that makes sense or not. Do I have to go read the 
rationale in the prior version?

The question to ask on fallbacks, is would s/w that only understands the 
fallback compatible work as-is?

> - Drop Rob's A-b as this is essentially yet another rewrite..
> 
>  .../bindings/interrupt-controller/apple,aic.yaml | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> index e18107eafe7c..1427ea9b04a2 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> @@ -36,9 +36,19 @@ allOf:
>  
>  properties:
>    compatible:
> -    items:
> -      - const: apple,t8103-aic
> -      - const: apple,aic
> +    oneOf:
> +      - items:
> +          - enum:
> +              - apple,s5l8960x-aic
> +              - apple,s8000-aic
> +              - apple,t7000-aic
> +              - apple,t8010-aic
> +              - apple,t8103-aic
> +          - const: apple,aic
> +      - items:
> +          - const: apple,t8015-aic
> +          - const: apple,t8103-aic
> +          - const: apple,aic
>  
>    interrupt-controller: true
>  
> -- 
> 2.37.3
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht, asahi@lists.linux.dev,
	Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	martin.botka@somainline.org,
	angelogioacchino.delregno@somainline.org,
	marijn.suijten@somainline.org, jamipkettunen@somainline.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: apple,aic: Document A7-A11 compatibles
Date: Mon, 10 Oct 2022 07:27:27 -0500	[thread overview]
Message-ID: <20221010122727.GA432201-robh@kernel.org> (raw)
In-Reply-To: <20221007200022.22844-2-konrad.dybcio@somainline.org>

On Fri, Oct 07, 2022 at 10:00:21PM +0200, Konrad Dybcio wrote:
> Document the compatibles for Apple A7-A11 SoCs.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> Changes since v3:
> - Bindings: A7-A10+M1 only get SoC compat and generic fallback,
> A11 gets M1 fallback and generic fallback (removed A11 compatible)

I have no idea if that makes sense or not. Do I have to go read the 
rationale in the prior version?

The question to ask on fallbacks, is would s/w that only understands the 
fallback compatible work as-is?

> - Drop Rob's A-b as this is essentially yet another rewrite..
> 
>  .../bindings/interrupt-controller/apple,aic.yaml | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> index e18107eafe7c..1427ea9b04a2 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> @@ -36,9 +36,19 @@ allOf:
>  
>  properties:
>    compatible:
> -    items:
> -      - const: apple,t8103-aic
> -      - const: apple,aic
> +    oneOf:
> +      - items:
> +          - enum:
> +              - apple,s5l8960x-aic
> +              - apple,s8000-aic
> +              - apple,t7000-aic
> +              - apple,t8010-aic
> +              - apple,t8103-aic
> +          - const: apple,aic
> +      - items:
> +          - const: apple,t8015-aic
> +          - const: apple,t8103-aic
> +          - const: apple,aic
>  
>    interrupt-controller: true
>  
> -- 
> 2.37.3
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-10-10 12:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07 20:00 [PATCH v4 0/2] A7-A11 AIC support Konrad Dybcio
2022-10-07 20:00 ` [PATCH v4 1/2] dt-bindings: apple,aic: Document A7-A11 compatibles Konrad Dybcio
2022-10-07 20:00   ` Konrad Dybcio
2022-10-10 12:27   ` Rob Herring [this message]
2022-10-10 12:27     ` Rob Herring
2022-10-10 14:10     ` konrad.dybcio
2022-10-10 14:10       ` konrad.dybcio
2022-10-07 20:00 ` [PATCH v4 2/2] irqchip/apple-aic: Add support for A7-A11 SoCs Konrad Dybcio
2022-10-07 20:00   ` Konrad Dybcio
2022-10-07 23:17   ` Marc Zyngier
2022-10-07 23:17     ` Marc Zyngier
2022-10-08  7:03     ` Konrad Dybcio
2022-10-08  7:03       ` Konrad Dybcio
2022-10-09  0:56       ` Marc Zyngier
2022-10-09  0:56         ` Marc Zyngier
2022-10-08  9:33   ` Sven Peter
2022-10-08  9:33     ` Sven Peter
2022-10-08 14:06     ` Konrad Dybcio
2022-10-08 14:06       ` Konrad Dybcio
2022-10-09  9:57       ` Sven Peter
2022-10-09  9:57         ` Sven Peter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221010122727.GA432201-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alyssa@rosenzweig.io \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=asahi@lists.linux.dev \
    --cc=devicetree@vger.kernel.org \
    --cc=jamipkettunen@somainline.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=marijn.suijten@somainline.org \
    --cc=martin.botka@somainline.org \
    --cc=maz@kernel.org \
    --cc=sven@svenpeter.dev \
    --cc=tglx@linutronix.de \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.