Re: [[meta-arago][tisdk-setup-scripts][master][PATCH]] create-sdcard : Correct if condition which checks for boot images

[Denys Dmytriyenko <denis@denix.org>]

On Mon, Oct 10, 2022 at 05:32:23PM -0500, praneeth via lists.yoctoproject.org wrote:
> On 10/10/2022 2:40 AM, Paresh Bhagat wrote:
> >Jira - https://jira.itg.ti.com/browse/SITSW-1649
> 
> This is upstream mailing list.
> 
> Please keep the TI internal jira-ids away from commit descriptions
> or cover-letters please.

The Subject line contains double/netsted brackets:

[[meta-arago][tisdk-setup-scripts][master][PATCH]] create-sdcard : Correct if condition which checks for boot images

Which doesn't play nice with the Patchwork and stray brackets end up in git 
history:

https://git.ti.com/cgit/arago-project/oe-layersetup/commit/?id=f80538808a4d82457766388e95929e075871dd6d

The list automatically adds [meta-arago], so when sending out, your patch 
Subject should look like:

[tisdk-setup-scripts][PATCH] create-sdcard: Correct if condition which checks for boot images

Thanks,
Denys


> >The if condition which checks for boot binaries for am65xx and
> >j7 devices has no spaces which shows error while running create-sdcard.sh.
> >Add the required spaces in if condition.
> >
> >Signed-off-by: Paresh Bhagat <p-bhagat@ti.com>
> >---
> >  create-sdcard.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/create-sdcard.sh b/create-sdcard.sh
> >index 4af6c94..5c3490a 100644
> >--- a/create-sdcard.sh
> >+++ b/create-sdcard.sh
> >@@ -1057,7 +1057,7 @@ if [ $BOOTPATHOPTION -eq 1 ] ; then
> >  	echo ""
> >  	#copy boot files out of board support
> >-        if ["$TARDEVICENAME" == "am65xx"] || ["$TARDEVICENAME" == "j7"]; then
> >+        if [ "$TARDEVICENAME" == "am65xx" ] || [ "$TARDEVICENAME" == "j7" ]; then
> >  		if [ "$MLO" == "" ] && ( [ "$SPL_R5" == "" ] || [ "$SPL_A53" == "" ] || [ "$SYSFW" == "" ] ); then
> >  			echo "Boot image not found"
> >  		fi