* [[meta-arago][tisdk-setup-scripts][master][PATCH]] create-sdcard : Correct if condition which checks for boot images
@ 2022-10-10 7:40 Paresh Bhagat
2022-10-10 22:32 ` Bajjuri, Praneeth
0 siblings, 1 reply; 3+ messages in thread
From: Paresh Bhagat @ 2022-10-10 7:40 UTC (permalink / raw)
To: meta-arago, praneeth, reatmon; +Cc: c-shilwant, s-adivi
Jira - https://jira.itg.ti.com/browse/SITSW-1649
The if condition which checks for boot binaries for am65xx and
j7 devices has no spaces which shows error while running create-sdcard.sh.
Add the required spaces in if condition.
Signed-off-by: Paresh Bhagat <p-bhagat@ti.com>
---
create-sdcard.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/create-sdcard.sh b/create-sdcard.sh
index 4af6c94..5c3490a 100644
--- a/create-sdcard.sh
+++ b/create-sdcard.sh
@@ -1057,7 +1057,7 @@ if [ $BOOTPATHOPTION -eq 1 ] ; then
echo ""
#copy boot files out of board support
- if ["$TARDEVICENAME" == "am65xx"] || ["$TARDEVICENAME" == "j7"]; then
+ if [ "$TARDEVICENAME" == "am65xx" ] || [ "$TARDEVICENAME" == "j7" ]; then
if [ "$MLO" == "" ] && ( [ "$SPL_R5" == "" ] || [ "$SPL_A53" == "" ] || [ "$SYSFW" == "" ] ); then
echo "Boot image not found"
fi
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [[meta-arago][tisdk-setup-scripts][master][PATCH]] create-sdcard : Correct if condition which checks for boot images
2022-10-10 7:40 [[meta-arago][tisdk-setup-scripts][master][PATCH]] create-sdcard : Correct if condition which checks for boot images Paresh Bhagat
@ 2022-10-10 22:32 ` Bajjuri, Praneeth
2022-10-11 0:44 ` Denys Dmytriyenko
0 siblings, 1 reply; 3+ messages in thread
From: Bajjuri, Praneeth @ 2022-10-10 22:32 UTC (permalink / raw)
To: Paresh Bhagat, meta-arago, reatmon; +Cc: c-shilwant, s-adivi
On 10/10/2022 2:40 AM, Paresh Bhagat wrote:
> Jira - https://jira.itg.ti.com/browse/SITSW-1649
This is upstream mailing list.
Please keep the TI internal jira-ids away from commit descriptions or
cover-letters please.
>
> The if condition which checks for boot binaries for am65xx and
> j7 devices has no spaces which shows error while running create-sdcard.sh.
> Add the required spaces in if condition.
>
> Signed-off-by: Paresh Bhagat <p-bhagat@ti.com>
> ---
> create-sdcard.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/create-sdcard.sh b/create-sdcard.sh
> index 4af6c94..5c3490a 100644
> --- a/create-sdcard.sh
> +++ b/create-sdcard.sh
> @@ -1057,7 +1057,7 @@ if [ $BOOTPATHOPTION -eq 1 ] ; then
>
> echo ""
> #copy boot files out of board support
> - if ["$TARDEVICENAME" == "am65xx"] || ["$TARDEVICENAME" == "j7"]; then
> + if [ "$TARDEVICENAME" == "am65xx" ] || [ "$TARDEVICENAME" == "j7" ]; then
> if [ "$MLO" == "" ] && ( [ "$SPL_R5" == "" ] || [ "$SPL_A53" == "" ] || [ "$SYSFW" == "" ] ); then
> echo "Boot image not found"
> fi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [[meta-arago][tisdk-setup-scripts][master][PATCH]] create-sdcard : Correct if condition which checks for boot images
2022-10-10 22:32 ` Bajjuri, Praneeth
@ 2022-10-11 0:44 ` Denys Dmytriyenko
0 siblings, 0 replies; 3+ messages in thread
From: Denys Dmytriyenko @ 2022-10-11 0:44 UTC (permalink / raw)
To: praneeth; +Cc: Paresh Bhagat, meta-arago, reatmon, c-shilwant, s-adivi
On Mon, Oct 10, 2022 at 05:32:23PM -0500, praneeth via lists.yoctoproject.org wrote:
> On 10/10/2022 2:40 AM, Paresh Bhagat wrote:
> >Jira - https://jira.itg.ti.com/browse/SITSW-1649
>
> This is upstream mailing list.
>
> Please keep the TI internal jira-ids away from commit descriptions
> or cover-letters please.
The Subject line contains double/netsted brackets:
[[meta-arago][tisdk-setup-scripts][master][PATCH]] create-sdcard : Correct if condition which checks for boot images
Which doesn't play nice with the Patchwork and stray brackets end up in git
history:
https://git.ti.com/cgit/arago-project/oe-layersetup/commit/?id=f80538808a4d82457766388e95929e075871dd6d
The list automatically adds [meta-arago], so when sending out, your patch
Subject should look like:
[tisdk-setup-scripts][PATCH] create-sdcard: Correct if condition which checks for boot images
Thanks,
Denys
> >The if condition which checks for boot binaries for am65xx and
> >j7 devices has no spaces which shows error while running create-sdcard.sh.
> >Add the required spaces in if condition.
> >
> >Signed-off-by: Paresh Bhagat <p-bhagat@ti.com>
> >---
> > create-sdcard.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/create-sdcard.sh b/create-sdcard.sh
> >index 4af6c94..5c3490a 100644
> >--- a/create-sdcard.sh
> >+++ b/create-sdcard.sh
> >@@ -1057,7 +1057,7 @@ if [ $BOOTPATHOPTION -eq 1 ] ; then
> > echo ""
> > #copy boot files out of board support
> >- if ["$TARDEVICENAME" == "am65xx"] || ["$TARDEVICENAME" == "j7"]; then
> >+ if [ "$TARDEVICENAME" == "am65xx" ] || [ "$TARDEVICENAME" == "j7" ]; then
> > if [ "$MLO" == "" ] && ( [ "$SPL_R5" == "" ] || [ "$SPL_A53" == "" ] || [ "$SYSFW" == "" ] ); then
> > echo "Boot image not found"
> > fi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-11 0:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-10 7:40 [[meta-arago][tisdk-setup-scripts][master][PATCH]] create-sdcard : Correct if condition which checks for boot images Paresh Bhagat
2022-10-10 22:32 ` Bajjuri, Praneeth
2022-10-11 0:44 ` Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.