[Buildroot] [PATCH 1/2] package/wolftpm: Update version to v2.6.0

[Buildroot] [PATCH 1/2] package/wolftpm: Update version to v2.6.0

[Dimi Tomov]

From: Dimitar Tomov <dimi@tpm.dev>

This patch series bumps the wolftpm version to the latest available and
adds one new config option for controlling debug messages in wolftpm.

Signed-off-by: Dimitar Tomov <dimi@tpm.dev>
---
 package/wolftpm/wolftpm.hash | 2 +-
 package/wolftpm/wolftpm.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/wolftpm/wolftpm.hash b/package/wolftpm/wolftpm.hash
index d24df58eaa..e256967a01 100644
--- a/package/wolftpm/wolftpm.hash
+++ b/package/wolftpm/wolftpm.hash
@@ -1,4 +1,4 @@
 # Hash from https://github.com/wolfSSL/wolfTPM/archive/refs/tags/v2.4.0.tar.gz
-sha256  31d1a5f5d60af14c4d07e14a9b0667404d4801fed32afd3fc0649749020ad17b  wolftpm-2.4.0.tar.gz
+sha256  78331cc2d98339247857f5ceb3e7cd3c4f5773e3d81bf1d73e8df9446e37472b  wolfTPM-2.6.0.tar.gz
 # Locally calculated
 sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  LICENSE
diff --git a/package/wolftpm/wolftpm.mk b/package/wolftpm/wolftpm.mk
index 7e8a108585..f217322545 100644
--- a/package/wolftpm/wolftpm.mk
+++ b/package/wolftpm/wolftpm.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-WOLFTPM_VERSION = 2.4.0
+WOLFTPM_VERSION = 2.6.0
 WOLFTPM_SITE = $(call github,wolfSSL,wolfTPM,v$(WOLFTPM_VERSION))
 WOLFTPM_INSTALL_STAGING = YES
 WOLFTPM_LICENSE = GPL-2.0+
-- 
2.27.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/wolftpm: Add new config option to enable debug output

[Dimi Tomov]

From: Dimitar Tomov <dimi@tpm.dev>

Signed-off-by: Dimitar Tomov <dimi@tpm.dev>
---
 package/wolftpm/Config.in  | 5 +++++
 package/wolftpm/wolftpm.mk | 6 ++++++
 2 files changed, 11 insertions(+)

diff --git a/package/wolftpm/Config.in b/package/wolftpm/Config.in
index 7ebb253857..4e712d0afb 100644
--- a/package/wolftpm/Config.in
+++ b/package/wolftpm/Config.in
@@ -35,6 +35,11 @@ config BR2_PACKAGE_WOLFTPM_NUVOTON
 	  Enable support of TPM 2.0 extra functionality offered by the
 	  Nuvoton NPCT750 chip.
 
+config BR2_PACKAGE_WOLFTPM_DEBUG
+	bool "Debug output"
+	help
+	  Enable debug messages in wolfTPM.
+
 comment "wolfCrypt hooks need a toolchain w/ threads, dynamic library"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
 
diff --git a/package/wolftpm/wolftpm.mk b/package/wolftpm/wolftpm.mk
index f217322545..398fa668af 100644
--- a/package/wolftpm/wolftpm.mk
+++ b/package/wolftpm/wolftpm.mk
@@ -47,4 +47,10 @@ else
 WOLFTPM_CONF_OPTS += --disable-nuvoton
 endif
 
+ifeq ($(BR2_PACKAGE_WOLFTPM_DEBUG),y)
+WOLFTPM_CONF_OPTS += --enable-debug
+else
+WOLFTPM_CONF_OPTS += --disable-debug
+endif
+
 $(eval $(autotools-package))
-- 
2.27.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/wolftpm: Add new config option to enable debug output

[Thomas Petazzoni via buildroot]

On Wed, 12 Oct 2022 10:54:23 +0300
Dimi Tomov <dimi@tpm.dev> wrote:

> From: Dimitar Tomov <dimi@tpm.dev>
> 
> Signed-off-by: Dimitar Tomov <dimi@tpm.dev>
> ---
>  package/wolftpm/Config.in  | 5 +++++
>  package/wolftpm/wolftpm.mk | 6 ++++++
>  2 files changed, 11 insertions(+)

I hesitated a bit between adding this new option, or using
BR2_ENABLE_RUNTIME_DEBUG. In the end, I went for your proposal, a
package-specific option. We'll see if other maintainers complain :-)

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/wolftpm: Update version to v2.6.0

[Dimi Tomov]

Hi Arnout,

Please review this version bump.

Thanks,
Dimi

On 2022-10-12 10:54 AM, Dimi Tomov wrote:
> From: Dimitar Tomov <dimi@tpm.dev>
> 
> This patch series bumps the wolftpm version to the latest available and
> adds one new config option for controlling debug messages in wolftpm.
> 
> Signed-off-by: Dimitar Tomov <dimi@tpm.dev>
> ---
>  package/wolftpm/wolftpm.hash | 2 +-
>  package/wolftpm/wolftpm.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/wolftpm/wolftpm.hash 
> b/package/wolftpm/wolftpm.hash
> index d24df58eaa..e256967a01 100644
> --- a/package/wolftpm/wolftpm.hash
> +++ b/package/wolftpm/wolftpm.hash
> @@ -1,4 +1,4 @@
>  # Hash from 
> https://github.com/wolfSSL/wolfTPM/archive/refs/tags/v2.4.0.tar.gz
> -sha256
> 31d1a5f5d60af14c4d07e14a9b0667404d4801fed32afd3fc0649749020ad17b
> wolftpm-2.4.0.tar.gz
> +sha256
> 78331cc2d98339247857f5ceb3e7cd3c4f5773e3d81bf1d73e8df9446e37472b
> wolfTPM-2.6.0.tar.gz
>  # Locally calculated
>  sha256
> 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643
> LICENSE
> diff --git a/package/wolftpm/wolftpm.mk b/package/wolftpm/wolftpm.mk
> index 7e8a108585..f217322545 100644
> --- a/package/wolftpm/wolftpm.mk
> +++ b/package/wolftpm/wolftpm.mk
> @@ -4,7 +4,7 @@
>  #
> 
> ################################################################################
> 
> -WOLFTPM_VERSION = 2.4.0
> +WOLFTPM_VERSION = 2.6.0
>  WOLFTPM_SITE = $(call github,wolfSSL,wolfTPM,v$(WOLFTPM_VERSION))
>  WOLFTPM_INSTALL_STAGING = YES
>  WOLFTPM_LICENSE = GPL-2.0+

-- 
Founder of TPM.dev
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/wolftpm: Update version to v2.6.0

[Thomas Petazzoni via buildroot]

On Wed, 12 Oct 2022 10:54:22 +0300
Dimi Tomov <dimi@tpm.dev> wrote:

> From: Dimitar Tomov <dimi@tpm.dev>
> 
> This patch series bumps the wolftpm version to the latest available and
> adds one new config option for controlling debug messages in wolftpm.

The commit log of a patch should not describe the patch series, but
just the patch itself.

The commit title should be:

	package/wolftpm: bump to version v2.6.0

>  package/wolftpm/wolftpm.hash | 2 +-
>  package/wolftpm/wolftpm.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/wolftpm/wolftpm.hash b/package/wolftpm/wolftpm.hash
> index d24df58eaa..e256967a01 100644
> --- a/package/wolftpm/wolftpm.hash
> +++ b/package/wolftpm/wolftpm.hash
> @@ -1,4 +1,4 @@
>  # Hash from https://github.com/wolfSSL/wolfTPM/archive/refs/tags/v2.4.0.tar.gz

This link is no longer correct. And in fact it is useless. Having a
link here is useful when it's a link to a hash file provided by
upstream, which is not the case here. In this case, we just put
"Locally calculated".

> -sha256  31d1a5f5d60af14c4d07e14a9b0667404d4801fed32afd3fc0649749020ad17b  wolftpm-2.4.0.tar.gz
> +sha256  78331cc2d98339247857f5ceb3e7cd3c4f5773e3d81bf1d73e8df9446e37472b  wolfTPM-2.6.0.tar.gz

You clearly did not test this properly, as the file is not named
wolfTPM-2.6.0.tar.gz but wolftpm-2.6.0.tar.gz. So a simple build fails
with:

ERROR: No hash found for wolftpm-2.6.0.tar.gz

I've fixed those issues and applied. But the next time, instead of
pinging just one day after submitting your patch... could you rather
spend your time in actually testing your patch?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot