From: Jakub Kicinski <kuba@kernel.org>
To: Shenwei Wang <shenwei.wang@nxp.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com\"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org\"
<linux-arm-kernel@lists.infradead.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
Russell King <rmk+kernel@armlinux.org.uk>
Subject: Re: [EXT] Re: [PATCH v5 1/2] net: phylink: add mac_managed_pm in phylink_config structure
Date: Thu, 13 Oct 2022 16:12:29 -0700 [thread overview]
Message-ID: <20221013161229.73471c88@kernel.org> (raw)
In-Reply-To: <PAXPR04MB9185C63C94CE032DCEE60AE689259@PAXPR04MB9185.eurprd04.prod.outlook.com>
On Thu, 13 Oct 2022 19:28:45 +0000 Shenwei Wang wrote:
> > Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect
> > mdio_bus_phy_resume() state"
> >
>
> That was my original format. But it met the following warning when ran checkpatch.pl script:
>
> ./scripts/checkpatch.pl 0001-net-phylink-add-mac_managed_pm-in-phylink_config-str.patch
> WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: e6a39ffcfe22 ("net: stmmac: Enable mac_managed_pm phylink config")'
> #20:
> Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect
>
> That's why I changed to the current tag format.
It needs to be all on one line:
Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect mdio_bus_phy_resume() state")
But I don't see 47ac7b2f6a1f in my trees, are you sure that's
the upstream commit id?
next prev parent reply other threads:[~2022-10-13 23:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 13:39 [PATCH v5 0/2] net: phylink: add phylink_set_mac_pm() helper Shenwei Wang
2022-10-13 13:39 ` Shenwei Wang
2022-10-13 13:39 ` [PATCH v5 1/2] net: phylink: add mac_managed_pm in phylink_config structure Shenwei Wang
2022-10-13 13:39 ` Shenwei Wang
2022-10-13 18:47 ` Florian Fainelli
2022-10-13 18:47 ` Florian Fainelli
2022-10-13 19:28 ` [EXT] " Shenwei Wang
2022-10-13 19:28 ` Shenwei Wang
2022-10-13 23:12 ` Jakub Kicinski [this message]
2022-10-14 14:35 ` Shenwei Wang
2022-10-14 14:35 ` Shenwei Wang
2022-10-13 13:39 ` [PATCH v5 2/2] net: stmmac: Enable mac_managed_pm phylink config Shenwei Wang
2022-10-13 13:39 ` Shenwei Wang
2022-10-13 18:48 ` Florian Fainelli
2022-10-13 18:48 ` Florian Fainelli
2022-10-13 16:07 ` [PATCH v5 0/2] net: phylink: add phylink_set_mac_pm() helper Russell King (Oracle)
2022-10-13 16:07 ` Russell King (Oracle)
2022-10-13 19:24 ` [EXT] " Shenwei Wang
2022-10-13 19:24 ` Shenwei Wang
2022-10-14 10:17 ` Russell King (Oracle)
2022-10-14 10:17 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221013161229.73471c88@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=shenwei.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.