All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <ajones@ventanamicro.com>
To: x86@kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Yury Norov <yury.norov@gmail.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Jonas Bonn <jonas@southpole.se>,
	Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
	Stafford Horne <shorne@gmail.com>,
	openrisc@lists.librecores.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	linuxppc-dev@lists.ozlabs.org, Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	linux-s390@vger.kernel.org
Subject: [PATCH v3 2/2] x86: Fix /proc/cpuinfo cpumask warning
Date: Fri, 14 Oct 2022 17:58:45 +0200	[thread overview]
Message-ID: <20221014155845.1986223-3-ajones@ventanamicro.com> (raw)
In-Reply-To: <20221014155845.1986223-1-ajones@ventanamicro.com>

Commit 78e5a3399421 ("cpumask: fix checking valid cpu range") has
started issuing warnings[*] when cpu indices equal to nr_cpu_ids - 1
are passed to cpumask_next* functions. seq_read_iter() and cpuinfo's
start and next seq operations implement a pattern like

  n = cpumask_next(n - 1, mask);
  show(n);
  while (1) {
      ++n;
      n = cpumask_next(n - 1, mask);
      if (n >= nr_cpu_ids)
          break;
      show(n);
  }

which will issue the warning when reading /proc/cpuinfo. Ensure no
warning is generated by validating the cpu index before calling
cpumask_next().

[*] Warnings will only appear with DEBUG_PER_CPU_MAPS enabled.

Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
Cc: Yury Norov <yury.norov@gmail.com>
---
 arch/x86/kernel/cpu/proc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/x86/kernel/cpu/proc.c b/arch/x86/kernel/cpu/proc.c
index 099b6f0d96bd..de3f93ac6e49 100644
--- a/arch/x86/kernel/cpu/proc.c
+++ b/arch/x86/kernel/cpu/proc.c
@@ -153,6 +153,9 @@ static int show_cpuinfo(struct seq_file *m, void *v)
 
 static void *c_start(struct seq_file *m, loff_t *pos)
 {
+	if (*pos == nr_cpu_ids)
+		return NULL;
+
 	*pos = cpumask_next(*pos - 1, cpu_online_mask);
 	if ((*pos) < nr_cpu_ids)
 		return &cpu_data(*pos);
-- 
2.37.3


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <ajones@ventanamicro.com>
To: x86@kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Yury Norov <yury.norov@gmail.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Jonas Bonn <jonas@southpole.se>,
	Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
	Stafford Horne <shorne@gmail.com>,
	openrisc@lists.librecores.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	linuxppc-dev@lists.ozlabs.org, Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	linux-s390@vger.kernel.org
Subject: [PATCH v3 2/2] x86: Fix /proc/cpuinfo cpumask warning
Date: Fri, 14 Oct 2022 17:58:45 +0200	[thread overview]
Message-ID: <20221014155845.1986223-3-ajones@ventanamicro.com> (raw)
In-Reply-To: <20221014155845.1986223-1-ajones@ventanamicro.com>

Commit 78e5a3399421 ("cpumask: fix checking valid cpu range") has
started issuing warnings[*] when cpu indices equal to nr_cpu_ids - 1
are passed to cpumask_next* functions. seq_read_iter() and cpuinfo's
start and next seq operations implement a pattern like

  n = cpumask_next(n - 1, mask);
  show(n);
  while (1) {
      ++n;
      n = cpumask_next(n - 1, mask);
      if (n >= nr_cpu_ids)
          break;
      show(n);
  }

which will issue the warning when reading /proc/cpuinfo. Ensure no
warning is generated by validating the cpu index before calling
cpumask_next().

[*] Warnings will only appear with DEBUG_PER_CPU_MAPS enabled.

Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
Cc: Yury Norov <yury.norov@gmail.com>
---
 arch/x86/kernel/cpu/proc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/x86/kernel/cpu/proc.c b/arch/x86/kernel/cpu/proc.c
index 099b6f0d96bd..de3f93ac6e49 100644
--- a/arch/x86/kernel/cpu/proc.c
+++ b/arch/x86/kernel/cpu/proc.c
@@ -153,6 +153,9 @@ static int show_cpuinfo(struct seq_file *m, void *v)
 
 static void *c_start(struct seq_file *m, loff_t *pos)
 {
+	if (*pos == nr_cpu_ids)
+		return NULL;
+
 	*pos = cpumask_next(*pos - 1, cpu_online_mask);
 	if ((*pos) < nr_cpu_ids)
 		return &cpu_data(*pos);
-- 
2.37.3


WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <ajones@ventanamicro.com>
To: x86@kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Jonas Bonn <jonas@southpole.se>,
	linux-s390@vger.kernel.org,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Yury Norov <yury.norov@gmail.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Heiko Carstens <hca@linux.ibm.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linuxppc-dev@lists.ozlabs.org, openrisc@lists.librecores.org
Subject: [PATCH v3 2/2] x86: Fix /proc/cpuinfo cpumask warning
Date: Fri, 14 Oct 2022 17:58:45 +0200	[thread overview]
Message-ID: <20221014155845.1986223-3-ajones@ventanamicro.com> (raw)
In-Reply-To: <20221014155845.1986223-1-ajones@ventanamicro.com>

Commit 78e5a3399421 ("cpumask: fix checking valid cpu range") has
started issuing warnings[*] when cpu indices equal to nr_cpu_ids - 1
are passed to cpumask_next* functions. seq_read_iter() and cpuinfo's
start and next seq operations implement a pattern like

  n = cpumask_next(n - 1, mask);
  show(n);
  while (1) {
      ++n;
      n = cpumask_next(n - 1, mask);
      if (n >= nr_cpu_ids)
          break;
      show(n);
  }

which will issue the warning when reading /proc/cpuinfo. Ensure no
warning is generated by validating the cpu index before calling
cpumask_next().

[*] Warnings will only appear with DEBUG_PER_CPU_MAPS enabled.

Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
Cc: Yury Norov <yury.norov@gmail.com>
---
 arch/x86/kernel/cpu/proc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/x86/kernel/cpu/proc.c b/arch/x86/kernel/cpu/proc.c
index 099b6f0d96bd..de3f93ac6e49 100644
--- a/arch/x86/kernel/cpu/proc.c
+++ b/arch/x86/kernel/cpu/proc.c
@@ -153,6 +153,9 @@ static int show_cpuinfo(struct seq_file *m, void *v)
 
 static void *c_start(struct seq_file *m, loff_t *pos)
 {
+	if (*pos == nr_cpu_ids)
+		return NULL;
+
 	*pos = cpumask_next(*pos - 1, cpu_online_mask);
 	if ((*pos) < nr_cpu_ids)
 		return &cpu_data(*pos);
-- 
2.37.3


WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <ajones@ventanamicro.com>
To: x86@kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Jonas Bonn <jonas@southpole.se>,
	linux-s390@vger.kernel.org,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Yury Norov <yury.norov@gmail.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linuxppc-dev@lists.ozlabs.org, Stafford Horne <shorne@gmail.com>,
	openrisc@lists.librecores.org
Subject: [PATCH v3 2/2] x86: Fix /proc/cpuinfo cpumask warning
Date: Fri, 14 Oct 2022 17:58:45 +0200	[thread overview]
Message-ID: <20221014155845.1986223-3-ajones@ventanamicro.com> (raw)
In-Reply-To: <20221014155845.1986223-1-ajones@ventanamicro.com>

Commit 78e5a3399421 ("cpumask: fix checking valid cpu range") has
started issuing warnings[*] when cpu indices equal to nr_cpu_ids - 1
are passed to cpumask_next* functions. seq_read_iter() and cpuinfo's
start and next seq operations implement a pattern like

  n = cpumask_next(n - 1, mask);
  show(n);
  while (1) {
      ++n;
      n = cpumask_next(n - 1, mask);
      if (n >= nr_cpu_ids)
          break;
      show(n);
  }

which will issue the warning when reading /proc/cpuinfo. Ensure no
warning is generated by validating the cpu index before calling
cpumask_next().

[*] Warnings will only appear with DEBUG_PER_CPU_MAPS enabled.

Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
Cc: Yury Norov <yury.norov@gmail.com>
---
 arch/x86/kernel/cpu/proc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/x86/kernel/cpu/proc.c b/arch/x86/kernel/cpu/proc.c
index 099b6f0d96bd..de3f93ac6e49 100644
--- a/arch/x86/kernel/cpu/proc.c
+++ b/arch/x86/kernel/cpu/proc.c
@@ -153,6 +153,9 @@ static int show_cpuinfo(struct seq_file *m, void *v)
 
 static void *c_start(struct seq_file *m, loff_t *pos)
 {
+	if (*pos == nr_cpu_ids)
+		return NULL;
+
 	*pos = cpumask_next(*pos - 1, cpu_online_mask);
 	if ((*pos) < nr_cpu_ids)
 		return &cpu_data(*pos);
-- 
2.37.3


  parent reply	other threads:[~2022-10-14 15:59 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14 15:58 [PATCH v3 0/2] Fix /proc/cpuinfo cpumask warning Andrew Jones
2022-10-14 15:58 ` Andrew Jones
2022-10-14 15:58 ` Andrew Jones
2022-10-14 15:58 ` Andrew Jones
2022-10-14 15:58 ` [PATCH v3 1/2] RISC-V: " Andrew Jones
2022-10-14 15:58   ` Andrew Jones
2022-10-14 15:58   ` Andrew Jones
2022-10-14 15:58   ` Andrew Jones
2022-10-14 15:58 ` Andrew Jones [this message]
2022-10-14 15:58   ` [PATCH v3 2/2] x86: " Andrew Jones
2022-10-14 15:58   ` Andrew Jones
2022-10-14 15:58   ` Andrew Jones
2022-10-28  7:48   ` Andrew Jones
2022-10-28  7:48     ` Andrew Jones
2022-10-28  7:48     ` Andrew Jones
2022-10-28  7:48     ` Andrew Jones
2022-10-28 14:46     ` Yury Norov
2022-10-28 14:46       ` Yury Norov
2022-10-28 14:46       ` Yury Norov
2022-10-28 14:46       ` Yury Norov
2022-10-28 15:03       ` Borislav Petkov
2022-10-28 15:03         ` Borislav Petkov
2022-10-28 15:03         ` Borislav Petkov
2022-10-28 15:03         ` Borislav Petkov
2022-10-28 15:13         ` Yury Norov
2022-10-28 15:13           ` Yury Norov
2022-10-28 16:06           ` Borislav Petkov
2022-10-28 16:06             ` Borislav Petkov
2022-10-28 16:06             ` Borislav Petkov
2022-10-28 16:06             ` Borislav Petkov
2022-10-31  8:06             ` Andrew Jones
2022-10-31  8:06               ` Andrew Jones
2022-10-31  8:06               ` Andrew Jones
2022-10-31  8:06               ` Andrew Jones
2022-10-31  8:58               ` Borislav Petkov
2022-10-31  8:58                 ` Borislav Petkov
2022-10-31  8:58                 ` Borislav Petkov
2022-10-31  8:58                 ` Borislav Petkov
2022-10-31 10:03                 ` Andrew Jones
2022-10-31 10:03                   ` Andrew Jones
2022-10-31 10:03                   ` Andrew Jones
2022-10-31 10:03                   ` Andrew Jones
2022-11-02 18:44                   ` Borislav Petkov
2022-11-02 18:44                     ` Borislav Petkov
2022-11-02 18:44                     ` Borislav Petkov
2022-11-02 18:44                     ` Borislav Petkov
2022-11-03 12:59                     ` Andrew Jones
2022-11-03 12:59                       ` Andrew Jones
2022-11-03 12:59                       ` Andrew Jones
2022-11-03 12:59                       ` Andrew Jones
2022-11-03 15:02                       ` Borislav Petkov
2022-11-03 15:02                         ` Borislav Petkov
2022-11-03 15:02                         ` Borislav Petkov
2022-11-03 15:02                         ` Borislav Petkov
2022-11-03 15:34                         ` Andrew Jones
2022-11-03 15:34                           ` Andrew Jones
2022-11-03 15:34                           ` Andrew Jones
2022-11-03 15:34                           ` Andrew Jones
2022-11-03 15:54                           ` Borislav Petkov
2022-11-03 15:54                             ` Borislav Petkov
2022-11-03 15:54                             ` Borislav Petkov
2022-11-03 15:54                             ` Borislav Petkov
2022-11-03 16:30                           ` yury.norov
2022-11-03 16:30                             ` yury.norov
2022-11-03 16:30                             ` yury.norov
2022-11-03 16:30                             ` yury.norov
2022-11-03 16:49                             ` Borislav Petkov
2022-11-03 16:49                               ` Borislav Petkov
2022-11-03 16:49                               ` Borislav Petkov
2022-11-03 16:49                               ` Borislav Petkov
2022-11-03 17:31                               ` Yury Norov
2022-11-03 17:31                                 ` Yury Norov
2022-11-03 17:31                                 ` Yury Norov
2022-11-03 17:31                                 ` Yury Norov
2022-11-03 23:22                                 ` Borislav Petkov
2022-11-03 23:22                                   ` Borislav Petkov
2022-11-03 23:22                                   ` Borislav Petkov
2022-11-03 23:22                                   ` Borislav Petkov
2022-10-15 18:08 ` [PATCH v3 0/2] " Yury Norov
2022-10-15 18:08   ` Yury Norov
2022-10-15 18:08   ` Yury Norov
2022-10-15 18:08   ` Yury Norov
2022-10-27 23:07 ` Palmer Dabbelt
2022-10-27 23:07   ` Palmer Dabbelt
2022-10-27 23:07   ` Palmer Dabbelt
2022-10-27 23:07   ` Palmer Dabbelt
2022-10-28  7:40   ` Andrew Jones
2022-10-28  7:40     ` Andrew Jones
2022-10-28  7:40     ` Andrew Jones
2022-10-28  7:40     ` Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221014155845.1986223-3-ajones@ventanamicro.com \
    --to=ajones@ventanamicro.com \
    --cc=agordeev@linux.ibm.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=jonas@southpole.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=openrisc@lists.librecores.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=shorne@gmail.com \
    --cc=stefan.kristiansson@saunalahti.fi \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.