From: Christoph Hellwig <hch@lst.de>
To: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Philipp Reisner <philipp.reisner@linbit.com>,
drbd-dev@lists.linbit.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Joel Colledge <joel.colledge@linbit.com>
Subject: Re: [PATCH] drbd: only clone bio if we have a backing device
Date: Mon, 17 Oct 2022 08:09:51 +0200 [thread overview]
Message-ID: <20221017060951.GA28409@lst.de> (raw)
In-Reply-To: <20221013135352.933875-1-christoph.boehmwalder@linbit.com>
On Thu, Oct 13, 2022 at 03:53:52PM +0200, Christoph Böhmwalder wrote:
> + if (get_ldev(device)) {
> + req->private_bio = bio_alloc_clone(device->ldev->backing_bdev,
> + bio, GFP_NOIO, &drbd_io_bio_set);
This adds an overly long line.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Philipp Reisner <philipp.reisner@linbit.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH] drbd: only clone bio if we have a backing device
Date: Mon, 17 Oct 2022 08:09:51 +0200 [thread overview]
Message-ID: <20221017060951.GA28409@lst.de> (raw)
In-Reply-To: <20221013135352.933875-1-christoph.boehmwalder@linbit.com>
On Thu, Oct 13, 2022 at 03:53:52PM +0200, Christoph Böhmwalder wrote:
> + if (get_ldev(device)) {
> + req->private_bio = bio_alloc_clone(device->ldev->backing_bdev,
> + bio, GFP_NOIO, &drbd_io_bio_set);
This adds an overly long line.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-10-17 6:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 13:53 [PATCH] drbd: only clone bio if we have a backing device Christoph Böhmwalder
2022-10-13 13:53 ` [Drbd-dev] " Christoph Böhmwalder
2022-10-17 6:09 ` Christoph Hellwig [this message]
2022-10-17 6:09 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2022-10-13 13:53 Christoph Böhmwalder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221017060951.GA28409@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=christoph.boehmwalder@linbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=joel.colledge@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.