From: Olaf Hering <olaf@aepfle.de>
To: Denton Liu <liu.denton@gmail.com>
Cc: grub-devel@gnu.org, Daniel Kiper <daniel.kiper@oracle.com>,
Oskari Pirhonen <xxc3ncoredxx@gmail.com>,
mathieu.desnoyers@efficios.com, rharwood@redhat.com,
samuel.thibault@ens-lyon.org, debian-bsd@lists.debian.org,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars
Date: Tue, 18 Oct 2022 13:12:35 +0200 [thread overview]
Message-ID: <20221018131235.5e70f0bc.olaf@aepfle.de> (raw)
In-Reply-To: <20221017103532.845293-1-liu.denton@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
Mon, 17 Oct 2022 03:35:32 -0700 Denton Liu <liu.denton@gmail.com>:
> A user may wish to use an image that is not sorted as the "latest"
> version as the top-level entry.
Correct.
What is really required is some form of file pattern matching and to use --id= in "menuentry title" commands.
That way one can have the "latest" of /boot/${short_pattern} as default entry, in case there are multiple variants of files matching ${short_pattern}. The pattern gets enabled with "grub-set-default pattern".
Based on this, I have to NACK your patch.
Olaf
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-18 11:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 10:35 [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars Denton Liu
2022-10-18 6:35 ` Oskari Pirhonen
2022-10-18 11:12 ` Olaf Hering [this message]
2022-10-18 13:57 ` Denton Liu
2022-10-18 14:18 ` Olaf Hering
2022-10-19 4:53 ` Denton Liu
2022-10-20 15:13 ` Olaf Hering
2022-10-22 3:53 ` Denton Liu
2022-10-22 6:28 ` Olaf Hering
2022-10-19 6:23 ` Michael Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018131235.5e70f0bc.olaf@aepfle.de \
--to=olaf@aepfle.de \
--cc=daniel.kiper@oracle.com \
--cc=debian-bsd@lists.debian.org \
--cc=grub-devel@gnu.org \
--cc=liu.denton@gmail.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=rharwood@redhat.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xxc3ncoredxx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.