All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denton Liu <liu.denton@gmail.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: grub-devel@gnu.org, Daniel Kiper <daniel.kiper@oracle.com>,
	Oskari Pirhonen <xxc3ncoredxx@gmail.com>,
	mathieu.desnoyers@efficios.com, rharwood@redhat.com,
	samuel.thibault@ens-lyon.org, debian-bsd@lists.debian.org,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars
Date: Fri, 21 Oct 2022 20:53:36 -0700	[thread overview]
Message-ID: <Y1NpQKadAS1EgY1c@generichostname> (raw)
In-Reply-To: <20221020171306.45c275f9.olaf@aepfle.de>

Hi Olaf,

On Thu, Oct 20, 2022 at 05:13:06PM +0200, Olaf Hering wrote:
> After reading the patch again, the newly added documentation states:
> "This option should be a path to a kernel image."
> 
> I think it needs to be more specific: is it expecting an absolute path, or just the basename of the desired image?

Thanks for the feedback, it should be an absolute path. I can submit a
new version of the patch later. However, before I do so, are you still
a NAK on the general idea?

-Denton


  reply	other threads:[~2022-10-22  3:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17 10:35 [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars Denton Liu
2022-10-18  6:35 ` Oskari Pirhonen
2022-10-18 11:12 ` Olaf Hering
2022-10-18 13:57   ` Denton Liu
2022-10-18 14:18     ` Olaf Hering
2022-10-19  4:53       ` Denton Liu
2022-10-20 15:13         ` Olaf Hering
2022-10-22  3:53           ` Denton Liu [this message]
2022-10-22  6:28             ` Olaf Hering
2022-10-19  6:23       ` Michael Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1NpQKadAS1EgY1c@generichostname \
    --to=liu.denton@gmail.com \
    --cc=daniel.kiper@oracle.com \
    --cc=debian-bsd@lists.debian.org \
    --cc=grub-devel@gnu.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=olaf@aepfle.de \
    --cc=rharwood@redhat.com \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=xxc3ncoredxx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.