All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Matt Ranostay <mranostay@ti.com>
Cc: robh@kernel.org, tjoseph@cadence.com, nm@ti.com, a-verma1@ti.com,
	vigneshr@ti.com, linux-arm-kernel@lists.infradead.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 3/3] PCI: j721e: Add warnings on num-lanes misconfiguration
Date: Thu, 20 Oct 2022 11:58:32 -0500	[thread overview]
Message-ID: <20221020165832.GA131977@bhelgaas> (raw)
In-Reply-To: <20221020012911.305139-4-mranostay@ti.com>

On Wed, Oct 19, 2022 at 06:29:11PM -0700, Matt Ranostay wrote:
> Added dev_warn messages to alert of devicetree misconfigurations
> for incorrect num-lanes setting, or the lack of one being defined.

s/Added/Add/ if you repost for anything else:

  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v5.16#n95

> +		dev_warn(dev, "defined num-lanes %u is greater than the "
> +			      "allowed maximum of %u, defaulting to 1\n",
> +			      num_lanes, data->max_lanes);

Don't repost just for this, but I generally prefer to keep printf
strings intact even if they exceed 80 columns, because it makes it
easier for someone to grep for something like
"greater than the allowed".

> +		num_lanes = 1;
> +	}
>  	pcie->num_lanes = num_lanes;
>  
>  	if (dma_set_mask_and_coherent(dev, DMA_BIT_MASK(48)))
> -- 
> 2.38.GIT
> 

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Matt Ranostay <mranostay@ti.com>
Cc: robh@kernel.org, tjoseph@cadence.com, nm@ti.com, a-verma1@ti.com,
	vigneshr@ti.com, linux-arm-kernel@lists.infradead.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 3/3] PCI: j721e: Add warnings on num-lanes misconfiguration
Date: Thu, 20 Oct 2022 11:58:32 -0500	[thread overview]
Message-ID: <20221020165832.GA131977@bhelgaas> (raw)
In-Reply-To: <20221020012911.305139-4-mranostay@ti.com>

On Wed, Oct 19, 2022 at 06:29:11PM -0700, Matt Ranostay wrote:
> Added dev_warn messages to alert of devicetree misconfigurations
> for incorrect num-lanes setting, or the lack of one being defined.

s/Added/Add/ if you repost for anything else:

  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v5.16#n95

> +		dev_warn(dev, "defined num-lanes %u is greater than the "
> +			      "allowed maximum of %u, defaulting to 1\n",
> +			      num_lanes, data->max_lanes);

Don't repost just for this, but I generally prefer to keep printf
strings intact even if they exceed 80 columns, because it makes it
easier for someone to grep for something like
"greater than the allowed".

> +		num_lanes = 1;
> +	}
>  	pcie->num_lanes = num_lanes;
>  
>  	if (dma_set_mask_and_coherent(dev, DMA_BIT_MASK(48)))
> -- 
> 2.38.GIT
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-10-20 16:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20  1:29 [PATCH v3 0/3] PCI: add 4x lane support for pci-j721e controllers Matt Ranostay
2022-10-20  1:29 ` Matt Ranostay
2022-10-20  1:29 ` [PATCH v3 1/3] PCI: j721e: Add PCIe 4x lane selection support Matt Ranostay
2022-10-20  1:29   ` Matt Ranostay
2022-10-25 11:53   ` Vignesh Raghavendra
2022-10-25 11:53     ` Vignesh Raghavendra
2022-10-25 12:51     ` Matt Ranostay
2022-10-25 12:51       ` Matt Ranostay
2022-10-20  1:29 ` [PATCH v3 2/3] PCI: j721e: Add per platform maximum lane settings Matt Ranostay
2022-10-20  1:29   ` Matt Ranostay
2022-10-20  1:29 ` [PATCH v3 3/3] PCI: j721e: Add warnings on num-lanes misconfiguration Matt Ranostay
2022-10-20  1:29   ` Matt Ranostay
2022-10-20 16:58   ` Bjorn Helgaas [this message]
2022-10-20 16:58     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221020165832.GA131977@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=a-verma1@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mranostay@ti.com \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=tjoseph@cadence.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.