From: Jakub Kicinski <kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: Eric Dumazet <edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
pabeni-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org,
weiwan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
ncardwell-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
ycheng-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH net] net-memcg: avoid stalls when under memory pressure
Date: Fri, 21 Oct 2022 10:40:16 -0700 [thread overview]
Message-ID: <20221021104016.407cbda9@kernel.org> (raw)
In-Reply-To: <CALvZod5di3saFdDJ1cwFDgvLPmnEJ7XB9P8YBTJ3uzfBKAFi3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Fri, 21 Oct 2022 09:34:20 -0700 Shakeel Butt wrote:
> > > How about just using gfp_any() and we can remove gfp_memcg_charge()?
> >
> > How about keeping gfp_memcg_charge() and adding a comment on its intent ?
> >
> > gfp_any() is very generic :/
That was my thinking, and I'm not sure what I could put in a comment.
Wouldn't it be some mix of words 'flags', 'memory', 'cgroup' and
'charge'... which is just spelling out the name of the function?
I mean:
/* Alloc flags for passing to cgroup socket memory charging */
does not add much value, right?
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Shakeel Butt <shakeelb@google.com>
Cc: Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com,
cgroups@vger.kernel.org, roman.gushchin@linux.dev,
weiwan@google.com, ncardwell@google.com, ycheng@google.com
Subject: Re: [PATCH net] net-memcg: avoid stalls when under memory pressure
Date: Fri, 21 Oct 2022 10:40:16 -0700 [thread overview]
Message-ID: <20221021104016.407cbda9@kernel.org> (raw)
In-Reply-To: <CALvZod5di3saFdDJ1cwFDgvLPmnEJ7XB9P8YBTJ3uzfBKAFi3Q@mail.gmail.com>
On Fri, 21 Oct 2022 09:34:20 -0700 Shakeel Butt wrote:
> > > How about just using gfp_any() and we can remove gfp_memcg_charge()?
> >
> > How about keeping gfp_memcg_charge() and adding a comment on its intent ?
> >
> > gfp_any() is very generic :/
That was my thinking, and I'm not sure what I could put in a comment.
Wouldn't it be some mix of words 'flags', 'memory', 'cgroup' and
'charge'... which is just spelling out the name of the function?
I mean:
/* Alloc flags for passing to cgroup socket memory charging */
does not add much value, right?
next prev parent reply other threads:[~2022-10-21 17:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 16:03 [PATCH net] net-memcg: avoid stalls when under memory pressure Jakub Kicinski
2022-10-21 16:03 ` Jakub Kicinski
2022-10-21 16:25 ` Shakeel Butt
[not found] ` <CALvZod4eezAXpehT4jMiQry4JQ5igJs7Nwi1Q+YhVpDcQ8BMRA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-10-21 16:28 ` Eric Dumazet
2022-10-21 16:28 ` Eric Dumazet
[not found] ` <CANn89iKTi5TYyFOOpgw3P0eTi1Gqn4k-eX+xRTX78Q4sAunm2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-10-21 16:34 ` Shakeel Butt
2022-10-21 16:34 ` Shakeel Butt
[not found] ` <CALvZod5di3saFdDJ1cwFDgvLPmnEJ7XB9P8YBTJ3uzfBKAFi3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-10-21 17:40 ` Jakub Kicinski [this message]
2022-10-21 17:40 ` Jakub Kicinski
2022-10-21 18:53 ` Shakeel Butt
[not found] ` <20221021160304.1362511-1-kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2022-10-24 16:02 ` Roman Gushchin
2022-10-24 16:02 ` Roman Gushchin
2022-10-24 18:20 ` patchwork-bot+netdevbpf-DgEjT+Ai2ygdnm+yROfE0A
2022-10-24 18:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221021104016.407cbda9@kernel.org \
--to=kuba-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=ncardwell-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pabeni-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org \
--cc=shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=weiwan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=ycheng-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.