All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 06/10] phy: qcom-qmp-ufs: clean up PHY init
Date: Mon, 24 Oct 2022 11:00:37 +0200	[thread overview]
Message-ID: <20221024090041.19574-7-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221024090041.19574-1-johan+linaro@kernel.org>

Clean up the PHY initialisation somewhat programming both tx and rx for
the second lane after the first lane.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
index 90583b87efd1..fa703e856eb7 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
@@ -859,14 +859,12 @@ static int qmp_ufs_power_on(struct phy *phy)
 
 	/* Tx, Rx, and PCS configurations */
 	qmp_ufs_configure_lane(tx, cfg->tx_tbl, cfg->tx_tbl_num, 1);
-
-	if (cfg->lanes >= 2)
-		qmp_ufs_configure_lane(qmp->tx2, cfg->tx_tbl, cfg->tx_tbl_num, 2);
-
 	qmp_ufs_configure_lane(rx, cfg->rx_tbl, cfg->rx_tbl_num, 1);
 
-	if (cfg->lanes >= 2)
+	if (cfg->lanes >= 2) {
+		qmp_ufs_configure_lane(qmp->tx2, cfg->tx_tbl, cfg->tx_tbl_num, 2);
 		qmp_ufs_configure_lane(qmp->rx2, cfg->rx_tbl, cfg->rx_tbl_num, 2);
+	}
 
 	qmp_ufs_configure(pcs, cfg->pcs_tbl, cfg->pcs_tbl_num);
 
-- 
2.37.3


WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 06/10] phy: qcom-qmp-ufs: clean up PHY init
Date: Mon, 24 Oct 2022 11:00:37 +0200	[thread overview]
Message-ID: <20221024090041.19574-7-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221024090041.19574-1-johan+linaro@kernel.org>

Clean up the PHY initialisation somewhat programming both tx and rx for
the second lane after the first lane.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
index 90583b87efd1..fa703e856eb7 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
@@ -859,14 +859,12 @@ static int qmp_ufs_power_on(struct phy *phy)
 
 	/* Tx, Rx, and PCS configurations */
 	qmp_ufs_configure_lane(tx, cfg->tx_tbl, cfg->tx_tbl_num, 1);
-
-	if (cfg->lanes >= 2)
-		qmp_ufs_configure_lane(qmp->tx2, cfg->tx_tbl, cfg->tx_tbl_num, 2);
-
 	qmp_ufs_configure_lane(rx, cfg->rx_tbl, cfg->rx_tbl_num, 1);
 
-	if (cfg->lanes >= 2)
+	if (cfg->lanes >= 2) {
+		qmp_ufs_configure_lane(qmp->tx2, cfg->tx_tbl, cfg->tx_tbl_num, 2);
 		qmp_ufs_configure_lane(qmp->rx2, cfg->rx_tbl, cfg->rx_tbl_num, 2);
+	}
 
 	qmp_ufs_configure(pcs, cfg->pcs_tbl, cfg->pcs_tbl_num);
 
-- 
2.37.3


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  parent reply	other threads:[~2022-10-24  9:01 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24  9:00 [PATCH 00/10] phy: qcom-qmp-ufs: fix sc8280xp binding Johan Hovold
2022-10-24  9:00 ` Johan Hovold
2022-10-24  9:00 ` [PATCH 01/10] phy: qcom-qmp-ufs: move device-id table Johan Hovold
2022-10-24  9:00   ` Johan Hovold
2022-10-24 13:29   ` Dmitry Baryshkov
2022-10-24 13:29     ` Dmitry Baryshkov
2022-10-24  9:00 ` [PATCH 02/10] phy: qcom-qmp-ufs: merge driver data Johan Hovold
2022-10-24  9:00   ` Johan Hovold
2022-10-24 13:30   ` Dmitry Baryshkov
2022-10-24 13:30     ` Dmitry Baryshkov
2022-10-24  9:00 ` [PATCH 03/10] phy: qcom-qmp-ufs: clean up device-tree parsing Johan Hovold
2022-10-24  9:00   ` Johan Hovold
2022-10-24 13:30   ` Dmitry Baryshkov
2022-10-24 13:30     ` Dmitry Baryshkov
2022-10-24  9:00 ` [PATCH 04/10] phy: qcom-qmp-ufs: clean up probe initialisation Johan Hovold
2022-10-24  9:00   ` Johan Hovold
2022-10-24 13:31   ` Dmitry Baryshkov
2022-10-24 13:31     ` Dmitry Baryshkov
2022-10-24  9:00 ` [PATCH 05/10] phy: qcom-qmp-ufs: rename PHY ops structure Johan Hovold
2022-10-24  9:00   ` Johan Hovold
2022-10-24 13:31   ` Dmitry Baryshkov
2022-10-24 13:31     ` Dmitry Baryshkov
2022-10-24  9:00 ` Johan Hovold [this message]
2022-10-24  9:00   ` [PATCH 06/10] phy: qcom-qmp-ufs: clean up PHY init Johan Hovold
2022-10-24 13:31   ` Dmitry Baryshkov
2022-10-24 13:31     ` Dmitry Baryshkov
2022-10-24  9:00 ` [PATCH 07/10] dt-bindings: phy: qcom,qmp-ufs: rename current bindings Johan Hovold
2022-10-24  9:00   ` Johan Hovold
2022-10-28  2:09   ` Krzysztof Kozlowski
2022-10-28  2:09     ` Krzysztof Kozlowski
2022-10-24  9:00 ` [PATCH 08/10] dt-bindings: phy: qcom,qmp-ufs: fix sc8280xp binding Johan Hovold
2022-10-24  9:00   ` Johan Hovold
2022-10-28  2:11   ` Krzysztof Kozlowski
2022-10-28  2:11     ` Krzysztof Kozlowski
2022-10-24  9:00 ` [PATCH 09/10] phy: qcom-qmp-ufs: restructure PHY creation Johan Hovold
2022-10-24  9:00   ` Johan Hovold
2022-10-24 13:32   ` Dmitry Baryshkov
2022-10-24 13:32     ` Dmitry Baryshkov
2022-10-24  9:00 ` [PATCH 10/10] phy: qcom-qmp-ufs: add support for updated sc8280xp binding Johan Hovold
2022-10-24  9:00   ` Johan Hovold
2022-10-24 13:32   ` Dmitry Baryshkov
2022-10-24 13:32     ` Dmitry Baryshkov
2022-10-24 14:03 ` [PATCH 00/10] phy: qcom-qmp-ufs: fix " Dmitry Baryshkov
2022-10-24 14:03   ` Dmitry Baryshkov
2022-10-28 13:00 ` Vinod Koul
2022-10-28 13:00   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221024090041.19574-7-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.