From: Jakub Kicinski <kuba@kernel.org>
To: kernel test robot <lkp@intel.com>,
Russell King <rmk+kernel@armlinux.org.uk>
Cc: linux-parisc@vger.kernel.org, netdev@vger.kernel.org,
amd-gfx@lists.freedesktop.org,
Linux Memory Management List <linux-mm@kvack.org>,
linux-mediatek@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
ntfs3@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [linux-next:master] BUILD SUCCESS WITH WARNING 76cf65d1377f733af1e2a55233e3353ffa577f54
Date: Mon, 24 Oct 2022 14:55:27 -0700 [thread overview]
Message-ID: <20221024145527.0eff7844@kernel.org> (raw)
In-Reply-To: <6356c451.pwLIF+9EvDUrDjTY%lkp@intel.com>
On Tue, 25 Oct 2022 00:58:57 +0800 kernel test robot wrote:
> drivers/net/phy/phylink.c:588 phylink_validate_mask_caps() warn: variable dereferenced before check 'state' (see line 583)
Hi Russell, I think the warning is semi-legit. Your commit f392a1846489
("net: phylink: provide phylink_validate_mask_caps() helper") added an
if (state) before defer'ing state but it's already deref'ed higher up
so can't be null.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: kernel test robot <lkp@intel.com>,
Russell King <rmk+kernel@armlinux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
ntfs3@lists.linux.dev, netdev@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
amd-gfx@lists.freedesktop.org,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master] BUILD SUCCESS WITH WARNING 76cf65d1377f733af1e2a55233e3353ffa577f54
Date: Mon, 24 Oct 2022 14:55:27 -0700 [thread overview]
Message-ID: <20221024145527.0eff7844@kernel.org> (raw)
In-Reply-To: <6356c451.pwLIF+9EvDUrDjTY%lkp@intel.com>
On Tue, 25 Oct 2022 00:58:57 +0800 kernel test robot wrote:
> drivers/net/phy/phylink.c:588 phylink_validate_mask_caps() warn: variable dereferenced before check 'state' (see line 583)
Hi Russell, I think the warning is semi-legit. Your commit f392a1846489
("net: phylink: provide phylink_validate_mask_caps() helper") added an
if (state) before defer'ing state but it's already deref'ed higher up
so can't be null.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: kernel test robot <lkp@intel.com>,
Russell King <rmk+kernel@armlinux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
ntfs3@lists.linux.dev, netdev@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
amd-gfx@lists.freedesktop.org,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master] BUILD SUCCESS WITH WARNING 76cf65d1377f733af1e2a55233e3353ffa577f54
Date: Mon, 24 Oct 2022 14:55:27 -0700 [thread overview]
Message-ID: <20221024145527.0eff7844@kernel.org> (raw)
In-Reply-To: <6356c451.pwLIF+9EvDUrDjTY%lkp@intel.com>
On Tue, 25 Oct 2022 00:58:57 +0800 kernel test robot wrote:
> drivers/net/phy/phylink.c:588 phylink_validate_mask_caps() warn: variable dereferenced before check 'state' (see line 583)
Hi Russell, I think the warning is semi-legit. Your commit f392a1846489
("net: phylink: provide phylink_validate_mask_caps() helper") added an
if (state) before defer'ing state but it's already deref'ed higher up
so can't be null.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-24 21:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 16:58 [linux-next:master] BUILD SUCCESS WITH WARNING 76cf65d1377f733af1e2a55233e3353ffa577f54 kernel test robot
2022-10-24 16:58 ` kernel test robot
2022-10-24 16:58 ` kernel test robot
2022-10-24 21:55 ` Jakub Kicinski [this message]
2022-10-24 21:55 ` Jakub Kicinski
2022-10-24 21:55 ` Jakub Kicinski
2022-10-25 8:21 ` Russell King (Oracle)
2022-10-25 8:21 ` Russell King (Oracle)
2022-10-25 8:21 ` Russell King (Oracle)
2022-10-25 18:52 ` Jakub Kicinski
2022-10-25 18:52 ` Jakub Kicinski
2022-10-25 18:52 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024145527.0eff7844@kernel.org \
--to=kuba@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.