All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Frank Wunderlich <linux@fw-web.de>
Cc: devicetree@vger.kernel.org, Ryder Lee <ryder.lee@mediatek.com>,
	Steven Liu <steven.liu@mediatek.com>,
	Sam Shih <Sam.Shih@mediatek.com>,
	linux-kernel@vger.kernel.org,
	Jianjun Wang <jianjun.wang@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-mediatek@lists.infradead.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] dt-bindings: PCI: mediatek-gen3: add mt7986 clock config
Date: Mon, 24 Oct 2022 14:23:13 -0500	[thread overview]
Message-ID: <20221024192313.GA2069519-robh@kernel.org> (raw)
In-Reply-To: <20221023170234.83621-4-linux@fw-web.de>

On Sun, Oct 23, 2022 at 07:02:34PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> MT7986 needs 4 clocks for PCIe, define them in binding.

Patch 2 is incomplete without this one. Therefore, patch 2 and 3 should 
be 1 patch.

> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  .../bindings/pci/mediatek-pcie-gen3.yaml         | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> index 3662422b38ea..e6020e684c00 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> @@ -79,9 +79,11 @@ properties:
>        - const: mac
>  
>    clocks:
> +    minItems: 4
>      maxItems: 6
>  
>    clock-names:
> +    minItems: 4
>      maxItems: 6
>  
>    assigned-clocks:
> @@ -162,6 +164,20 @@ allOf:
>              - const: tl_32k
>              - const: peri_26m
>              - const: peri_mem
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - mediatek,mt7986-pcie
> +    then:
> +      properties:
> +        clock-names:
> +          items:
> +            - const: pl_250m
> +            - const: tl_26m
> +            - const: peri_26m
> +            - const: top_133m
>  
>  unevaluatedProperties: false
>  
> -- 
> 2.34.1
> 
> 


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Frank Wunderlich <linux@fw-web.de>
Cc: linux-mediatek@lists.infradead.org,
	Frank Wunderlich <frank-w@public-files.de>,
	Ryder Lee <ryder.lee@mediatek.com>,
	Sam Shih <Sam.Shih@mediatek.com>,
	Steven Liu <steven.liu@mediatek.com>,
	Jianjun Wang <jianjun.wang@mediatek.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] dt-bindings: PCI: mediatek-gen3: add mt7986 clock config
Date: Mon, 24 Oct 2022 14:23:13 -0500	[thread overview]
Message-ID: <20221024192313.GA2069519-robh@kernel.org> (raw)
In-Reply-To: <20221023170234.83621-4-linux@fw-web.de>

On Sun, Oct 23, 2022 at 07:02:34PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> MT7986 needs 4 clocks for PCIe, define them in binding.

Patch 2 is incomplete without this one. Therefore, patch 2 and 3 should 
be 1 patch.

> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  .../bindings/pci/mediatek-pcie-gen3.yaml         | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> index 3662422b38ea..e6020e684c00 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> @@ -79,9 +79,11 @@ properties:
>        - const: mac
>  
>    clocks:
> +    minItems: 4
>      maxItems: 6
>  
>    clock-names:
> +    minItems: 4
>      maxItems: 6
>  
>    assigned-clocks:
> @@ -162,6 +164,20 @@ allOf:
>              - const: tl_32k
>              - const: peri_26m
>              - const: peri_mem
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - mediatek,mt7986-pcie
> +    then:
> +      properties:
> +        clock-names:
> +          items:
> +            - const: pl_250m
> +            - const: tl_26m
> +            - const: peri_26m
> +            - const: top_133m
>  
>  unevaluatedProperties: false
>  
> -- 
> 2.34.1
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Frank Wunderlich <linux@fw-web.de>
Cc: linux-mediatek@lists.infradead.org,
	Frank Wunderlich <frank-w@public-files.de>,
	Ryder Lee <ryder.lee@mediatek.com>,
	Sam Shih <Sam.Shih@mediatek.com>,
	Steven Liu <steven.liu@mediatek.com>,
	Jianjun Wang <jianjun.wang@mediatek.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] dt-bindings: PCI: mediatek-gen3: add mt7986 clock config
Date: Mon, 24 Oct 2022 14:23:13 -0500	[thread overview]
Message-ID: <20221024192313.GA2069519-robh@kernel.org> (raw)
In-Reply-To: <20221023170234.83621-4-linux@fw-web.de>

On Sun, Oct 23, 2022 at 07:02:34PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> MT7986 needs 4 clocks for PCIe, define them in binding.

Patch 2 is incomplete without this one. Therefore, patch 2 and 3 should 
be 1 patch.

> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  .../bindings/pci/mediatek-pcie-gen3.yaml         | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> index 3662422b38ea..e6020e684c00 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> @@ -79,9 +79,11 @@ properties:
>        - const: mac
>  
>    clocks:
> +    minItems: 4
>      maxItems: 6
>  
>    clock-names:
> +    minItems: 4
>      maxItems: 6
>  
>    assigned-clocks:
> @@ -162,6 +164,20 @@ allOf:
>              - const: tl_32k
>              - const: peri_26m
>              - const: peri_mem
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - mediatek,mt7986-pcie
> +    then:
> +      properties:
> +        clock-names:
> +          items:
> +            - const: pl_250m
> +            - const: tl_26m
> +            - const: peri_26m
> +            - const: top_133m
>  
>  unevaluatedProperties: false
>  
> -- 
> 2.34.1
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-10-24 19:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-23 17:02 [PATCH 0/3] rework mtk pcie-gen3 bindings and support mt7986 Frank Wunderlich
2022-10-23 17:02 ` Frank Wunderlich
2022-10-23 17:02 ` Frank Wunderlich
2022-10-23 17:02 ` [PATCH 1/3] dt-bindings: PCI: mediatek-gen3: add SoC based clock config Frank Wunderlich
2022-10-23 17:02   ` Frank Wunderlich
2022-10-23 17:02   ` Frank Wunderlich
2022-10-24 19:21   ` Rob Herring
2022-10-24 19:21     ` Rob Herring
2022-10-24 19:21     ` Rob Herring
2022-10-25  1:27   ` Jianjun Wang
2022-10-25  1:27     ` Jianjun Wang
2022-10-25  1:27     ` Jianjun Wang
2022-10-23 17:02 ` [PATCH 2/3] dt-bindings: PCI: mediatek-gen3: add support for mt7986 Frank Wunderlich
2022-10-23 17:02   ` Frank Wunderlich
2022-10-23 17:02   ` Frank Wunderlich
2022-10-23 17:02 ` [PATCH 3/3] dt-bindings: PCI: mediatek-gen3: add mt7986 clock config Frank Wunderlich
2022-10-23 17:02   ` Frank Wunderlich
2022-10-23 17:02   ` Frank Wunderlich
2022-10-24 19:23   ` Rob Herring [this message]
2022-10-24 19:23     ` Rob Herring
2022-10-24 19:23     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221024192313.GA2069519-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Sam.Shih@mediatek.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jianjun.wang@mediatek.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@fw-web.de \
    --cc=matthias.bgg@gmail.com \
    --cc=ryder.lee@mediatek.com \
    --cc=steven.liu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.