From: Jakub Kicinski <kuba@kernel.org>
To: Cai Huoqing <cai.huoqing@linux.dev>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Zhengchao Shao <shaozhengchao@huawei.com>,
Bin Chen <bin.chen@corigine.com>,
Alexei Starovoitov <ast@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable
Date: Thu, 27 Oct 2022 11:02:41 -0700 [thread overview]
Message-ID: <20221027110241.0340abdf@kernel.org> (raw)
In-Reply-To: <20221026125922.34080-1-cai.huoqing@linux.dev>
On Wed, 26 Oct 2022 20:59:10 +0800 Cai Huoqing wrote:
> Subject: [PATCH 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable
Please put [PATCH net-next] or [PATCH -next] in the subject,
to make the patch sorting easier for maintainers.
> The print cmd code is in hex, so using hex cmd code intead of
> decimal is easy to check the value with print info.
> - HINIC_PORT_CMD_SET_AUTONEG = 219,
> -
> - HINIC_PORT_CMD_GET_STD_SFP_INFO = 240,
> -
> - HINIC_PORT_CMD_SET_LRO_TIMER = 244,
> -
> - HINIC_PORT_CMD_SET_VF_MAX_MIN_RATE = 249,
> -
> - HINIC_PORT_CMD_GET_SFP_ABS = 251,
> + HINIC_PORT_CMD_GET_SFP_ABS = 0xFB,
This deletes some entries. Please don't mix changes with mechanical
conversions.
next prev parent reply other threads:[~2022-10-27 18:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 12:59 [PATCH 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable Cai Huoqing
2022-10-26 12:59 ` [PATCH 2/2] net: hinic: Add control command support for VF PMD driver in DPDK Cai Huoqing
2022-10-27 18:03 ` Jakub Kicinski
2022-10-28 4:56 ` Cai Huoqing
2022-10-28 15:56 ` Jakub Kicinski
2022-10-29 7:53 ` Cai Huoqing
2022-10-31 23:52 ` Jakub Kicinski
2022-11-01 1:49 ` Cai Huoqing
2022-11-01 2:58 ` Jakub Kicinski
2022-10-28 1:21 ` shaozhengchao
2022-10-28 5:24 ` Cai Huoqing
2022-10-27 18:02 ` Jakub Kicinski [this message]
2022-10-28 4:37 ` [PATCH 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable Cai Huoqing
2022-10-31 2:17 ` Cai Huoqing
2022-11-01 2:23 ` Cai Huoqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221027110241.0340abdf@kernel.org \
--to=kuba@kernel.org \
--cc=ast@kernel.org \
--cc=bin.chen@corigine.com \
--cc=cai.huoqing@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaozhengchao@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.