From: Jakub Kicinski <kuba@kernel.org>
To: Cai Huoqing <cai.huoqing@linux.dev>
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Zhengchao Shao" <shaozhengchao@huawei.com>,
"Bin Chen" <bin.chen@corigine.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Peter Chen" <peter.chen@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: hinic: Add control command support for VF PMD driver in DPDK
Date: Fri, 28 Oct 2022 08:56:51 -0700 [thread overview]
Message-ID: <20221028085651.78408e2c@kernel.org> (raw)
In-Reply-To: <20221028045655.GB3164@chq-T47>
On Fri, 28 Oct 2022 12:56:55 +0800 Cai Huoqing wrote:
> > The commands are actually supported or you're just ignoring them
> > silently?
> No,
Do you mean "neither"?
> if the cmd is not added to 'nic_cmd_support_vf',
> the PF will return false, and the error messsage "PF Receive VFx
> unsupported cmd x" in the function 'hinic_mbox_check_cmd_valid',
> then, the configuration will not be set to hardware.
You're describing the behavior before the patch?
After the patch the command is ignored silently, like I said, right?
Because there is no handler added to nic_vf_cmd_msg_handler[].
Why is that okay? Or is there handler somewhere else?
next prev parent reply other threads:[~2022-10-28 16:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 12:59 [PATCH 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable Cai Huoqing
2022-10-26 12:59 ` [PATCH 2/2] net: hinic: Add control command support for VF PMD driver in DPDK Cai Huoqing
2022-10-27 18:03 ` Jakub Kicinski
2022-10-28 4:56 ` Cai Huoqing
2022-10-28 15:56 ` Jakub Kicinski [this message]
2022-10-29 7:53 ` Cai Huoqing
2022-10-31 23:52 ` Jakub Kicinski
2022-11-01 1:49 ` Cai Huoqing
2022-11-01 2:58 ` Jakub Kicinski
2022-10-28 1:21 ` shaozhengchao
2022-10-28 5:24 ` Cai Huoqing
2022-10-27 18:02 ` [PATCH 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable Jakub Kicinski
2022-10-28 4:37 ` Cai Huoqing
2022-10-31 2:17 ` Cai Huoqing
2022-11-01 2:23 ` Cai Huoqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221028085651.78408e2c@kernel.org \
--to=kuba@kernel.org \
--cc=bin.chen@corigine.com \
--cc=cai.huoqing@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peter.chen@kernel.org \
--cc=shaozhengchao@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.