All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH v4 13/16] phy: qcom-qmp-pcie: fix initialisation reset
Date: Fri, 28 Oct 2022 15:36:00 +0200	[thread overview]
Message-ID: <20221028133603.18470-14-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221028133603.18470-1-johan+linaro@kernel.org>

Add the missing delay after asserting reset. This is specifically needed
for the reset to have any effect on SC8280XP.

The vendor driver uses a 1 ms delay, but that seems a bit excessive.
Instead use a 200 us delay which appears to be more than enough and also
matches the UFS reset delay added by commit 870b1279c7a0 ("scsi:
ufs-qcom: Add reset control support for host controller").

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
index 2f4bdef73395..9c8e009033f1 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
@@ -1866,6 +1866,8 @@ static int qmp_pcie_init(struct phy *phy)
 		goto err_disable_regulators;
 	}
 
+	usleep_range(200, 300);
+
 	ret = reset_control_bulk_deassert(cfg->num_resets, qmp->resets);
 	if (ret) {
 		dev_err(qmp->dev, "reset deassert failed\n");
-- 
2.37.3


WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH v4 13/16] phy: qcom-qmp-pcie: fix initialisation reset
Date: Fri, 28 Oct 2022 15:36:00 +0200	[thread overview]
Message-ID: <20221028133603.18470-14-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221028133603.18470-1-johan+linaro@kernel.org>

Add the missing delay after asserting reset. This is specifically needed
for the reset to have any effect on SC8280XP.

The vendor driver uses a 1 ms delay, but that seems a bit excessive.
Instead use a 200 us delay which appears to be more than enough and also
matches the UFS reset delay added by commit 870b1279c7a0 ("scsi:
ufs-qcom: Add reset control support for host controller").

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
index 2f4bdef73395..9c8e009033f1 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
@@ -1866,6 +1866,8 @@ static int qmp_pcie_init(struct phy *phy)
 		goto err_disable_regulators;
 	}
 
+	usleep_range(200, 300);
+
 	ret = reset_control_bulk_deassert(cfg->num_resets, qmp->resets);
 	if (ret) {
 		dev_err(qmp->dev, "reset deassert failed\n");
-- 
2.37.3


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  parent reply	other threads:[~2022-10-28 13:37 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-28 13:35 [PATCH v4 00/16] phy: qcom-qmp-pcie: add support for sc8280xp Johan Hovold
2022-10-28 13:35 ` Johan Hovold
2022-10-28 13:35 ` [PATCH v4 01/16] phy: qcom-qmp-pcie: sort device-id table Johan Hovold
2022-10-28 13:35   ` Johan Hovold
2022-10-28 13:35 ` [PATCH v4 02/16] phy: qcom-qmp-pcie: move " Johan Hovold
2022-10-28 13:35   ` Johan Hovold
2022-10-28 13:35 ` [PATCH v4 03/16] phy: qcom-qmp-pcie: merge driver data Johan Hovold
2022-10-28 13:35   ` Johan Hovold
2022-10-28 13:35 ` [PATCH v4 04/16] phy: qcom-qmp-pcie: clean up device-tree parsing Johan Hovold
2022-10-28 13:35   ` Johan Hovold
2022-10-28 14:14   ` Dmitry Baryshkov
2022-10-28 14:14     ` Dmitry Baryshkov
2022-10-28 13:35 ` [PATCH v4 05/16] phy: qcom-qmp-pcie: clean up probe initialisation Johan Hovold
2022-10-28 13:35   ` Johan Hovold
2022-10-28 13:35 ` [PATCH v4 06/16] phy: qcom-qmp-pcie: rename PHY ops structure Johan Hovold
2022-10-28 13:35   ` Johan Hovold
2022-10-28 13:35 ` [PATCH v4 07/16] phy: qcom-qmp-pcie: clean up PHY lane init Johan Hovold
2022-10-28 13:35   ` Johan Hovold
2022-10-28 13:35 ` [PATCH v4 08/16] phy: qcom-qmp-pcie: use shorter tables identifier Johan Hovold
2022-10-28 13:35   ` Johan Hovold
2022-11-05 12:07   ` Vinod Koul
2022-11-05 12:07     ` Vinod Koul
2022-11-05 13:11     ` Johan Hovold
2022-11-05 13:11       ` Johan Hovold
2022-10-28 13:35 ` [PATCH v4 09/16] phy: qcom-qmp-pcie: add register init helper Johan Hovold
2022-10-28 13:35   ` Johan Hovold
2022-10-28 14:15   ` Dmitry Baryshkov
2022-10-28 14:15     ` Dmitry Baryshkov
2022-11-05 12:08   ` Vinod Koul
2022-11-05 12:08     ` Vinod Koul
2022-11-05 13:17     ` Johan Hovold
2022-11-05 13:17       ` Johan Hovold
2022-11-05 13:30       ` Vinod Koul
2022-11-05 13:30         ` Vinod Koul
2022-10-28 13:35 ` [PATCH v4 10/16] dt-bindings: phy: qcom,qmp-pcie: rename current bindings Johan Hovold
2022-10-28 13:35   ` Johan Hovold
2022-10-28 21:57   ` Krzysztof Kozlowski
2022-10-28 21:57     ` Krzysztof Kozlowski
2022-10-29  8:47     ` Johan Hovold
2022-10-29  8:47       ` Johan Hovold
2022-11-05 12:09       ` Vinod Koul
2022-11-05 12:09         ` Vinod Koul
2022-11-05 13:19         ` Johan Hovold
2022-11-05 13:19           ` Johan Hovold
2022-10-28 13:35 ` [PATCH v4 11/16] dt-bindings: phy: qcom,qmp-pcie: add sc8280xp bindings Johan Hovold
2022-10-28 13:35   ` Johan Hovold
2022-10-28 13:35 ` [PATCH v4 12/16] phy: qcom-qmp-pcie: restructure PHY creation Johan Hovold
2022-10-28 13:35   ` Johan Hovold
2022-10-28 13:36 ` Johan Hovold [this message]
2022-10-28 13:36   ` [PATCH v4 13/16] phy: qcom-qmp-pcie: fix initialisation reset Johan Hovold
2022-10-28 13:36 ` [PATCH v4 14/16] phy: qcom-qmp-pcie: add support for pipediv2 clock Johan Hovold
2022-10-28 13:36   ` Johan Hovold
2022-10-28 13:36 ` [PATCH v4 15/16] phy: qcom-qmp-pcie: add support for sc8280xp Johan Hovold
2022-10-28 13:36   ` Johan Hovold
2022-10-28 14:17   ` Dmitry Baryshkov
2022-10-28 14:17     ` Dmitry Baryshkov
2022-10-28 13:36 ` [PATCH v4 16/16] phy: qcom-qmp-pcie: add support for sc8280xp 4-lane PHYs Johan Hovold
2022-10-28 13:36   ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221028133603.18470-14-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.