From: Rob Herring <robh@kernel.org>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
devicetree@vger.kernel.org, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: phy: Fix UniPhier SATA controller node names in example
Date: Fri, 28 Oct 2022 14:38:59 -0500 [thread overview]
Message-ID: <20221028193859.GA2188803-robh@kernel.org> (raw)
In-Reply-To: <20221027044920.23194-3-hayashi.kunihiko@socionext.com>
On Thu, Oct 27, 2022 at 01:49:20PM +0900, Kunihiko Hayashi wrote:
> The word "glue" is ambiguous for the controller node name. Should put
> "sata-controller" instead of "ahci-glue" on the controller node.
> And rename a phy node to "sata-phy".
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> index a3cd45acea28..89b8b133777a 100644
> --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> @@ -117,14 +117,14 @@ additionalProperties: false
>
> examples:
> - |
> - ahci-glue@65700000 {
> + sata-controller@65700000 {
But is this really the SATA controller aka AHCI?
In cases where we don't have a standardized name, I don't think it makes
sense changing node names from one non-standard name to another.
> compatible = "socionext,uniphier-pxs3-ahci-glue",
> "simple-mfd";
> #address-cells = <1>;
> #size-cells = <1>;
> ranges = <0 0x65700000 0x100>;
>
> - ahci_phy: phy@10 {
> + ahci_phy: sata-phy@10 {
> compatible = "socionext,uniphier-pxs3-ahci-phy";
> reg = <0x10 0x10>;
> #phy-cells = <0>;
> --
> 2.25.1
>
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
devicetree@vger.kernel.org, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: phy: Fix UniPhier SATA controller node names in example
Date: Fri, 28 Oct 2022 14:38:59 -0500 [thread overview]
Message-ID: <20221028193859.GA2188803-robh@kernel.org> (raw)
In-Reply-To: <20221027044920.23194-3-hayashi.kunihiko@socionext.com>
On Thu, Oct 27, 2022 at 01:49:20PM +0900, Kunihiko Hayashi wrote:
> The word "glue" is ambiguous for the controller node name. Should put
> "sata-controller" instead of "ahci-glue" on the controller node.
> And rename a phy node to "sata-phy".
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> index a3cd45acea28..89b8b133777a 100644
> --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> @@ -117,14 +117,14 @@ additionalProperties: false
>
> examples:
> - |
> - ahci-glue@65700000 {
> + sata-controller@65700000 {
But is this really the SATA controller aka AHCI?
In cases where we don't have a standardized name, I don't think it makes
sense changing node names from one non-standard name to another.
> compatible = "socionext,uniphier-pxs3-ahci-glue",
> "simple-mfd";
> #address-cells = <1>;
> #size-cells = <1>;
> ranges = <0 0x65700000 0x100>;
>
> - ahci_phy: phy@10 {
> + ahci_phy: sata-phy@10 {
> compatible = "socionext,uniphier-pxs3-ahci-phy";
> reg = <0x10 0x10>;
> #phy-cells = <0>;
> --
> 2.25.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
devicetree@vger.kernel.org, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: phy: Fix UniPhier SATA controller node names in example
Date: Fri, 28 Oct 2022 14:38:59 -0500 [thread overview]
Message-ID: <20221028193859.GA2188803-robh@kernel.org> (raw)
In-Reply-To: <20221027044920.23194-3-hayashi.kunihiko@socionext.com>
On Thu, Oct 27, 2022 at 01:49:20PM +0900, Kunihiko Hayashi wrote:
> The word "glue" is ambiguous for the controller node name. Should put
> "sata-controller" instead of "ahci-glue" on the controller node.
> And rename a phy node to "sata-phy".
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> index a3cd45acea28..89b8b133777a 100644
> --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> @@ -117,14 +117,14 @@ additionalProperties: false
>
> examples:
> - |
> - ahci-glue@65700000 {
> + sata-controller@65700000 {
But is this really the SATA controller aka AHCI?
In cases where we don't have a standardized name, I don't think it makes
sense changing node names from one non-standard name to another.
> compatible = "socionext,uniphier-pxs3-ahci-glue",
> "simple-mfd";
> #address-cells = <1>;
> #size-cells = <1>;
> ranges = <0 0x65700000 0x100>;
>
> - ahci_phy: phy@10 {
> + ahci_phy: sata-phy@10 {
> compatible = "socionext,uniphier-pxs3-ahci-phy";
> reg = <0x10 0x10>;
> #phy-cells = <0>;
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2022-10-28 19:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 4:49 [PATCH 0/2] dt-bindings: phy: Fix UniPhier controller node names Kunihiko Hayashi
2022-10-27 4:49 ` Kunihiko Hayashi
2022-10-27 4:49 ` Kunihiko Hayashi
2022-10-27 4:49 ` [PATCH 1/2] dt-bindings: phy: Fix UniPhier USB3 controller node names in example Kunihiko Hayashi
2022-10-27 4:49 ` Kunihiko Hayashi
2022-10-27 4:49 ` Kunihiko Hayashi
2022-10-28 19:35 ` Rob Herring
2022-10-28 19:35 ` Rob Herring
2022-10-28 19:35 ` Rob Herring
2022-10-27 4:49 ` [PATCH 2/2] dt-bindings: phy: Fix UniPhier SATA " Kunihiko Hayashi
2022-10-27 4:49 ` Kunihiko Hayashi
2022-10-27 4:49 ` Kunihiko Hayashi
2022-10-28 19:38 ` Rob Herring [this message]
2022-10-28 19:38 ` Rob Herring
2022-10-28 19:38 ` Rob Herring
2022-11-01 9:10 ` Kunihiko Hayashi
2022-11-01 9:10 ` Kunihiko Hayashi
2022-11-01 9:10 ` Kunihiko Hayashi
2022-11-01 19:31 ` Rob Herring
2022-11-01 19:31 ` Rob Herring
2022-11-01 19:31 ` Rob Herring
2022-11-01 23:14 ` Kunihiko Hayashi
2022-11-01 23:14 ` Kunihiko Hayashi
2022-11-01 23:14 ` Kunihiko Hayashi
2022-11-05 7:34 ` Vinod Koul
2022-11-05 7:34 ` Vinod Koul
2022-11-05 7:34 ` Vinod Koul
2022-11-07 2:36 ` Kunihiko Hayashi
2022-11-07 2:36 ` Kunihiko Hayashi
2022-11-07 2:36 ` Kunihiko Hayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221028193859.GA2188803-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mhiramat@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.