From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yicong Yang <yangyicong@huawei.com>
Cc: peter.maydell@linaro.org, imammedo@redhat.com, ani@anisinha.ca,
eduardo@habkost.net, marcel.apfelbaum@gmail.com, f4bug@amsat.org,
wangyanan55@huawei.com, qemu-devel@nongnu.org,
jonathan.cameron@huawei.com, linuxarm@huawei.com,
yangyicong@hisilicon.com, prime.zeng@huawei.com,
hesham.almatary@huawei.com, ionela.voinescu@arm.com,
darren@os.amperecomputing.com
Subject: Re: [PATCH v2 2/4] tests: virt: update expected ACPI tables for virt test
Date: Sat, 29 Oct 2022 03:53:43 -0400 [thread overview]
Message-ID: <20221029035311-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20221027032613.18377-3-yangyicong@huawei.com>
On Thu, Oct 27, 2022 at 11:26:11AM +0800, Yicong Yang wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
>
> Update the ACPI tables according to the acpi aml_build change.
>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
OK nice but if patch 1 is applied alone that will break make check
won't it? And this means the patchset breaks git bisect.
Pls look at top of tests/qtest/bios-tables-test.c to see
how to organize a patchset changing expected tables.
> ---
> tests/data/acpi/virt/PPTT | Bin 96 -> 76 bytes
> 1 file changed, 0 insertions(+), 0 deletions(-)
>
> diff --git a/tests/data/acpi/virt/PPTT b/tests/data/acpi/virt/PPTT
> index f56ea63b369a604877374ad696c396e796ab1c83..7a1258ecf123555b24462c98ccbb76b4ac1d0c2b 100644
> GIT binary patch
> delta 32
> fcmYfB;R*-{3GrcIU|?D?k;`ae01J-_kOKn%ZFdCM
>
> delta 53
> pcmeZC;0g!`2}xjJU|{l?$YrDgWH5jU5Ca567#O&Klm(arApowi1QY-O
>
> --
> 2.24.0
next prev parent reply other threads:[~2022-10-29 7:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 3:26 [PATCH v2 0/4] Only generate cluster node in PPTT when specified Yicong Yang via
2022-10-27 3:26 ` [PATCH v2 1/4] hw/acpi/aml-build: " Yicong Yang via
2022-10-31 6:56 ` wangyanan (Y) via
2022-10-31 7:31 ` Yicong Yang via
2022-10-27 3:26 ` [PATCH v2 2/4] tests: virt: update expected ACPI tables for virt test Yicong Yang via
2022-10-29 7:53 ` Michael S. Tsirkin [this message]
2022-10-31 7:28 ` Yicong Yang via
2022-10-27 3:26 ` [PATCH v2 3/4] tests: acpi: aarch64: add topology test for aarch64 Yicong Yang via
2022-10-29 7:54 ` Michael S. Tsirkin
2022-10-27 3:26 ` [PATCH v2 4/4] tests: acpi: aarch64: add *.topology tables Yicong Yang via
2022-10-27 6:33 ` [PATCH v2 0/4] Only generate cluster node in PPTT when specified Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221029035311-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ani@anisinha.ca \
--cc=darren@os.amperecomputing.com \
--cc=eduardo@habkost.net \
--cc=f4bug@amsat.org \
--cc=hesham.almatary@huawei.com \
--cc=imammedo@redhat.com \
--cc=ionela.voinescu@arm.com \
--cc=jonathan.cameron@huawei.com \
--cc=linuxarm@huawei.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=prime.zeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.