All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yicong Yang <yangyicong@huawei.com>
Cc: peter.maydell@linaro.org, imammedo@redhat.com, ani@anisinha.ca,
	eduardo@habkost.net, marcel.apfelbaum@gmail.com, f4bug@amsat.org,
	wangyanan55@huawei.com, qemu-devel@nongnu.org,
	jonathan.cameron@huawei.com, linuxarm@huawei.com,
	yangyicong@hisilicon.com, prime.zeng@huawei.com,
	hesham.almatary@huawei.com, ionela.voinescu@arm.com,
	darren@os.amperecomputing.com
Subject: Re: [PATCH v2 3/4] tests: acpi: aarch64: add topology test for aarch64
Date: Sat, 29 Oct 2022 03:54:17 -0400	[thread overview]
Message-ID: <20221029035356-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20221027032613.18377-4-yangyicong@huawei.com>

On Thu, Oct 27, 2022 at 11:26:12AM +0800, Yicong Yang wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
> 
> Add test for aarch64's ACPI topology building for all the supported
> levels.
> 
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>

And same comment here.
Pls follow the process in bios-tables-test

> ---
>  tests/qtest/bios-tables-test.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index e6096e7f73..099b723444 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -1533,6 +1533,27 @@ static void test_acpi_virt_tcg(void)
>      free_test_data(&data);
>  }
>  
> +static void test_acpi_virt_tcg_topology(void)
> +{
> +    test_data data = {
> +        .machine = "virt",
> +        .variant = ".topology",
> +        .tcg_only = true,
> +        .uefi_fl1 = "pc-bios/edk2-aarch64-code.fd",
> +        .uefi_fl2 = "pc-bios/edk2-arm-vars.fd",
> +        .cd = "tests/data/uefi-boot-images/bios-tables-test.aarch64.iso.qcow2",
> +        .ram_start = 0x40000000ULL,
> +        .scan_len = 128ULL * 1024 * 1024,
> +    };
> +
> +    data.smbios_cpu_max_speed = 2900;
> +    data.smbios_cpu_curr_speed = 2700;
> +    test_acpi_one("-cpu cortex-a57 "
> +                  "-smbios type=4,max-speed=2900,current-speed=2700 "
> +                  "-smp sockets=1,clusters=2,cores=2,threads=2", &data);
> +    free_test_data(&data);
> +}
> +
>  static void test_acpi_q35_viot(void)
>  {
>      test_data data = {
> @@ -1864,6 +1885,7 @@ int main(int argc, char *argv[])
>      } else if (strcmp(arch, "aarch64") == 0) {
>          if (has_tcg) {
>              qtest_add_func("acpi/virt", test_acpi_virt_tcg);
> +            qtest_add_func("acpi/virt/topology", test_acpi_virt_tcg_topology);
>              qtest_add_func("acpi/virt/numamem", test_acpi_virt_tcg_numamem);
>              qtest_add_func("acpi/virt/memhp", test_acpi_virt_tcg_memhp);
>              qtest_add_func("acpi/virt/pxb", test_acpi_virt_tcg_pxb);
> -- 
> 2.24.0



  reply	other threads:[~2022-10-29  7:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27  3:26 [PATCH v2 0/4] Only generate cluster node in PPTT when specified Yicong Yang via
2022-10-27  3:26 ` [PATCH v2 1/4] hw/acpi/aml-build: " Yicong Yang via
2022-10-31  6:56   ` wangyanan (Y) via
2022-10-31  7:31     ` Yicong Yang via
2022-10-27  3:26 ` [PATCH v2 2/4] tests: virt: update expected ACPI tables for virt test Yicong Yang via
2022-10-29  7:53   ` Michael S. Tsirkin
2022-10-31  7:28     ` Yicong Yang via
2022-10-27  3:26 ` [PATCH v2 3/4] tests: acpi: aarch64: add topology test for aarch64 Yicong Yang via
2022-10-29  7:54   ` Michael S. Tsirkin [this message]
2022-10-27  3:26 ` [PATCH v2 4/4] tests: acpi: aarch64: add *.topology tables Yicong Yang via
2022-10-27  6:33 ` [PATCH v2 0/4] Only generate cluster node in PPTT when specified Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221029035356-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=ani@anisinha.ca \
    --cc=darren@os.amperecomputing.com \
    --cc=eduardo@habkost.net \
    --cc=f4bug@amsat.org \
    --cc=hesham.almatary@huawei.com \
    --cc=imammedo@redhat.com \
    --cc=ionela.voinescu@arm.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linuxarm@huawei.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=prime.zeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wangyanan55@huawei.com \
    --cc=yangyicong@hisilicon.com \
    --cc=yangyicong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.