* [PATCH 0/2] ARM: dts: imx6sl-tolino-shine2hd: Add backlight
@ 2022-10-19 6:51 ` Andreas Kemnade
0 siblings, 0 replies; 8+ messages in thread
From: Andreas Kemnade @ 2022-10-19 6:51 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer, kernel,
festevam, linux-imx, devicetree, linux-arm-kernel, linux-kernel,
j.neuschaefer
Cc: Andreas Kemnade
Add a backlight here, it is a bit special situation. The vendor system
has an option to add some extra brightness together with a big warning
that power consumption is increased. Not sure, where it should fit,
but since the backlight is probably made of leds, this might be the most
convenient place.
Andreas Kemnade (2):
ARM: dts: imx6sl-tolino-shine2hd: Add backlight
ARM: dts: imx6sl-tolino-shine2hd: Add backlight boost
arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 30 +++++++++++++++++++-
1 file changed, 29 insertions(+), 1 deletion(-)
--
2.30.2
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: dts: imx6sl-tolino-shine2hd: Add backlight
2022-10-19 6:51 ` Andreas Kemnade
@ 2022-10-19 6:51 ` Andreas Kemnade
-1 siblings, 0 replies; 8+ messages in thread
From: Andreas Kemnade @ 2022-10-19 6:51 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer, kernel,
festevam, linux-imx, devicetree, linux-arm-kernel, linux-kernel,
j.neuschaefer
Cc: Andreas Kemnade
Add backlight for Tolino Shine2 HD. It uses the PWM
of the embedded controller.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 21 ++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts b/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
index 663ee9df79e6..ea0ce59aa4f1 100644
--- a/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
+++ b/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
@@ -18,6 +18,21 @@ / {
model = "Tolino Shine 2 HD";
compatible = "kobo,tolino-shine2hd", "fsl,imx6sl";
+ backlight {
+ compatible = "pwm-backlight";
+ pwms = <&ec 0 50000>;
+ power-supply = <&backlight_regulator>;
+ };
+
+ backlight_regulator: regulator-backlight {
+ compatible = "regulator-fixed";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_backlight_power>;
+ regulator-name = "backlight";
+ gpio = <&gpio2 10 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
chosen {
stdout-path = &uart1;
};
@@ -299,6 +314,12 @@ &iomuxc {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_hog>;
+ pinctrl_backlight_power: backlight-powergrp {
+ fsl,pins = <
+ MX6SL_PAD_EPDC_PWRCTRL3__GPIO2_IO10 0x10059
+ >;
+ };
+
pinctrl_gpio_keys: gpio-keysgrp {
fsl,pins = <
MX6SL_PAD_SD1_DAT1__GPIO5_IO08 0x17059
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 1/2] ARM: dts: imx6sl-tolino-shine2hd: Add backlight
@ 2022-10-19 6:51 ` Andreas Kemnade
0 siblings, 0 replies; 8+ messages in thread
From: Andreas Kemnade @ 2022-10-19 6:51 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer, kernel,
festevam, linux-imx, devicetree, linux-arm-kernel, linux-kernel,
j.neuschaefer
Cc: Andreas Kemnade
Add backlight for Tolino Shine2 HD. It uses the PWM
of the embedded controller.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 21 ++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts b/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
index 663ee9df79e6..ea0ce59aa4f1 100644
--- a/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
+++ b/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
@@ -18,6 +18,21 @@ / {
model = "Tolino Shine 2 HD";
compatible = "kobo,tolino-shine2hd", "fsl,imx6sl";
+ backlight {
+ compatible = "pwm-backlight";
+ pwms = <&ec 0 50000>;
+ power-supply = <&backlight_regulator>;
+ };
+
+ backlight_regulator: regulator-backlight {
+ compatible = "regulator-fixed";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_backlight_power>;
+ regulator-name = "backlight";
+ gpio = <&gpio2 10 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
chosen {
stdout-path = &uart1;
};
@@ -299,6 +314,12 @@ &iomuxc {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_hog>;
+ pinctrl_backlight_power: backlight-powergrp {
+ fsl,pins = <
+ MX6SL_PAD_EPDC_PWRCTRL3__GPIO2_IO10 0x10059
+ >;
+ };
+
pinctrl_gpio_keys: gpio-keysgrp {
fsl,pins = <
MX6SL_PAD_SD1_DAT1__GPIO5_IO08 0x17059
--
2.30.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: dts: imx6sl-tolino-shine2hd: Add backlight boost
2022-10-19 6:51 ` Andreas Kemnade
@ 2022-10-19 6:51 ` Andreas Kemnade
-1 siblings, 0 replies; 8+ messages in thread
From: Andreas Kemnade @ 2022-10-19 6:51 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer, kernel,
festevam, linux-imx, devicetree, linux-arm-kernel, linux-kernel,
j.neuschaefer
Cc: Andreas Kemnade
Vendor system has a separate checkbox for increasing brightness of the
backlight combined with a big warning that power consumption will
greatly increase. With that checkbox enabled there is a greater range in
which backlight brightness can be adjusted
Add a switch to achieve the same, since the backlight is actually LED,
this seems to be the most appopiate place to add it. Nothing fits
perfectly.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts b/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
index ea0ce59aa4f1..da1399057634 100644
--- a/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
+++ b/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
@@ -80,6 +80,12 @@ led-0 {
gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "timer";
};
+
+ led-1 {
+ label = "tolinoshine2hd:white:backlightboost";
+ gpios = <&gpio1 29 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "off";
+ };
};
memory@80000000 {
@@ -404,7 +410,8 @@ MX6SL_PAD_REF_CLK_32K__I2C3_SDA 0x4001f8b1
pinctrl_led: ledgrp {
fsl,pins = <
- MX6SL_PAD_SD1_DAT2__GPIO5_IO13 0x17059
+ MX6SL_PAD_SD1_DAT2__GPIO5_IO13 0x17059
+ MX6SL_PAD_EPDC_SDCE2__GPIO1_IO29 0x17059
>;
};
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/2] ARM: dts: imx6sl-tolino-shine2hd: Add backlight boost
@ 2022-10-19 6:51 ` Andreas Kemnade
0 siblings, 0 replies; 8+ messages in thread
From: Andreas Kemnade @ 2022-10-19 6:51 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer, kernel,
festevam, linux-imx, devicetree, linux-arm-kernel, linux-kernel,
j.neuschaefer
Cc: Andreas Kemnade
Vendor system has a separate checkbox for increasing brightness of the
backlight combined with a big warning that power consumption will
greatly increase. With that checkbox enabled there is a greater range in
which backlight brightness can be adjusted
Add a switch to achieve the same, since the backlight is actually LED,
this seems to be the most appopiate place to add it. Nothing fits
perfectly.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts b/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
index ea0ce59aa4f1..da1399057634 100644
--- a/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
+++ b/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
@@ -80,6 +80,12 @@ led-0 {
gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "timer";
};
+
+ led-1 {
+ label = "tolinoshine2hd:white:backlightboost";
+ gpios = <&gpio1 29 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "off";
+ };
};
memory@80000000 {
@@ -404,7 +410,8 @@ MX6SL_PAD_REF_CLK_32K__I2C3_SDA 0x4001f8b1
pinctrl_led: ledgrp {
fsl,pins = <
- MX6SL_PAD_SD1_DAT2__GPIO5_IO13 0x17059
+ MX6SL_PAD_SD1_DAT2__GPIO5_IO13 0x17059
+ MX6SL_PAD_EPDC_SDCE2__GPIO1_IO29 0x17059
>;
};
--
2.30.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] ARM: dts: imx6sl-tolino-shine2hd: Add backlight
2022-10-19 6:51 ` Andreas Kemnade
@ 2022-10-29 4:07 ` Shawn Guo
-1 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2022-10-29 4:07 UTC (permalink / raw)
To: Andreas Kemnade
Cc: robh+dt, krzysztof.kozlowski+dt, s.hauer, kernel, festevam,
linux-imx, devicetree, linux-arm-kernel, linux-kernel,
j.neuschaefer
On Wed, Oct 19, 2022 at 08:51:57AM +0200, Andreas Kemnade wrote:
> Add a backlight here, it is a bit special situation. The vendor system
> has an option to add some extra brightness together with a big warning
> that power consumption is increased. Not sure, where it should fit,
> but since the backlight is probably made of leds, this might be the most
> convenient place.
>
> Andreas Kemnade (2):
> ARM: dts: imx6sl-tolino-shine2hd: Add backlight
> ARM: dts: imx6sl-tolino-shine2hd: Add backlight boost
Applied both, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] ARM: dts: imx6sl-tolino-shine2hd: Add backlight
@ 2022-10-29 4:07 ` Shawn Guo
0 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2022-10-29 4:07 UTC (permalink / raw)
To: Andreas Kemnade
Cc: robh+dt, krzysztof.kozlowski+dt, s.hauer, kernel, festevam,
linux-imx, devicetree, linux-arm-kernel, linux-kernel,
j.neuschaefer
On Wed, Oct 19, 2022 at 08:51:57AM +0200, Andreas Kemnade wrote:
> Add a backlight here, it is a bit special situation. The vendor system
> has an option to add some extra brightness together with a big warning
> that power consumption is increased. Not sure, where it should fit,
> but since the backlight is probably made of leds, this might be the most
> convenient place.
>
> Andreas Kemnade (2):
> ARM: dts: imx6sl-tolino-shine2hd: Add backlight
> ARM: dts: imx6sl-tolino-shine2hd: Add backlight boost
Applied both, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread