All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Alistair Francis <alistair@alistair23.me>
Cc: kernel@pengutronix.de, robh+dt@kernel.org, lgirdwood@gmail.com,
	lee.jones@linaro.org, broonie@kernel.org,
	linux-arm-kernel@lists.infradead.org, rui.zhang@intel.com,
	s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
	geert@linux-m68k.org, linux-pm@vger.kernel.org,
	andreas@kemnade.info, amitk@kernel.org,
	linux-hwmon@vger.kernel.org, alistair23@gmail.com,
	devicetree@vger.kernel.org, linux@roeck-us.net,
	linux-imx@nxp.com
Subject: Re: [PATCH v22 2/2] ARM: dts: imx7d-remarkable2: Enable silergy,sy7636a
Date: Sat, 29 Oct 2022 16:52:04 +0800	[thread overview]
Message-ID: <20221029085204.GU125525@dragon> (raw)
In-Reply-To: <20221024105853.42029-3-alistair@alistair23.me>

On Mon, Oct 24, 2022 at 08:58:53PM +1000, Alistair Francis wrote:
> Enable the silergy,sy7636a and silergy,sy7636a-regulator on the
> reMarkable2.
> 
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
>  arch/arm/boot/dts/imx7d-remarkable2.dts | 62 +++++++++++++++++++++++++
>  1 file changed, 62 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts
> index a2a91bfdd98e..99ac0d242936 100644
> --- a/arch/arm/boot/dts/imx7d-remarkable2.dts
> +++ b/arch/arm/boot/dts/imx7d-remarkable2.dts
> @@ -22,6 +22,27 @@ memory@80000000 {
>  		reg = <0x80000000 0x40000000>;
>  	};
>  
> +	thermal-zones {
> +		epd-thermal {
> +			thermal-sensors = <&epd_pmic>;
> +			polling-delay-passive = <30000>;
> +			polling-delay = <30000>;

Have a newline between properties and child node.

> +			trips {
> +				trip0 {
> +					temperature = <49000>;
> +					hysteresis = <2000>;
> +					type = "passive";
> +				};
> +
> +				trip1 {
> +					temperature = <50000>;
> +					hysteresis = <2000>;
> +					type = "critical";
> +				};
> +			};
> +		};
> +	};
> +
>  	reg_brcm: regulator-brcm {
>  		compatible = "regulator-fixed";
>  		regulator-name = "brcm_reg";
> @@ -84,6 +105,33 @@ wacom_digitizer: digitizer@9 {
>  	};
>  };
>  
> +&i2c4 {
> +	clock-frequency = <100000>;
> +	pinctrl-names = "default", "sleep";
> +	pinctrl-0 = <&pinctrl_i2c4>;
> +	pinctrl-1 = <&pinctrl_i2c4>;
> +	status = "okay";
> +
> +	epd_pmic: sy7636a@62 {

Node name should be generic while label could be specific, so maybe:

	sy7636a: pmic@62 {

> +		compatible = "silergy,sy7636a";
> +		reg = <0x62>;
> +		status = "okay";

We usually end property list with `status`.

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_epdpmic>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		#thermal-sensor-cells = <0>;
> +

Move this newline one line below.

> +		epd-pwr-good-gpios = <&gpio6 21 GPIO_ACTIVE_HIGH>;
> +		regulators {
> +			reg_epdpmic: vcom {
> +				regulator-name = "vcom";
> +				regulator-boot-on;
> +			};
> +		};
> +	};
> +};
> +
>  &snvs_pwrkey {
>  	status = "okay";
>  };
> @@ -177,6 +225,13 @@ MX7D_PAD_SAI1_TX_BCLK__GPIO6_IO13	0x14
>  		>;
>  	};
>  
> +	pinctrl_epdpmic: epdpmicgrp {
> +		fsl,pins = <
> +			MX7D_PAD_SAI2_RX_DATA__GPIO6_IO21 0x00000074
> +			MX7D_PAD_ENET1_RGMII_TXC__GPIO7_IO11 0x00000014

You might want to align hex values like other pinctrl nodes?

Shawn

> +		>;
> +	};
> +
>  	pinctrl_i2c1: i2c1grp {
>  		fsl,pins = <
>  			MX7D_PAD_I2C1_SDA__I2C1_SDA		0x4000007f
> @@ -184,6 +239,13 @@ MX7D_PAD_I2C1_SCL__I2C1_SCL		0x4000007f
>  		>;
>  	};
>  
> +	pinctrl_i2c4: i2c4grp {
> +		fsl,pins = <
> +			MX7D_PAD_I2C4_SDA__I2C4_SDA		0x4000007f
> +			MX7D_PAD_I2C4_SCL__I2C4_SCL		0x4000007f
> +		>;
> +	};
> +
>  	pinctrl_uart1: uart1grp {
>  		fsl,pins = <
>  			MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX	0x79
> -- 
> 2.37.3
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Alistair Francis <alistair@alistair23.me>
Cc: kernel@pengutronix.de, robh+dt@kernel.org, lgirdwood@gmail.com,
	lee.jones@linaro.org, broonie@kernel.org,
	linux-arm-kernel@lists.infradead.org, rui.zhang@intel.com,
	s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
	geert@linux-m68k.org, linux-pm@vger.kernel.org,
	andreas@kemnade.info, amitk@kernel.org,
	linux-hwmon@vger.kernel.org, alistair23@gmail.com,
	devicetree@vger.kernel.org, linux@roeck-us.net,
	linux-imx@nxp.com
Subject: Re: [PATCH v22 2/2] ARM: dts: imx7d-remarkable2: Enable silergy,sy7636a
Date: Sat, 29 Oct 2022 16:52:04 +0800	[thread overview]
Message-ID: <20221029085204.GU125525@dragon> (raw)
In-Reply-To: <20221024105853.42029-3-alistair@alistair23.me>

On Mon, Oct 24, 2022 at 08:58:53PM +1000, Alistair Francis wrote:
> Enable the silergy,sy7636a and silergy,sy7636a-regulator on the
> reMarkable2.
> 
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
>  arch/arm/boot/dts/imx7d-remarkable2.dts | 62 +++++++++++++++++++++++++
>  1 file changed, 62 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts
> index a2a91bfdd98e..99ac0d242936 100644
> --- a/arch/arm/boot/dts/imx7d-remarkable2.dts
> +++ b/arch/arm/boot/dts/imx7d-remarkable2.dts
> @@ -22,6 +22,27 @@ memory@80000000 {
>  		reg = <0x80000000 0x40000000>;
>  	};
>  
> +	thermal-zones {
> +		epd-thermal {
> +			thermal-sensors = <&epd_pmic>;
> +			polling-delay-passive = <30000>;
> +			polling-delay = <30000>;

Have a newline between properties and child node.

> +			trips {
> +				trip0 {
> +					temperature = <49000>;
> +					hysteresis = <2000>;
> +					type = "passive";
> +				};
> +
> +				trip1 {
> +					temperature = <50000>;
> +					hysteresis = <2000>;
> +					type = "critical";
> +				};
> +			};
> +		};
> +	};
> +
>  	reg_brcm: regulator-brcm {
>  		compatible = "regulator-fixed";
>  		regulator-name = "brcm_reg";
> @@ -84,6 +105,33 @@ wacom_digitizer: digitizer@9 {
>  	};
>  };
>  
> +&i2c4 {
> +	clock-frequency = <100000>;
> +	pinctrl-names = "default", "sleep";
> +	pinctrl-0 = <&pinctrl_i2c4>;
> +	pinctrl-1 = <&pinctrl_i2c4>;
> +	status = "okay";
> +
> +	epd_pmic: sy7636a@62 {

Node name should be generic while label could be specific, so maybe:

	sy7636a: pmic@62 {

> +		compatible = "silergy,sy7636a";
> +		reg = <0x62>;
> +		status = "okay";

We usually end property list with `status`.

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_epdpmic>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		#thermal-sensor-cells = <0>;
> +

Move this newline one line below.

> +		epd-pwr-good-gpios = <&gpio6 21 GPIO_ACTIVE_HIGH>;
> +		regulators {
> +			reg_epdpmic: vcom {
> +				regulator-name = "vcom";
> +				regulator-boot-on;
> +			};
> +		};
> +	};
> +};
> +
>  &snvs_pwrkey {
>  	status = "okay";
>  };
> @@ -177,6 +225,13 @@ MX7D_PAD_SAI1_TX_BCLK__GPIO6_IO13	0x14
>  		>;
>  	};
>  
> +	pinctrl_epdpmic: epdpmicgrp {
> +		fsl,pins = <
> +			MX7D_PAD_SAI2_RX_DATA__GPIO6_IO21 0x00000074
> +			MX7D_PAD_ENET1_RGMII_TXC__GPIO7_IO11 0x00000014

You might want to align hex values like other pinctrl nodes?

Shawn

> +		>;
> +	};
> +
>  	pinctrl_i2c1: i2c1grp {
>  		fsl,pins = <
>  			MX7D_PAD_I2C1_SDA__I2C1_SDA		0x4000007f
> @@ -184,6 +239,13 @@ MX7D_PAD_I2C1_SCL__I2C1_SCL		0x4000007f
>  		>;
>  	};
>  
> +	pinctrl_i2c4: i2c4grp {
> +		fsl,pins = <
> +			MX7D_PAD_I2C4_SDA__I2C4_SDA		0x4000007f
> +			MX7D_PAD_I2C4_SCL__I2C4_SCL		0x4000007f
> +		>;
> +	};
> +
>  	pinctrl_uart1: uart1grp {
>  		fsl,pins = <
>  			MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX	0x79
> -- 
> 2.37.3
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-10-29  8:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24 10:58 [PATCH v22 0/2] Add support for the silergy,sy7636a Alistair Francis
2022-10-24 10:58 ` Alistair Francis
2022-10-24 10:58 ` [PATCH v22 1/2] ARM: imx_v6_v7_defconfig: Enable silergy,sy7636a Alistair Francis
2022-10-24 10:58   ` Alistair Francis
2022-10-24 10:58 ` [PATCH v22 2/2] ARM: dts: imx7d-remarkable2: " Alistair Francis
2022-10-24 10:58   ` Alistair Francis
2022-10-29  8:52   ` Shawn Guo [this message]
2022-10-29  8:52     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221029085204.GU125525@dragon \
    --to=shawnguo@kernel.org \
    --cc=alistair23@gmail.com \
    --cc=alistair@alistair23.me \
    --cc=amitk@kernel.org \
    --cc=andreas@kemnade.info \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=kernel@pengutronix.de \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.