All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/iwd: set dbus busdir
@ 2022-10-31  1:09 James Hilliard
  2022-10-31  8:17 ` Yann E. MORIN
  0 siblings, 1 reply; 3+ messages in thread
From: James Hilliard @ 2022-10-31  1:09 UTC (permalink / raw)
  To: buildroot; +Cc: James Hilliard

In 5b3b2d80f4cf586d360ff696c3dacbd4cb48fdc4 we dropped dbus as a build
dependency, as such we also need to set --with-dbus-busdir which would
otherwise be pulled via pkg-config.

Fixes:
checking D-Bus bus services directory... configure: error: D-Bus bus services directory is required

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/iwd/iwd.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/iwd/iwd.mk b/package/iwd/iwd.mk
index 002988cf33..e53ae595d7 100644
--- a/package/iwd/iwd.mk
+++ b/package/iwd/iwd.mk
@@ -17,7 +17,8 @@ IWD_CONF_OPTS = \
 	--disable-manual-pages \
 	--enable-external-ell \
 	--enable-dbus-policy \
-	--with-dbus-datadir=/usr/share
+	--with-dbus-datadir=/usr/share \
+	--with-dbus-busdir=/usr/share/dbus-1/system-services
 IWD_DEPENDENCIES = ell
 
 ifeq ($(BR2_PACKAGE_READLINE),y)
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/iwd: set dbus busdir
  2022-10-31  1:09 [Buildroot] [PATCH 1/1] package/iwd: set dbus busdir James Hilliard
@ 2022-10-31  8:17 ` Yann E. MORIN
  2022-10-31 16:15   ` James Hilliard
  0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2022-10-31  8:17 UTC (permalink / raw)
  To: James Hilliard; +Cc: Daniel Lang, buildroot

James, All,

+Daniel

On 2022-10-30 19:09 -0600, James Hilliard spake thusly:
> In 5b3b2d80f4cf586d360ff696c3dacbd4cb48fdc4 we dropped dbus as a build
> dependency, as such we also need to set --with-dbus-busdir which would
> otherwise be pulled via pkg-config.
> 
> Fixes:
> checking D-Bus bus services directory... configure: error: D-Bus bus services directory is required

I was surprised that I did not have this error locally, but it only
happens when systemd is enabled.

So, rather than hard-code the path, I think I would prefer we add back a
buid dependency on dbus when systemd is enabled:

    diff --git a/package/iwd/iwd.mk b/package/iwd/iwd.mk
    index 002988cf33..6e366e094d 100644
    --- a/package/iwd/iwd.mk
    +++ b/package/iwd/iwd.mk
    @@ -31,7 +31,8 @@ endif
    
     ifeq ($(BR2_PACKAGE_SYSTEMD),y)
     IWD_CONF_OPTS += --enable-systemd-service
    -IWD_DEPENDENCIES += systemd
    +# Need dbus for system_bus_services_dir variable provided by dbus' .pc
    +IWD_DEPENDENCIES += dbus systemd
     else
     IWD_CONF_OPTS += --disable-systemd-service
     endif

Regards,
Yann E. MORIN.

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/iwd/iwd.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/iwd/iwd.mk b/package/iwd/iwd.mk
> index 002988cf33..e53ae595d7 100644
> --- a/package/iwd/iwd.mk
> +++ b/package/iwd/iwd.mk
> @@ -17,7 +17,8 @@ IWD_CONF_OPTS = \
>  	--disable-manual-pages \
>  	--enable-external-ell \
>  	--enable-dbus-policy \
> -	--with-dbus-datadir=/usr/share
> +	--with-dbus-datadir=/usr/share \
> +	--with-dbus-busdir=/usr/share/dbus-1/system-services
>  IWD_DEPENDENCIES = ell
>  
>  ifeq ($(BR2_PACKAGE_READLINE),y)
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/iwd: set dbus busdir
  2022-10-31  8:17 ` Yann E. MORIN
@ 2022-10-31 16:15   ` James Hilliard
  0 siblings, 0 replies; 3+ messages in thread
From: James Hilliard @ 2022-10-31 16:15 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: Daniel Lang, buildroot

On Mon, Oct 31, 2022 at 4:17 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> James, All,
>
> +Daniel
>
> On 2022-10-30 19:09 -0600, James Hilliard spake thusly:
> > In 5b3b2d80f4cf586d360ff696c3dacbd4cb48fdc4 we dropped dbus as a build
> > dependency, as such we also need to set --with-dbus-busdir which would
> > otherwise be pulled via pkg-config.
> >
> > Fixes:
> > checking D-Bus bus services directory... configure: error: D-Bus bus services directory is required
>
> I was surprised that I did not have this error locally, but it only
> happens when systemd is enabled.
>
> So, rather than hard-code the path, I think I would prefer we add back a
> buid dependency on dbus when systemd is enabled:
>
>     diff --git a/package/iwd/iwd.mk b/package/iwd/iwd.mk
>     index 002988cf33..6e366e094d 100644
>     --- a/package/iwd/iwd.mk
>     +++ b/package/iwd/iwd.mk
>     @@ -31,7 +31,8 @@ endif
>
>      ifeq ($(BR2_PACKAGE_SYSTEMD),y)
>      IWD_CONF_OPTS += --enable-systemd-service
>     -IWD_DEPENDENCIES += systemd
>     +# Need dbus for system_bus_services_dir variable provided by dbus' .pc
>     +IWD_DEPENDENCIES += dbus systemd
>      else
>      IWD_CONF_OPTS += --disable-systemd-service
>      endif

Sent as suggested in v2 patch:
https://patchwork.ozlabs.org/project/buildroot/patch/20221031161451.2604400-1-james.hilliard1@gmail.com/

>
> Regards,
> Yann E. MORIN.
>
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> >  package/iwd/iwd.mk | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/package/iwd/iwd.mk b/package/iwd/iwd.mk
> > index 002988cf33..e53ae595d7 100644
> > --- a/package/iwd/iwd.mk
> > +++ b/package/iwd/iwd.mk
> > @@ -17,7 +17,8 @@ IWD_CONF_OPTS = \
> >       --disable-manual-pages \
> >       --enable-external-ell \
> >       --enable-dbus-policy \
> > -     --with-dbus-datadir=/usr/share
> > +     --with-dbus-datadir=/usr/share \
> > +     --with-dbus-busdir=/usr/share/dbus-1/system-services
> >  IWD_DEPENDENCIES = ell
> >
> >  ifeq ($(BR2_PACKAGE_READLINE),y)
> > --
> > 2.34.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-31 16:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-31  1:09 [Buildroot] [PATCH 1/1] package/iwd: set dbus busdir James Hilliard
2022-10-31  8:17 ` Yann E. MORIN
2022-10-31 16:15   ` James Hilliard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.