[Buildroot] [PATCH 1/1] support/config-fragments/autobuild: fix bootlin-xtensa-uclibc.config

[Buildroot] [PATCH 1/1] support/config-fragments/autobuild: fix bootlin-xtensa-uclibc.config

[Julien Olivain]

Commit 4cbf7336914f25478aea943456ba7dc3c892c21a
"arch/xtensa: custom configuration requires an overlay"
added an error message if BR2_XTENSA_CUSTOM is set and
BR_ARCH_XTENSA_OVERLAY_FILE is unset.

When testing a package with the command:

    ./utils/test-pkg --all --package somepackage

bootlin-xtensa-uclibc toolchain is always failing with error in the logfile:

    arch/arch.mk.xtensa:4: *** No xtensa overlay file provided. Check your BR2_XTENSA_OVERLAY_FILE setting.  Stop.

This commit fixes the toolchain config fragment by adding the same overlay
file found in qemu_xtensa_lx60_defconfig.

Signed-off-by: Julien Olivain <ju.o@free.fr>
---
 support/config-fragments/autobuild/bootlin-xtensa-uclibc.config | 1 +
 1 file changed, 1 insertion(+)

diff --git a/support/config-fragments/autobuild/bootlin-xtensa-uclibc.config b/support/config-fragments/autobuild/bootlin-xtensa-uclibc.config
index c44525b203..780a41df47 100644
--- a/support/config-fragments/autobuild/bootlin-xtensa-uclibc.config
+++ b/support/config-fragments/autobuild/bootlin-xtensa-uclibc.config
@@ -1,5 +1,6 @@
 BR2_xtensa=y
 BR2_XTENSA_CUSTOM=y
 BR2_XTENSA_LITTLE_ENDIAN=y
+BR2_XTENSA_OVERLAY_FILE="https://github.com/jcmvbkbc/xtensa-toolchain-build/raw/95291b7c39e6f790d0b2f062c945a630290f2c81/overlays/xtensa_dc233c.tar.gz"
 BR2_TOOLCHAIN_EXTERNAL=y
 BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_XTENSA_LX60_UCLIBC_STABLE=y
-- 
2.37.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] support/config-fragments/autobuild: fix bootlin-xtensa-uclibc.config

[Thomas Petazzoni via buildroot]

Hello Julien,

On Sun,  9 Oct 2022 23:09:37 -0400
Julien Olivain <ju.o@free.fr> wrote:

> Commit 4cbf7336914f25478aea943456ba7dc3c892c21a
> "arch/xtensa: custom configuration requires an overlay"
> added an error message if BR2_XTENSA_CUSTOM is set and
> BR_ARCH_XTENSA_OVERLAY_FILE is unset.
> 
> When testing a package with the command:
> 
>     ./utils/test-pkg --all --package somepackage
> 
> bootlin-xtensa-uclibc toolchain is always failing with error in the logfile:
> 
>     arch/arch.mk.xtensa:4: *** No xtensa overlay file provided. Check your BR2_XTENSA_OVERLAY_FILE setting.  Stop.
> 
> This commit fixes the toolchain config fragment by adding the same overlay
> file found in qemu_xtensa_lx60_defconfig.
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
>  support/config-fragments/autobuild/bootlin-xtensa-uclibc.config | 1 +
>  1 file changed, 1 insertion(+)

Thanks, but adding an overlay here is not the right solution. The
problem is that 4cbf7336914f25478aea943456ba7dc3c892c21a is incorrect.
I already sent a series to fix that on Sep 25, 2022:

  https://lore.kernel.org/buildroot/20220925090920.1585682-1-thomas.petazzoni@bootlin.com/

but it did receive some comments, and therefore was not applied. But
the solution is more along the lines of changing how Xtensa is handled
rather than working around the problem in bootlin-xtensa-uclibc.config.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot