[PATCH RESEND] bus: mhi: host: pci_generic: Add HP variant of T99W175

[PATCH RESEND] bus: mhi: host: pci_generic: Add HP variant of T99W175

[Song Fuchang]

The foxconn T99W175 has an HP variant, so add support for it to the
pci_generic driver.

Signed-off-by: Song Fuchang<song.fc@gmail.com>
---
  drivers/bus/mhi/host/pci_generic.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/bus/mhi/host/pci_generic.c
b/drivers/bus/mhi/host/pci_generic.c
index 9e545f2a5a26..650e8b9c26ad 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -592,6 +592,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
      /* MV32-WB (Cinterion) */
      { PCI_DEVICE(0x1269, 0x00bb),
          .driver_data = (kernel_ulong_t) &mhi_mv32_info },
+    /* T99W175 (sdx55), HP variant */
+    { PCI_DEVICE(0x03f0, 0x0a6c),
+        .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
      {  }
  };
  MODULE_DEVICE_TABLE(pci, mhi_pci_id_table);
-- 2.37.3

Re: [PATCH RESEND] bus: mhi: host: pci_generic: Add HP variant of T99W175

[Manivannan Sadhasivam]

On Sun, Oct 09, 2022 at 11:34:39AM +0800, Song Fuchang wrote:
> The foxconn T99W175 has an HP variant, so add support for it to the
> pci_generic driver.
> 
> Signed-off-by: Song Fuchang<song.fc@gmail.com>
> ---
>  drivers/bus/mhi/host/pci_generic.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c
> b/drivers/bus/mhi/host/pci_generic.c
> index 9e545f2a5a26..650e8b9c26ad 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -592,6 +592,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>      /* MV32-WB (Cinterion) */
>      { PCI_DEVICE(0x1269, 0x00bb),
>          .driver_data = (kernel_ulong_t) &mhi_mv32_info },
> +    /* T99W175 (sdx55), HP variant */
> +    { PCI_DEVICE(0x03f0, 0x0a6c),

Why a new VID for this modem? Other T99W series modems are using PCI_VENDOR_ID_FOXCONN.

Thanks,
Mani

> +        .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
>      {  }
>  };
>  MODULE_DEVICE_TABLE(pci, mhi_pci_id_table);
> -- 2.37.3
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH RESEND] bus: mhi: host: pci_generic: Add HP variant of T99W175

[Song Fuchang]

Hello, this modem is really a T99W175, but the vendor id 03f0 is for HP 
Inc. It also has some HP-specific serial numbers printed on its case.

Output of lspci for this modem:

01:00.0 Wireless controller [0d40]: Device 03f0:0a6c

I don't know why the HP's variant uses a different VID, maybe some 
business decisions? Though it works well with this driver on my laptop.

Thanks!

在 2022/10/29 01:27, Manivannan Sadhasivam 写道:
> On Sun, Oct 09, 2022 at 11:34:39AM +0800, Song Fuchang wrote:
>> The foxconn T99W175 has an HP variant, so add support for it to the
>> pci_generic driver.
>>
>> Signed-off-by: Song Fuchang<song.fc@gmail.com>
>> ---
>>   drivers/bus/mhi/host/pci_generic.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/bus/mhi/host/pci_generic.c
>> b/drivers/bus/mhi/host/pci_generic.c
>> index 9e545f2a5a26..650e8b9c26ad 100644
>> --- a/drivers/bus/mhi/host/pci_generic.c
>> +++ b/drivers/bus/mhi/host/pci_generic.c
>> @@ -592,6 +592,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>>       /* MV32-WB (Cinterion) */
>>       { PCI_DEVICE(0x1269, 0x00bb),
>>           .driver_data = (kernel_ulong_t) &mhi_mv32_info },
>> +    /* T99W175 (sdx55), HP variant */
>> +    { PCI_DEVICE(0x03f0, 0x0a6c),
> Why a new VID for this modem? Other T99W series modems are using PCI_VENDOR_ID_FOXCONN.
>
> Thanks,
> Mani
>
>> +        .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
>>       {  }
>>   };
>>   MODULE_DEVICE_TABLE(pci, mhi_pci_id_table);
>> -- 2.37.3
>>

Re: [PATCH RESEND] bus: mhi: host: pci_generic: Add HP variant of T99W175

[Manivannan Sadhasivam]

On Sat, Oct 29, 2022 at 09:19:46PM +0800, Song Fuchang wrote:
> Hello, this modem is really a T99W175, but the vendor id 03f0 is for HP Inc.
> It also has some HP-specific serial numbers printed on its case.
> 
> Output of lspci for this modem:
> 
> 01:00.0 Wireless controller [0d40]: Device 03f0:0a6c
> 
> I don't know why the HP's variant uses a different VID, maybe some business
> decisions? Though it works well with this driver on my laptop.
> 

Okay, thanks for the clarification. Could you please add these info to the
commit message for the record?

Thanks,
Mani

> Thanks!
> 
> 在 2022/10/29 01:27, Manivannan Sadhasivam 写道:
> > On Sun, Oct 09, 2022 at 11:34:39AM +0800, Song Fuchang wrote:
> > > The foxconn T99W175 has an HP variant, so add support for it to the
> > > pci_generic driver.
> > > 
> > > Signed-off-by: Song Fuchang<song.fc@gmail.com>
> > > ---
> > >   drivers/bus/mhi/host/pci_generic.c | 3 +++
> > >   1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/drivers/bus/mhi/host/pci_generic.c
> > > b/drivers/bus/mhi/host/pci_generic.c
> > > index 9e545f2a5a26..650e8b9c26ad 100644
> > > --- a/drivers/bus/mhi/host/pci_generic.c
> > > +++ b/drivers/bus/mhi/host/pci_generic.c
> > > @@ -592,6 +592,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> > >       /* MV32-WB (Cinterion) */
> > >       { PCI_DEVICE(0x1269, 0x00bb),
> > >           .driver_data = (kernel_ulong_t) &mhi_mv32_info },
> > > +    /* T99W175 (sdx55), HP variant */
> > > +    { PCI_DEVICE(0x03f0, 0x0a6c),
> > Why a new VID for this modem? Other T99W series modems are using PCI_VENDOR_ID_FOXCONN.
> > 
> > Thanks,
> > Mani
> > 
> > > +        .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> > >       {  }
> > >   };
> > >   MODULE_DEVICE_TABLE(pci, mhi_pci_id_table);
> > > -- 2.37.3
> > > 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH RESEND] bus: mhi: host: pci_generic: Add HP variant of T99W175

[Song Fuchang]

在 2022/11/1 19:44, Manivannan Sadhasivam 写道:

> On Sat, Oct 29, 2022 at 09:19:46PM +0800, Song Fuchang wrote:
>> Hello, this modem is really a T99W175, but the vendor id 03f0 is for HP Inc.
>> It also has some HP-specific serial numbers printed on its case.
>>
>> Output of lspci for this modem:
>>
>> 01:00.0 Wireless controller [0d40]: Device 03f0:0a6c
>>
>> I don't know why the HP's variant uses a different VID, maybe some business
>> decisions? Though it works well with this driver on my laptop.
>>
> Okay, thanks for the clarification. Could you please add these info to the
> commit message for the record?

Sure, I will send a v2 patch with detailed commit message.

> Thanks,
> Mani
>
>> Thanks!
>>
>> 在 2022/10/29 01:27, Manivannan Sadhasivam 写道:
>>> On Sun, Oct 09, 2022 at 11:34:39AM +0800, Song Fuchang wrote:
>>>> The foxconn T99W175 has an HP variant, so add support for it to the
>>>> pci_generic driver.
>>>>
>>>> Signed-off-by: Song Fuchang<song.fc@gmail.com>
>>>> ---
>>>>    drivers/bus/mhi/host/pci_generic.c | 3 +++
>>>>    1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/drivers/bus/mhi/host/pci_generic.c
>>>> b/drivers/bus/mhi/host/pci_generic.c
>>>> index 9e545f2a5a26..650e8b9c26ad 100644
>>>> --- a/drivers/bus/mhi/host/pci_generic.c
>>>> +++ b/drivers/bus/mhi/host/pci_generic.c
>>>> @@ -592,6 +592,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>>>>        /* MV32-WB (Cinterion) */
>>>>        { PCI_DEVICE(0x1269, 0x00bb),
>>>>            .driver_data = (kernel_ulong_t) &mhi_mv32_info },
>>>> +    /* T99W175 (sdx55), HP variant */
>>>> +    { PCI_DEVICE(0x03f0, 0x0a6c),
>>> Why a new VID for this modem? Other T99W series modems are using PCI_VENDOR_ID_FOXCONN.
>>>
>>> Thanks,
>>> Mani
>>>
>>>> +        .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
>>>>        {  }
>>>>    };
>>>>    MODULE_DEVICE_TABLE(pci, mhi_pci_id_table);
>>>> -- 2.37.3
>>>>