All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Cc: arnd@kernel.org, airlied@linux.ie, trix@redhat.com,
	dlatypov@google.com, llvm@lists.linux.dev,
	ndesaulniers@google.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, gustavoars@kernel.org,
	nathan@kernel.org, linux-sparse@vger.kernel.org,
	linux-hardening@vger.kernel.org, rodrigo.vivi@intel.com,
	mchehab@kernel.org, intel-gfx@lists.freedesktop.org,
	luc.vanoostenryck@gmail.com, vitor@massaru.org
Subject: Re: [Intel-gfx] [PATCH v5] overflow: Introduce overflows_type() and castable_to_type()
Date: Tue, 1 Nov 2022 16:06:12 -0700	[thread overview]
Message-ID: <202211011605.2D8C927C2@keescook> (raw)
In-Reply-To: <850085e1-e420-b6eb-104d-15694a400bb7@intel.com>

On Sat, Oct 29, 2022 at 11:01:38AM +0300, Gwan-gyeong Mun wrote:
> 
> 
> On 10/29/22 10:32 AM, Kees Cook wrote:
> > On Sat, Oct 29, 2022 at 08:55:43AM +0300, Gwan-gyeong Mun wrote:
> > > Hi Kees,
> > 
> > Hi! :)
> > 
> > > I've updated to v5 with the last comment of Nathan.
> > > Could you please kindly review what more is needed as we move forward with
> > > this patch?
> > 
> > It looks fine to me -- I assume it'll go via the drm tree? Would you
> > rather I carry the non-drm changes in my tree instead?
> > 
> Hi!
> Yes, I think it would be better to run this patch on your tree.
> this patch moves the macro of i915 to overflows.h and modifies one part of
> drm's driver code, but I think this part can be easily applied when merging
> into the drm tree.

I've rebased it to the hardening tree, and it should appear in -next
shortly:

https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?h=for-next/hardening&id=5904fcb776d0b518be96bca43f258db90f26ba9a

-- 
Kees Cook

WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Cc: arnd@kernel.org, mauro.chehab@linux.intel.com,
	tvrtko.ursulin@linux.intel.com, airlied@linux.ie,
	trix@redhat.com, dlatypov@google.com, llvm@lists.linux.dev,
	ndesaulniers@google.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, gustavoars@kernel.org,
	nathan@kernel.org, linux-sparse@vger.kernel.org,
	linux-hardening@vger.kernel.org, rodrigo.vivi@intel.com,
	mchehab@kernel.org, intel-gfx@lists.freedesktop.org,
	luc.vanoostenryck@gmail.com, vitor@massaru.org
Subject: Re: [PATCH v5] overflow: Introduce overflows_type() and castable_to_type()
Date: Tue, 1 Nov 2022 16:06:12 -0700	[thread overview]
Message-ID: <202211011605.2D8C927C2@keescook> (raw)
In-Reply-To: <850085e1-e420-b6eb-104d-15694a400bb7@intel.com>

On Sat, Oct 29, 2022 at 11:01:38AM +0300, Gwan-gyeong Mun wrote:
> 
> 
> On 10/29/22 10:32 AM, Kees Cook wrote:
> > On Sat, Oct 29, 2022 at 08:55:43AM +0300, Gwan-gyeong Mun wrote:
> > > Hi Kees,
> > 
> > Hi! :)
> > 
> > > I've updated to v5 with the last comment of Nathan.
> > > Could you please kindly review what more is needed as we move forward with
> > > this patch?
> > 
> > It looks fine to me -- I assume it'll go via the drm tree? Would you
> > rather I carry the non-drm changes in my tree instead?
> > 
> Hi!
> Yes, I think it would be better to run this patch on your tree.
> this patch moves the macro of i915 to overflows.h and modifies one part of
> drm's driver code, but I think this part can be easily applied when merging
> into the drm tree.

I've rebased it to the hardening tree, and it should appear in -next
shortly:

https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?h=for-next/hardening&id=5904fcb776d0b518be96bca43f258db90f26ba9a

-- 
Kees Cook

  reply	other threads:[~2022-11-01 23:06 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26 19:11 [Intel-gfx] [PATCH v2] overflow: Introduce overflows_type() and castable_to_type() Kees Cook
2022-09-26 19:11 ` Kees Cook
2022-09-26 19:11 ` Kees Cook
2022-09-26 20:17 ` [Intel-gfx] " Nick Desaulniers
2022-09-26 20:17   ` Nick Desaulniers
2022-09-26 20:17   ` Nick Desaulniers
2022-09-26 21:07   ` [Intel-gfx] " Kees Cook
2022-09-26 21:07     ` Kees Cook
2022-09-26 21:07     ` Kees Cook
2022-09-27  6:45     ` [Intel-gfx] " Arnd Bergmann
2022-09-27  6:45       ` Arnd Bergmann
2022-09-27  6:45       ` Arnd Bergmann
2022-09-27  0:27 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
2022-09-27  8:29 ` [Intel-gfx] [PATCH v2] " Gwan-gyeong Mun
2022-09-27  8:29   ` Gwan-gyeong Mun
2022-09-27  8:29   ` Gwan-gyeong Mun
2022-09-27 23:36 ` [Intel-gfx] " kernel test robot
2022-09-27 23:36   ` kernel test robot
2022-09-27 23:36   ` kernel test robot
2022-09-28  8:19 ` Gwan-gyeong Mun
2022-09-28  8:19   ` Gwan-gyeong Mun
2022-09-28  8:19   ` Gwan-gyeong Mun
2022-09-29  3:24 ` [Intel-gfx] " kernel test robot
2022-09-29  3:24   ` kernel test robot
2022-09-29  3:24   ` kernel test robot
2022-09-29  8:32 ` kernel test robot
2022-09-29  8:32   ` kernel test robot
2022-09-29  8:32   ` kernel test robot
2022-10-13  6:49 ` [Intel-gfx] [PATCH v3] " Gwan-gyeong Mun
2022-10-13  6:49   ` Gwan-gyeong Mun
2022-10-13  6:49   ` Gwan-gyeong Mun
2022-10-13  8:12   ` [Intel-gfx] " Jani Nikula
2022-10-13  8:12     ` Jani Nikula
2022-10-13  8:12     ` Jani Nikula
2022-10-13  8:17 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for overflow: Introduce overflows_type() and castable_to_type() (rev2) Patchwork
2022-10-21  8:33 ` [Intel-gfx] [PATCH v4] overflow: Introduce overflows_type() and castable_to_type() Gwan-gyeong Mun
2022-10-21  8:33   ` Gwan-gyeong Mun
2022-10-21  8:33   ` Gwan-gyeong Mun
2022-10-21 16:06   ` [Intel-gfx] " Nathan Chancellor
2022-10-21 16:06     ` Nathan Chancellor
2022-10-21 16:06     ` Nathan Chancellor
2022-10-21 12:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for overflow: Introduce overflows_type() and castable_to_type() (rev3) Patchwork
2022-10-21 12:29 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-10-21 12:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-21 19:46 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-24 20:11 ` [Intel-gfx] [PATCH v5] overflow: Introduce overflows_type() and castable_to_type() Gwan-gyeong Mun
2022-10-24 20:11   ` Gwan-gyeong Mun
2022-10-24 20:11   ` Gwan-gyeong Mun
2022-10-29  5:55   ` [Intel-gfx] " Gwan-gyeong Mun
2022-10-29  5:55     ` Gwan-gyeong Mun
2022-10-29  5:55     ` Gwan-gyeong Mun
2022-10-29  7:32     ` [Intel-gfx] " Kees Cook
2022-10-29  7:32       ` Kees Cook
2022-10-29  7:32       ` Kees Cook
2022-10-29  8:01       ` [Intel-gfx] " Gwan-gyeong Mun
2022-10-29  8:01         ` Gwan-gyeong Mun
2022-10-29  8:01         ` Gwan-gyeong Mun
2022-11-01 23:06         ` Kees Cook [this message]
2022-11-01 23:06           ` Kees Cook
2022-11-02 11:27           ` [Intel-gfx] " Gwan-gyeong Mun
2022-11-02 11:27             ` Gwan-gyeong Mun
2022-11-02 11:27             ` Gwan-gyeong Mun
2022-11-02 11:52   ` [Intel-gfx] " Rasmus Villemoes
2022-11-02 11:52     ` Rasmus Villemoes
2022-11-02 11:52     ` Rasmus Villemoes
2022-11-02 19:33     ` [Intel-gfx] " Kees Cook
2022-11-02 19:33       ` Kees Cook
2022-11-02 19:33       ` Kees Cook
2022-10-25  0:31 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for overflow: Introduce overflows_type() and castable_to_type() (rev4) Patchwork
2022-10-25  0:31 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-10-25  0:53 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202211011605.2D8C927C2@keescook \
    --to=keescook@chromium.org \
    --cc=airlied@linux.ie \
    --cc=arnd@kernel.org \
    --cc=dlatypov@google.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavoars@kernel.org \
    --cc=gwan-gyeong.mun@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=trix@redhat.com \
    --cc=vitor@massaru.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.