Re: [PATCH v10 0/2] vhost-vdpa: add support for vIOMMU

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Nov 02, 2022 at 06:39:11AM -0600, Alex Williamson wrote:
> On Wed, 2 Nov 2022 06:54:28 -0400
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > On Mon, Oct 31, 2022 at 08:57:00PM +0800, Cindy Lu wrote:
> > > changes in V3
> > > 1. Move function vfio_get_xlat_addr to memory.c
> > > 2. Use the existing memory listener, while the MR is
> > > iommu MR then call the function iommu_region_add/
> > > iommu_region_del
> > > 
> > > changes in V4
> > > 1.make the comments in vfio_get_xlat_addr more general
> > > 
> > > changes in V5
> > > 1. Address the comments in the last version
> > > 2. Add a new arg in the function vfio_get_xlat_addr, which shows whether
> > > the memory is backed by a discard manager. So the device can have its
> > > own warning.
> > > 
> > > changes in V6
> > > move the error_report for the unpopulated discard back to
> > > memeory_get_xlat_addr
> > > 
> > > changes in V7
> > > organize the error massage to avoid the duplicate information
> > > 
> > > changes in V8
> > > Organize the code follow the comments in the last version
> > > 
> > > changes in V9
> > > Organize the code follow the comments
> > > 
> > > changes in V10
> > > Address the comments  
> > 
> > This missed this release unfortunately, as vfio changes didn't get
> > Alex's ack yet. Tagged but pls ping me after the freeze is lifted
> > to make sure I don't forget. Thanks!
> 
> I ack'd v9[1], which appears identical for the vfio related pieces.
> Thanks,
> 
> Alex
> 
> [1]https://lore.kernel.org/all/20221030212011.45c3d924.alex.williamson@redhat.com/


Oh sorry I was confused. It was actually me who had some comments.
And I'm not sure they have been addressed yet ;)
Will reply.