From: <zhang.songyi@zte.com.cn>
To: <avifishman70@gmail.com>
Cc: <tmaimon77@gmail.com>, <tali.perry1@gmail.com>,
<venture@google.com>, <yuenn@google.com>,
<benjaminfair@google.com>, <openbmc@lists.ozlabs.org>,
<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<zhang.songyi@zte.com.cn>
Subject: [PATCH linux-next] i2c: npcm7xx: remove redundant ret variable
Date: Thu, 3 Nov 2022 16:28:03 +0800 (CST) [thread overview]
Message-ID: <202211031628039654230@zte.com.cn> (raw)
From: zhang songyi <zhang.songyi@zte.com.cn>
Return value from npcm_i2c_get_slave_addr() directly instead of taking
this in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
---
drivers/i2c/busses/i2c-npcm7xx.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c
index bbc7359e67f7..772967862003 100644
--- a/drivers/i2c/busses/i2c-npcm7xx.c
+++ b/drivers/i2c/busses/i2c-npcm7xx.c
@@ -858,14 +858,10 @@ static void npcm_i2c_master_abort(struct npcm_i2c *bus)
#if IS_ENABLED(CONFIG_I2C_SLAVE)
static u8 npcm_i2c_get_slave_addr(struct npcm_i2c *bus, enum i2c_addr addr_type)
{
- u8 slave_add;
-
if (addr_type > I2C_SLAVE_ADDR2 && addr_type <= I2C_SLAVE_ADDR10)
dev_err(bus->dev, "get slave: try to use more than 2 SA not supported\n");
- slave_add = ioread8(bus->reg + npcm_i2caddr[(int)addr_type]);
-
- return slave_add;
+ return ioread8(bus->reg + npcm_i2caddr[(int)addr_type]);
}
static int npcm_i2c_remove_slave_addr(struct npcm_i2c *bus, u8 slave_add)
--
2.15.2
WARNING: multiple messages have this Message-ID (diff)
From: <zhang.songyi@zte.com.cn>
To: <avifishman70@gmail.com>
Cc: benjaminfair@google.com, venture@google.com,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
tali.perry1@gmail.com, linux-i2c@vger.kernel.org,
zhang.songyi@zte.com.cn, tmaimon77@gmail.com
Subject: [PATCH linux-next] i2c: npcm7xx: remove redundant ret variable
Date: Thu, 3 Nov 2022 16:28:03 +0800 (CST) [thread overview]
Message-ID: <202211031628039654230@zte.com.cn> (raw)
From: zhang songyi <zhang.songyi@zte.com.cn>
Return value from npcm_i2c_get_slave_addr() directly instead of taking
this in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
---
drivers/i2c/busses/i2c-npcm7xx.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c
index bbc7359e67f7..772967862003 100644
--- a/drivers/i2c/busses/i2c-npcm7xx.c
+++ b/drivers/i2c/busses/i2c-npcm7xx.c
@@ -858,14 +858,10 @@ static void npcm_i2c_master_abort(struct npcm_i2c *bus)
#if IS_ENABLED(CONFIG_I2C_SLAVE)
static u8 npcm_i2c_get_slave_addr(struct npcm_i2c *bus, enum i2c_addr addr_type)
{
- u8 slave_add;
-
if (addr_type > I2C_SLAVE_ADDR2 && addr_type <= I2C_SLAVE_ADDR10)
dev_err(bus->dev, "get slave: try to use more than 2 SA not supported\n");
- slave_add = ioread8(bus->reg + npcm_i2caddr[(int)addr_type]);
-
- return slave_add;
+ return ioread8(bus->reg + npcm_i2caddr[(int)addr_type]);
}
static int npcm_i2c_remove_slave_addr(struct npcm_i2c *bus, u8 slave_add)
--
2.15.2
next reply other threads:[~2022-11-03 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 8:28 zhang.songyi [this message]
2022-11-03 8:28 ` [PATCH linux-next] i2c: npcm7xx: remove redundant ret variable zhang.songyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202211031628039654230@zte.com.cn \
--to=zhang.songyi@zte.com.cn \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.