Re: [PATCH 1/2] mach-snapdragon/mach-ipq40xx: fix, merge and refactoring

[Andrey VOLKOV <andrey@volkov.fr>]

Hi Robert, Tom,

Updated patches are following, could you review/accept them?

Le 04/11/2022 à 12:05, Robert Marko a écrit :
> On Tue, Oct 25, 2022 at 3:31 AM Andrey Volkov<andrey@volkov.fr>  wrote:
>> SoC: qcom: Add missing Qualcomm's SOCs definitions to the arch KConfig
>>
>> From: Andrey VOLKOV<andrey@volkov.fr>
>>
>> Add APQ8016/APQ8096/QCS40X decls to the KConfig, convert SDM845 declaration to the hidden one (selected by target),
>> and update mach-snapdragon/Makefile accordingly.
>>
>> Also move 'CONFIG_ARM64' choice to the new declarations, since 'Snapdragon' contains Cortex A7A members too.
>>
>> Signed-off-by: Andrey VOLKOV<andrey@volkov.fr>
> I like this cleanup effort, however, can you rebase this to apply on the master?
> I would like to use this as a base of moving IPQ40xx to use Linux DTS
> and keep it in sync.

It's nice idea, except that full blown DTS is huge enough (+some KiB at least),
and i'm afraid it's an old, old story about failing to make it :(.
Probably will be better if we will have some option that allowed to import and
reuse DTS files directly from the kernel.
Something like CONFIG_DTS_FILE_PATH/CONFIG_DTS_INCLUDES/...

@Tom, any additional comments/objections?

Btw As far as I remember, this topic (reuse kernel's DTS) has been discussed
repeatedly since the mid-2000s, but I don't remember why it was not implemented yet.

>
> Regards,
> Robert

Regards
Andrey

---
Andrey VOLKOV (2):
  SoC: qcom: Add missing Qualcomm's SOCs definitions to the arch KConfig
  ipq40xx/snapdragon: Merge the two, more than 90% overlapping
    Qualcomm's Snapdrgon based arches, into one: "mach-snapdragon".

 arch/arm/Kconfig                              |  20 +--
 arch/arm/Makefile                             |   1 -
 arch/arm/mach-ipq40xx/Kconfig                 |  15 --
 arch/arm/mach-ipq40xx/Makefile                |   9 -
 arch/arm/mach-ipq40xx/include/mach/gpio.h     |  10 --
 arch/arm/mach-ipq40xx/pinctrl-snapdragon.c    | 166 ------------------
 arch/arm/mach-ipq40xx/pinctrl-snapdragon.h    |  30 ----
 arch/arm/mach-snapdragon/Kconfig              |  62 ++++++-
 arch/arm/mach-snapdragon/Makefile             |  34 ++--
 .../clock-ipq4019.c                           |   0
 .../pinctrl-ipq4019.c                         |   0
 arch/arm/mach-snapdragon/pinctrl-snapdragon.c |  48 +++--
 arch/arm/mach-snapdragon/pinctrl-snapdragon.h |   1 +
 drivers/phy/qcom/Kconfig                      |   2 +-
 drivers/reset/Kconfig                         |   2 +-
 drivers/reset/reset-qcom.c                    |   4 +-
 drivers/smem/Kconfig                          |   2 +-
 drivers/spi/Kconfig                           |   2 +-
 18 files changed, 123 insertions(+), 285 deletions(-)
 delete mode 100644 arch/arm/mach-ipq40xx/Kconfig
 delete mode 100644 arch/arm/mach-ipq40xx/Makefile
 delete mode 100644 arch/arm/mach-ipq40xx/include/mach/gpio.h
 delete mode 100644 arch/arm/mach-ipq40xx/pinctrl-snapdragon.c
 delete mode 100644 arch/arm/mach-ipq40xx/pinctrl-snapdragon.h
 rename arch/arm/{mach-ipq40xx => mach-snapdragon}/clock-ipq4019.c (100%)
 rename arch/arm/{mach-ipq40xx => mach-snapdragon}/pinctrl-ipq4019.c (100%)

-- 
2.34.1