From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: linux-i2c@vger.kernel.org
Cc: Wolfram Sang <wsa@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Michael Wu <michael.wu@vatics.com>,
Tian Ye <tianye@sugon.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: [PATCH v3 08/12] i2c: designware: Move debug print in i2c_dw_isr()
Date: Mon, 7 Nov 2022 15:42:44 +0200 [thread overview]
Message-ID: <20221107134248.864890-9-jarkko.nikula@linux.intel.com> (raw)
In-Reply-To: <20221107134248.864890-1-jarkko.nikula@linux.intel.com>
It is kind of needless to print interrupt status when code immediately
after that finds interrupt was not originating from this device.
Therefore move it after spurious interrupt detection.
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/i2c/busses/i2c-designware-master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
index d6fcf955dfc0..9c2c9d002dc3 100644
--- a/drivers/i2c/busses/i2c-designware-master.c
+++ b/drivers/i2c/busses/i2c-designware-master.c
@@ -775,11 +775,11 @@ static irqreturn_t i2c_dw_isr(int this_irq, void *dev_id)
regmap_read(dev->map, DW_IC_ENABLE, &enabled);
regmap_read(dev->map, DW_IC_RAW_INTR_STAT, &stat);
- dev_dbg(dev->dev, "enabled=%#x stat=%#x\n", enabled, stat);
if (!enabled || !(stat & ~DW_IC_INTR_ACTIVITY))
return IRQ_NONE;
if (pm_runtime_suspended(dev->dev) || stat == GENMASK(31, 0))
return IRQ_NONE;
+ dev_dbg(dev->dev, "enabled=%#x stat=%#x\n", enabled, stat);
i2c_dw_irq_handler_master(dev);
--
2.35.1
next prev parent reply other threads:[~2022-11-07 13:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 13:42 [PATCH v3 00/12] i2c: designware: Slave fixes and generic cleanups Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 01/12] i2c: designware: Fix slave state machine for sequential reads Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 02/12] i2c: designware: Empty receive FIFO in slave interrupt handler Jarkko Nikula
2022-11-12 6:57 ` Wolfram Sang
2022-11-14 9:53 ` Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 03/12] i2c: designware: Define software status flags with BIT() Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 04/12] i2c: designware: Remove needless initializations from i2c_dw_reg_slave() Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 05/12] i2c: designware: Remove unused completion code from i2c-designware-slave Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 06/12] i2c: designware: Simplify slave interrupt handler nesting Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 07/12] i2c: designware: Do not process interrupt when device is suspended Jarkko Nikula
2022-11-07 13:42 ` Jarkko Nikula [this message]
2022-11-07 13:42 ` [PATCH v3 09/12] i2c: designware: Simplify master interrupt handler nesting Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 10/12] i2c: designware: Remove common i2c_dw_disable_int() Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 11/12] i2c: designware: Align defines in i2c-designware-core.h Jarkko Nikula
2022-11-07 13:42 ` [PATCH v3 12/12] i2c: designware: Add comment to custom register value constants Jarkko Nikula
2022-11-12 6:57 ` [PATCH v3 00/12] i2c: designware: Slave fixes and generic cleanups Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107134248.864890-9-jarkko.nikula@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=michael.wu@vatics.com \
--cc=mika.westerberg@linux.intel.com \
--cc=tianye@sugon.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.