[PATCH v2 RESEND rebased] bus: mhi: host: pci_generic: Add HP variant of T99W175

[PATCH v2 RESEND rebased] bus: mhi: host: pci_generic: Add HP variant of T99W175

[Song Fuchang]

The Foxconn T99W175 modem has an HP variant, which has
the following output from lspci:

  01:00.0 Wireless controller [0d40]: Device 03f0:0a6c

It also has some HP-specific serial numbers on the
metal case. It works well with this driver, so add
support for this to the pci_generic driver.

Signed-off-by: Song Fuchang <song.fc@gmail.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
---


Changes in v2:
  - Add more detailed commit message and rebased on mhi-next.


 drivers/bus/mhi/host/pci_generic.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index fb3b050aed70..b58a30367896 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -598,6 +598,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
        /* MV32-WB (Cinterion) */
        { PCI_DEVICE(0x1269, 0x00bb),
                .driver_data = (kernel_ulong_t) &mhi_mv32_info },
+       /* T99W175 (sdx55), HP variant */
+       { PCI_DEVICE(0x03f0, 0x0a6c),
+               .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
        {  }
 };
 MODULE_DEVICE_TABLE(pci, mhi_pci_id_table);
-- 
2.37.3

Re: [PATCH v2 RESEND rebased] bus: mhi: host: pci_generic: Add HP variant of T99W175

[Manivannan Sadhasivam]

On Mon, Nov 07, 2022 at 09:10:47PM +0800, Song Fuchang wrote:
> The Foxconn T99W175 modem has an HP variant, which has
> the following output from lspci:
> 
>   01:00.0 Wireless controller [0d40]: Device 03f0:0a6c
> 
> It also has some HP-specific serial numbers on the
> metal case. It works well with this driver, so add
> support for this to the pci_generic driver.
> 
> Signed-off-by: Song Fuchang <song.fc@gmail.com>
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

Still it didn't apply using git am. So I went ahead and applied manually to
mhi-next.

Next time, please try applying the patches to mhi-next before sending to see if
everything is fine about the patch.

Thanks,
Mani

> ---
> 
> 
> Changes in v2:
>   - Add more detailed commit message and rebased on mhi-next.
> 
> 
>  drivers/bus/mhi/host/pci_generic.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index fb3b050aed70..b58a30367896 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -598,6 +598,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>         /* MV32-WB (Cinterion) */
>         { PCI_DEVICE(0x1269, 0x00bb),
>                 .driver_data = (kernel_ulong_t) &mhi_mv32_info },
> +       /* T99W175 (sdx55), HP variant */
> +       { PCI_DEVICE(0x03f0, 0x0a6c),
> +               .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
>         {  }
>  };
>  MODULE_DEVICE_TABLE(pci, mhi_pci_id_table);
> -- 
> 2.37.3
> 
> 
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH v2 RESEND rebased] bus: mhi: host: pci_generic: Add HP variant of T99W175

[Song Fuchang]

在 2022/11/7 21:52, Manivannan Sadhasivam 写道:
> On Mon, Nov 07, 2022 at 09:10:47PM +0800, Song Fuchang wrote:
>> The Foxconn T99W175 modem has an HP variant, which has
>> the following output from lspci:
>>
>>   01:00.0 Wireless controller [0d40]: Device 03f0:0a6c
>>
>> It also has some HP-specific serial numbers on the
>> metal case. It works well with this driver, so add
>> support for this to the pci_generic driver.
>>
>> Signed-off-by: Song Fuchang <song.fc@gmail.com>
>> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
> Still it didn't apply using git am. So I went ahead and applied manually to
> mhi-next.
This is strange. I have already rebased to the latest mhi-next tree, and this patch applied without error.
>
> Next time, please try applying the patches to mhi-next before sending to see if
> everything is fine about the patch.
I guess I should not use thunderbird to send this patch? I'll take care of it next time. Sorry for this mistake!
>
> Thanks,
> Mani
>
>> ---
>>
>>
>> Changes in v2:
>>   - Add more detailed commit message and rebased on mhi-next.
>>
>>
>>  drivers/bus/mhi/host/pci_generic.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
>> index fb3b050aed70..b58a30367896 100644
>> --- a/drivers/bus/mhi/host/pci_generic.c
>> +++ b/drivers/bus/mhi/host/pci_generic.c
>> @@ -598,6 +598,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>>         /* MV32-WB (Cinterion) */
>>         { PCI_DEVICE(0x1269, 0x00bb),
>>                 .driver_data = (kernel_ulong_t) &mhi_mv32_info },
>> +       /* T99W175 (sdx55), HP variant */
>> +       { PCI_DEVICE(0x03f0, 0x0a6c),
>> +               .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
>>         {  }
>>  };
>>  MODULE_DEVICE_TABLE(pci, mhi_pci_id_table);
>> -- 
>> 2.37.3
>>
>>
>>