All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Rafał Miłecki" <rafal@milecki.pl>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mtd: parsers: tplink_safeloader: fix uninitialized variable bug
Date: Mon, 7 Nov 2022 17:10:41 +0100	[thread overview]
Message-ID: <20221107171041.3eac0bbb@xps-13> (raw)
In-Reply-To: <4a9cbb40-e83f-b117-3ea4-38ff582e2db8@milecki.pl>


rafal@milecki.pl wrote on Mon, 7 Nov 2022 17:01:04 +0100:

> On 7.11.2022 16:52, Miquel Raynal wrote:
> > Hi Dan,
> > 
> > dan.carpenter@oracle.com wrote on Tue, 25 Oct 2022 18:34:24 +0300:
> >   
> >> On 64 bit systems, the highest 32 bits of the "offset" variable are
> >> not initialized.  Also the existing code is not endian safe (it will
> >> fail on big endian systems).  Change the type of "offset" to a u32.
> >>
> >> Fixes: aec4d5f5ffd0 ("mtd: parsers: add TP-Link SafeLoader partitions table parser")
> >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >> ---
> >>   drivers/mtd/parsers/tplink_safeloader.c | 6 +++---
> >>   1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/mtd/parsers/tplink_safeloader.c b/drivers/mtd/parsers/tplink_safeloader.c
> >> index 23584a477391..f601e7bd8627 100644
> >> --- a/drivers/mtd/parsers/tplink_safeloader.c
> >> +++ b/drivers/mtd/parsers/tplink_safeloader.c  
> > 
> > I am sorry but I don't have this file in my tree, what kernel are you
> > using?  
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/log/?h=mtd/next
> https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?h=mtd/next&id=aec4d5f5ffd0f0092bd9dc21ea90e0bc237d4b74
> 
> (committer Miquel Raynal ;) )

Ah, I knew I was missing something: the right branch. :-)

Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Rafał Miłecki" <rafal@milecki.pl>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mtd: parsers: tplink_safeloader: fix uninitialized variable bug
Date: Mon, 7 Nov 2022 17:10:41 +0100	[thread overview]
Message-ID: <20221107171041.3eac0bbb@xps-13> (raw)
In-Reply-To: <4a9cbb40-e83f-b117-3ea4-38ff582e2db8@milecki.pl>


rafal@milecki.pl wrote on Mon, 7 Nov 2022 17:01:04 +0100:

> On 7.11.2022 16:52, Miquel Raynal wrote:
> > Hi Dan,
> > 
> > dan.carpenter@oracle.com wrote on Tue, 25 Oct 2022 18:34:24 +0300:
> >   
> >> On 64 bit systems, the highest 32 bits of the "offset" variable are
> >> not initialized.  Also the existing code is not endian safe (it will
> >> fail on big endian systems).  Change the type of "offset" to a u32.
> >>
> >> Fixes: aec4d5f5ffd0 ("mtd: parsers: add TP-Link SafeLoader partitions table parser")
> >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >> ---
> >>   drivers/mtd/parsers/tplink_safeloader.c | 6 +++---
> >>   1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/mtd/parsers/tplink_safeloader.c b/drivers/mtd/parsers/tplink_safeloader.c
> >> index 23584a477391..f601e7bd8627 100644
> >> --- a/drivers/mtd/parsers/tplink_safeloader.c
> >> +++ b/drivers/mtd/parsers/tplink_safeloader.c  
> > 
> > I am sorry but I don't have this file in my tree, what kernel are you
> > using?  
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/log/?h=mtd/next
> https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?h=mtd/next&id=aec4d5f5ffd0f0092bd9dc21ea90e0bc237d4b74
> 
> (committer Miquel Raynal ;) )

Ah, I knew I was missing something: the right branch. :-)

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2022-11-07 16:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-25 15:34 [PATCH] mtd: parsers: tplink_safeloader: fix uninitialized variable bug Dan Carpenter
2022-10-25 15:34 ` Dan Carpenter
2022-10-25 16:51 ` Rafał Miłecki
2022-10-25 16:51   ` Rafał Miłecki
     [not found] ` <MN2PR17MB33758BC764511BB48B64192AB8319@MN2PR17MB3375.namprd17.prod.outlook.com>
2022-10-26  9:43   ` Dan Carpenter
2022-10-26  9:43     ` Dan Carpenter
2022-11-07 15:52 ` Miquel Raynal
2022-11-07 15:52   ` Miquel Raynal
2022-11-07 16:01   ` Rafał Miłecki
2022-11-07 16:01     ` Rafał Miłecki
2022-11-07 16:10     ` Miquel Raynal [this message]
2022-11-07 16:10       ` Miquel Raynal
2022-11-07 16:22 ` Miquel Raynal
2022-11-07 16:22   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221107171041.3eac0bbb@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=rafal@milecki.pl \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.