From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <kch@nvidia.com>,
Gerd Bayer <gbayer@linux.ibm.com>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 04/12] nvme-pci: put the admin queue in nvme_dev_remove_admin
Date: Wed, 9 Nov 2022 07:28:08 +0100 [thread overview]
Message-ID: <20221109062808.GE10528@lst.de> (raw)
In-Reply-To: <679cf80b-3e30-e393-d5c4-d3941e853bfb@grimberg.me>
On Wed, Nov 09, 2022 at 04:58:46AM +0200, Sagi Grimberg wrote:
>> @@ -2774,8 +2775,6 @@ static void nvme_pci_free_ctrl(struct nvme_ctrl *ctrl)
>> nvme_dbbuf_dma_free(dev);
>> nvme_free_tagset(dev);
>> - if (dev->ctrl.admin_q)
>> - blk_put_queue(dev->ctrl.admin_q);
>
> Is the check here valid? meaning can we get here with
> a NULL admin_q?
Yes, the admin queue is only set in the middle of nvme_reset_work,
and for errors before that we can get here.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <kch@nvidia.com>,
Gerd Bayer <gbayer@linux.ibm.com>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 04/12] nvme-pci: put the admin queue in nvme_dev_remove_admin
Date: Wed, 9 Nov 2022 07:28:08 +0100 [thread overview]
Message-ID: <20221109062808.GE10528@lst.de> (raw)
In-Reply-To: <679cf80b-3e30-e393-d5c4-d3941e853bfb@grimberg.me>
On Wed, Nov 09, 2022 at 04:58:46AM +0200, Sagi Grimberg wrote:
>> @@ -2774,8 +2775,6 @@ static void nvme_pci_free_ctrl(struct nvme_ctrl *ctrl)
>> nvme_dbbuf_dma_free(dev);
>> nvme_free_tagset(dev);
>> - if (dev->ctrl.admin_q)
>> - blk_put_queue(dev->ctrl.admin_q);
>
> Is the check here valid? meaning can we get here with
> a NULL admin_q?
Yes, the admin queue is only set in the middle of nvme_reset_work,
and for errors before that we can get here.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-09 6:28 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 15:02 RFC: nvme-pci: split the probe and reset handlers Christoph Hellwig
2022-11-08 15:02 ` Christoph Hellwig
2022-11-08 15:02 ` [PATCH 01/12] nvme-pci: don't call nvme_init_ctrl_finish from nvme_passthru_end Christoph Hellwig
2022-11-08 15:02 ` Christoph Hellwig
2022-11-09 2:55 ` Sagi Grimberg
2022-11-09 2:55 ` Sagi Grimberg
2022-11-09 6:26 ` Christoph Hellwig
2022-11-09 6:26 ` Christoph Hellwig
2022-11-08 15:02 ` [PATCH 02/12] nvme: move OPAL setup from PCIe to core Christoph Hellwig
2022-11-08 15:02 ` Christoph Hellwig
2022-11-09 2:55 ` Sagi Grimberg
2022-11-09 2:55 ` Sagi Grimberg
2022-11-09 20:44 ` Keith Busch
2022-11-09 20:44 ` Keith Busch
2022-11-09 23:22 ` Chaitanya Kulkarni
2022-11-09 23:22 ` Chaitanya Kulkarni
2022-11-13 16:15 ` Christoph Hellwig
2022-11-13 16:15 ` Christoph Hellwig
2022-11-08 15:02 ` [PATCH 03/12] nvme: simplify transport specific device attribute handling Christoph Hellwig
2022-11-08 15:02 ` Christoph Hellwig
2022-11-09 2:57 ` Sagi Grimberg
2022-11-09 2:57 ` Sagi Grimberg
2022-11-08 15:02 ` [PATCH 04/12] nvme-pci: put the admin queue in nvme_dev_remove_admin Christoph Hellwig
2022-11-08 15:02 ` Christoph Hellwig
2022-11-09 2:58 ` Sagi Grimberg
2022-11-09 2:58 ` Sagi Grimberg
2022-11-09 6:28 ` Christoph Hellwig [this message]
2022-11-09 6:28 ` Christoph Hellwig
2022-11-08 15:02 ` [PATCH 05/12] nvme-pci: move more teardown work to nvme_remove Christoph Hellwig
2022-11-08 15:02 ` Christoph Hellwig
2022-11-09 3:00 ` Sagi Grimberg
2022-11-09 3:00 ` Sagi Grimberg
2022-11-08 15:02 ` [PATCH 06/12] nvme-pci: factor the iod mempool creation into a helper Christoph Hellwig
2022-11-08 15:02 ` Christoph Hellwig
2022-11-09 3:00 ` Sagi Grimberg
2022-11-09 3:00 ` Sagi Grimberg
2022-11-08 15:02 ` [PATCH 07/12] nvme-pci: factor out a nvme_pci_alloc_ctrl helper Christoph Hellwig
2022-11-08 15:02 ` Christoph Hellwig
2022-11-09 3:03 ` Sagi Grimberg
2022-11-09 3:03 ` Sagi Grimberg
2022-11-09 6:28 ` Christoph Hellwig
2022-11-09 6:28 ` Christoph Hellwig
2022-11-08 15:02 ` [PATCH 08/12] nvme-pci: set constant paramters in nvme_pci_alloc_ctrl Christoph Hellwig
2022-11-08 15:02 ` Christoph Hellwig
2022-11-09 3:03 ` Sagi Grimberg
2022-11-09 3:03 ` Sagi Grimberg
2022-11-08 15:02 ` [PATCH 09/12] nvme-pci: call nvme_pci_configure_admin_queue from nvme_pci_enable Christoph Hellwig
2022-11-08 15:02 ` Christoph Hellwig
2022-11-09 3:04 ` Sagi Grimberg
2022-11-09 3:04 ` Sagi Grimberg
2022-11-08 15:02 ` [PATCH 10/12] nvme-pci: split nvme_dbbuf_dma_alloc Christoph Hellwig
2022-11-08 15:02 ` Christoph Hellwig
2022-11-09 3:05 ` Sagi Grimberg
2022-11-09 3:05 ` Sagi Grimberg
2022-11-08 15:02 ` [PATCH 11/12] nvme-pci: split the initial probe from the rest path Christoph Hellwig
2022-11-08 15:02 ` Christoph Hellwig
2022-11-09 3:14 ` Sagi Grimberg
2022-11-09 3:14 ` Sagi Grimberg
2022-11-09 6:31 ` Christoph Hellwig
2022-11-09 6:31 ` Christoph Hellwig
2022-11-09 17:00 ` Keith Busch
2022-11-09 17:00 ` Keith Busch
2022-11-09 15:18 ` Gerd Bayer
2022-11-09 15:18 ` Gerd Bayer
2022-11-09 15:51 ` Keith Busch
2022-11-09 15:51 ` Keith Busch
2022-11-09 15:56 ` Keith Busch
2022-11-09 15:56 ` Keith Busch
2022-11-10 3:17 ` Chao Leng
2022-11-10 3:17 ` Chao Leng
2022-11-13 16:19 ` Christoph Hellwig
2022-11-13 16:19 ` Christoph Hellwig
2022-11-08 15:02 ` [PATCH 12/12] nvme-pci: don't unbind the driver on reset failure Christoph Hellwig
2022-11-08 15:02 ` Christoph Hellwig
2022-11-09 3:15 ` Sagi Grimberg
2022-11-09 3:15 ` Sagi Grimberg
2022-11-09 17:10 ` Keith Busch
2022-11-09 17:10 ` Keith Busch
2022-11-09 17:12 ` RFC: nvme-pci: split the probe and reset handlers Keith Busch
2022-11-09 17:12 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109062808.GE10528@lst.de \
--to=hch@lst.de \
--cc=asahi@lists.linux.dev \
--cc=gbayer@linux.ibm.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.