Re: [Buildroot] [PATCH] package/udisks: add config option to support mounting in, /media

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Wolfgang,

On Tue, 8 Nov 2022 18:22:03 +0100
Wolfgang Grandegger <wg@grandegger.com> wrote:

> Support mounting in /media instead of /run/media for compatibility
> with the Filesystem Hierarchy Standard (FHS). This is also required
> for backward compatibility with udisks1.

Could you resend with your Signed-off-by: line? Also see below another
comment.

>   comment "udisks can't be built with Optimize for fast"
>   	depends on BR2_OPTIMIZE_FAST
> +
> +if BR2_PACKAGE_UDISKS
> +
> +config BR2_PACKAGE_UDISKS_FHS_MEDIA
> +	bool "Mount devices in /media instead of /run/media"
> +	help
> +	  Support mounting in /media for compatibility with the
> +	  Filesystem Hierarchy Standard (FHS)
> +
> +endif
> diff --git a/package/udisks/udisks.mk b/package/udisks/udisks.mk
> index 2bf519a2cc..91328effba 100644
> --- a/package/udisks/udisks.mk
> +++ b/package/udisks/udisks.mk
> @@ -39,4 +39,8 @@ UDISKS_CONF_OPTS = \
>   	--disable-vdo \
>   	--disable-zram
>   
> +ifeq ($(BR2_PACKAGE_UDISKS_FHS_MEDIA),y)
> +UDISKS_CONF_OPTS += --enable-fhs-media

Could you add:

else
UDISKS_CONF_OPTS += --disable-fhs-media

So that we are explicit about what happens when the option is disabled?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot