[Buildroot] [PATCH] package/udisks: add config option to support mounting in, /media

[Buildroot] [PATCH] package/udisks: add config option to support mounting in, /media

[Wolfgang Grandegger]

Support mounting in /media instead of /run/media for compatibility
with the Filesystem Hierarchy Standard (FHS). This is also required
for backward compatibility with udisks1.
---
  package/udisks/Config.in | 10 ++++++++++
  package/udisks/udisks.mk |  4 ++++
  2 files changed, 14 insertions(+)

diff --git a/package/udisks/Config.in b/package/udisks/Config.in
index 4804c0eba0..480d988857 100644
--- a/package/udisks/Config.in
+++ b/package/udisks/Config.in
@@ -49,3 +49,13 @@ comment "udisks needs a toolchain with dynamic library, locale, wchar, threads,
  
  comment "udisks can't be built with Optimize for fast"
  	depends on BR2_OPTIMIZE_FAST
+
+if BR2_PACKAGE_UDISKS
+
+config BR2_PACKAGE_UDISKS_FHS_MEDIA
+	bool "Mount devices in /media instead of /run/media"
+	help
+	  Support mounting in /media for compatibility with the
+	  Filesystem Hierarchy Standard (FHS)
+
+endif
diff --git a/package/udisks/udisks.mk b/package/udisks/udisks.mk
index 2bf519a2cc..91328effba 100644
--- a/package/udisks/udisks.mk
+++ b/package/udisks/udisks.mk
@@ -39,4 +39,8 @@ UDISKS_CONF_OPTS = \
  	--disable-vdo \
  	--disable-zram
  
+ifeq ($(BR2_PACKAGE_UDISKS_FHS_MEDIA),y)
+UDISKS_CONF_OPTS += --enable-fhs-media
+endif
+
  $(eval $(autotools-package))
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/udisks: add config option to support mounting in, /media

[Thomas Petazzoni via buildroot]

Hello Wolfgang,

On Tue, 8 Nov 2022 18:22:03 +0100
Wolfgang Grandegger <wg@grandegger.com> wrote:

> Support mounting in /media instead of /run/media for compatibility
> with the Filesystem Hierarchy Standard (FHS). This is also required
> for backward compatibility with udisks1.

Could you resend with your Signed-off-by: line? Also see below another
comment.

>   comment "udisks can't be built with Optimize for fast"
>   	depends on BR2_OPTIMIZE_FAST
> +
> +if BR2_PACKAGE_UDISKS
> +
> +config BR2_PACKAGE_UDISKS_FHS_MEDIA
> +	bool "Mount devices in /media instead of /run/media"
> +	help
> +	  Support mounting in /media for compatibility with the
> +	  Filesystem Hierarchy Standard (FHS)
> +
> +endif
> diff --git a/package/udisks/udisks.mk b/package/udisks/udisks.mk
> index 2bf519a2cc..91328effba 100644
> --- a/package/udisks/udisks.mk
> +++ b/package/udisks/udisks.mk
> @@ -39,4 +39,8 @@ UDISKS_CONF_OPTS = \
>   	--disable-vdo \
>   	--disable-zram
>   
> +ifeq ($(BR2_PACKAGE_UDISKS_FHS_MEDIA),y)
> +UDISKS_CONF_OPTS += --enable-fhs-media

Could you add:

else
UDISKS_CONF_OPTS += --disable-fhs-media

So that we are explicit about what happens when the option is disabled?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/udisks: add config option to support mounting in, /media

[Wolfgang Grandegger]

Hello Thomas,

I just sent v3  (v2 has a typo in the subject).
Hope it's OK now!

Thanks,

Wolfgang

On 09.11.22 23:10, Thomas Petazzoni via buildroot wrote:
> Hello Wolfgang,
> 
> On Tue, 8 Nov 2022 18:22:03 +0100
> Wolfgang Grandegger <wg@grandegger.com> wrote:
> 
>> Support mounting in /media instead of /run/media for compatibility
>> with the Filesystem Hierarchy Standard (FHS). This is also required
>> for backward compatibility with udisks1.
> 
> Could you resend with your Signed-off-by: line? Also see below another
> comment.
> 
>>    comment "udisks can't be built with Optimize for fast"
>>    	depends on BR2_OPTIMIZE_FAST
>> +
>> +if BR2_PACKAGE_UDISKS
>> +
>> +config BR2_PACKAGE_UDISKS_FHS_MEDIA
>> +	bool "Mount devices in /media instead of /run/media"
>> +	help
>> +	  Support mounting in /media for compatibility with the
>> +	  Filesystem Hierarchy Standard (FHS)
>> +
>> +endif
>> diff --git a/package/udisks/udisks.mk b/package/udisks/udisks.mk
>> index 2bf519a2cc..91328effba 100644
>> --- a/package/udisks/udisks.mk
>> +++ b/package/udisks/udisks.mk
>> @@ -39,4 +39,8 @@ UDISKS_CONF_OPTS = \
>>    	--disable-vdo \
>>    	--disable-zram
>>    
>> +ifeq ($(BR2_PACKAGE_UDISKS_FHS_MEDIA),y)
>> +UDISKS_CONF_OPTS += --enable-fhs-media
> 
> Could you add:
> 
> else
> UDISKS_CONF_OPTS += --disable-fhs-media
> 
> So that we are explicit about what happens when the option is disabled?
> 
> Thanks!
> 
> Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot