Re: [PATCHv2 1/1] dt-bindings: power: rockchip: Increase pm_qos number

[Rob Herring <robh@kernel.org>]

On Mon, Nov 07, 2022 at 07:02:31PM +0100, Sebastian Reichel wrote:
> On RK3588 some power domains require multiple qos blocks to be
> saved. The maximum required number for RK3588 is 8 (for VDPU).
> 
> Acked-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> Changes since PATCHv1:
>  * https://lore.kernel.org/all/20221021171405.86509-1-sebastian.reichel@collabora.com/
>  * add minItems: 1
>  * add Ack from Heiko
> ---
>  .../devicetree/bindings/power/rockchip,power-controller.yaml   | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> index 0d5e999a58f1..dc877416e1fd 100644
> --- a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> +++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> @@ -134,7 +134,8 @@ $defs:
>        pm_qos:
>          $ref: /schemas/types.yaml#/definitions/phandle-array

phandle-array is really a matrix of N entries of phandle+args. This 
should have worked as-is as N is not set here. Maybe somewhere else? Or 
could be a tooling bug. If you do want to define 1-8 entries of phandles 
with no args, that would be:

minItems: 1
maxItems: 8
items:
  maxItems: 1


>          items:
> -          maxItems: 1
> +          minItems: 1
> +          maxItems: 8
>          description: |
>            A number of phandles to qos blocks which need to be saved and restored
>            while power domain switches state.
> -- 
> 2.35.1
> 
> 

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip