From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 02/22] phy: qcom-qmp-combo: move device-id table
Date: Fri, 11 Nov 2022 09:56:23 +0100 [thread overview]
Message-ID: <20221111085643.9478-3-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221111085643.9478-1-johan+linaro@kernel.org>
Move the device-id table after probe() and next to the driver structure
to keep the driver callback functions grouped together.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 50 +++++++++++------------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
index d6a031bcfc30..e7c8c4417142 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
@@ -2646,31 +2646,6 @@ static int qmp_combo_create(struct device *dev, struct device_node *np, int id,
return 0;
}
-static const struct of_device_id qmp_combo_of_match_table[] = {
- {
- .compatible = "qcom,sc7180-qmp-usb3-dp-phy",
- .data = &sc7180_usb3dpphy_cfg,
- },
- {
- .compatible = "qcom,sc8180x-qmp-usb3-dp-phy",
- .data = &sc8180x_usb3dpphy_cfg,
- },
- {
- .compatible = "qcom,sc8280xp-qmp-usb43dp-phy",
- .data = &sc8280xp_usb43dpphy_combo_cfg,
- },
- {
- .compatible = "qcom,sdm845-qmp-usb3-dp-phy",
- .data = &sdm845_usb3dpphy_cfg,
- },
- {
- .compatible = "qcom,sm8250-qmp-usb3-dp-phy",
- .data = &sm8250_usb3dpphy_cfg,
- },
- { }
-};
-MODULE_DEVICE_TABLE(of, qmp_combo_of_match_table);
-
static const struct dev_pm_ops qmp_combo_pm_ops = {
SET_RUNTIME_PM_OPS(qmp_combo_runtime_suspend,
qmp_combo_runtime_resume, NULL)
@@ -2815,6 +2790,31 @@ static int qmp_combo_probe(struct platform_device *pdev)
return ret;
}
+static const struct of_device_id qmp_combo_of_match_table[] = {
+ {
+ .compatible = "qcom,sc7180-qmp-usb3-dp-phy",
+ .data = &sc7180_usb3dpphy_cfg,
+ },
+ {
+ .compatible = "qcom,sc8180x-qmp-usb3-dp-phy",
+ .data = &sc8180x_usb3dpphy_cfg,
+ },
+ {
+ .compatible = "qcom,sc8280xp-qmp-usb43dp-phy",
+ .data = &sc8280xp_usb43dpphy_combo_cfg,
+ },
+ {
+ .compatible = "qcom,sdm845-qmp-usb3-dp-phy",
+ .data = &sdm845_usb3dpphy_cfg,
+ },
+ {
+ .compatible = "qcom,sm8250-qmp-usb3-dp-phy",
+ .data = &sm8250_usb3dpphy_cfg,
+ },
+ { }
+};
+MODULE_DEVICE_TABLE(of, qmp_combo_of_match_table);
+
static struct platform_driver qmp_combo_driver = {
.probe = qmp_combo_probe,
.driver = {
--
2.37.4
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 02/22] phy: qcom-qmp-combo: move device-id table
Date: Fri, 11 Nov 2022 09:56:23 +0100 [thread overview]
Message-ID: <20221111085643.9478-3-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221111085643.9478-1-johan+linaro@kernel.org>
Move the device-id table after probe() and next to the driver structure
to keep the driver callback functions grouped together.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 50 +++++++++++------------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
index d6a031bcfc30..e7c8c4417142 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
@@ -2646,31 +2646,6 @@ static int qmp_combo_create(struct device *dev, struct device_node *np, int id,
return 0;
}
-static const struct of_device_id qmp_combo_of_match_table[] = {
- {
- .compatible = "qcom,sc7180-qmp-usb3-dp-phy",
- .data = &sc7180_usb3dpphy_cfg,
- },
- {
- .compatible = "qcom,sc8180x-qmp-usb3-dp-phy",
- .data = &sc8180x_usb3dpphy_cfg,
- },
- {
- .compatible = "qcom,sc8280xp-qmp-usb43dp-phy",
- .data = &sc8280xp_usb43dpphy_combo_cfg,
- },
- {
- .compatible = "qcom,sdm845-qmp-usb3-dp-phy",
- .data = &sdm845_usb3dpphy_cfg,
- },
- {
- .compatible = "qcom,sm8250-qmp-usb3-dp-phy",
- .data = &sm8250_usb3dpphy_cfg,
- },
- { }
-};
-MODULE_DEVICE_TABLE(of, qmp_combo_of_match_table);
-
static const struct dev_pm_ops qmp_combo_pm_ops = {
SET_RUNTIME_PM_OPS(qmp_combo_runtime_suspend,
qmp_combo_runtime_resume, NULL)
@@ -2815,6 +2790,31 @@ static int qmp_combo_probe(struct platform_device *pdev)
return ret;
}
+static const struct of_device_id qmp_combo_of_match_table[] = {
+ {
+ .compatible = "qcom,sc7180-qmp-usb3-dp-phy",
+ .data = &sc7180_usb3dpphy_cfg,
+ },
+ {
+ .compatible = "qcom,sc8180x-qmp-usb3-dp-phy",
+ .data = &sc8180x_usb3dpphy_cfg,
+ },
+ {
+ .compatible = "qcom,sc8280xp-qmp-usb43dp-phy",
+ .data = &sc8280xp_usb43dpphy_combo_cfg,
+ },
+ {
+ .compatible = "qcom,sdm845-qmp-usb3-dp-phy",
+ .data = &sdm845_usb3dpphy_cfg,
+ },
+ {
+ .compatible = "qcom,sm8250-qmp-usb3-dp-phy",
+ .data = &sm8250_usb3dpphy_cfg,
+ },
+ { }
+};
+MODULE_DEVICE_TABLE(of, qmp_combo_of_match_table);
+
static struct platform_driver qmp_combo_driver = {
.probe = qmp_combo_probe,
.driver = {
--
2.37.4
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-11-11 8:57 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 8:56 [PATCH 00/22] phy: qcom-qmp-combo: preparatory cleanups (set 2/3) Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-11 8:56 ` [PATCH 01/22] phy: qcom-qmp-combo: sort device-id table Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 6:18 ` Dmitry Baryshkov
2022-11-12 6:18 ` Dmitry Baryshkov
2022-11-11 8:56 ` Johan Hovold [this message]
2022-11-11 8:56 ` [PATCH 02/22] phy: qcom-qmp-combo: move " Johan Hovold
2022-11-12 6:18 ` Dmitry Baryshkov
2022-11-12 6:18 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 03/22] phy: qcom-qmp-combo: move pm ops Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 6:19 ` Dmitry Baryshkov
2022-11-12 6:19 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 04/22] phy: qcom-qmp-combo: rename PHY ops structures Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 6:19 ` Dmitry Baryshkov
2022-11-12 6:19 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 05/22] phy: qcom-qmp-combo: drop unused DP PHY mode op Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 6:19 ` Dmitry Baryshkov
2022-11-12 6:19 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 06/22] phy: qcom-qmp-combo: rename USB PHY ops Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 6:20 ` Dmitry Baryshkov
2022-11-12 6:20 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 07/22] phy: qcom-qmp-combo: drop unnecessary debug message Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 6:20 ` Dmitry Baryshkov
2022-11-12 6:20 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 08/22] phy: qcom-qmp-combo: separate USB and DP init ops Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 6:21 ` Dmitry Baryshkov
2022-11-12 6:21 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 09/22] phy: qcom-qmp-combo: rename DP PHY ops Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 6:21 ` Dmitry Baryshkov
2022-11-12 6:21 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 10/22] phy: qcom-qmp-combo: separate USB and DP power-on ops Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 7:32 ` Dmitry Baryshkov
2022-11-12 7:32 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 11/22] phy: qcom-qmp-combo: clean up serdes initialisation Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 7:33 ` Dmitry Baryshkov
2022-11-12 7:33 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 12/22] phy: qcom-qmp-combo: separate USB and DP devicetree parsing Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 7:50 ` Dmitry Baryshkov
2022-11-12 7:50 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 13/22] phy: qcom-qmp-combo: add dedicated DP iomem pointers Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 7:36 ` Dmitry Baryshkov
2022-11-12 7:36 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 14/22] phy: qcom-qmp-combo: clean up DP configurations Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 7:32 ` Dmitry Baryshkov
2022-11-12 7:32 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 15/22] phy: qcom-qmp-combo: rename sc8280xp config Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 7:33 ` Dmitry Baryshkov
2022-11-12 7:33 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 16/22] phy: qcom-qmp-combo: add DP configuration tables Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 7:39 ` Dmitry Baryshkov
2022-11-12 7:39 ` Dmitry Baryshkov
2022-11-14 8:38 ` Johan Hovold
2022-11-14 8:38 ` Johan Hovold
2022-11-14 9:49 ` Dmitry Baryshkov
2022-11-14 9:49 ` Dmitry Baryshkov
2022-11-14 9:50 ` Dmitry Baryshkov
2022-11-14 9:50 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 17/22] phy: qcom-qmp-combo: merge USB and DP configurations Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 7:43 ` Dmitry Baryshkov
2022-11-12 7:43 ` Dmitry Baryshkov
2022-11-14 8:54 ` Johan Hovold
2022-11-14 8:54 ` Johan Hovold
2022-11-14 10:10 ` Dmitry Baryshkov
2022-11-14 10:10 ` Dmitry Baryshkov
2022-11-14 10:57 ` Johan Hovold
2022-11-14 10:57 ` Johan Hovold
2022-11-14 10:11 ` Dmitry Baryshkov
2022-11-14 10:11 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 18/22] phy: qcom-qmp-combo: merge driver data Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 7:46 ` Dmitry Baryshkov
2022-11-12 7:46 ` Dmitry Baryshkov
2022-11-14 9:01 ` Johan Hovold
2022-11-14 9:01 ` Johan Hovold
2022-11-14 9:22 ` Dmitry Baryshkov
2022-11-14 9:22 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 19/22] phy: qcom-qmp-combo: clean up device-tree parsing Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 7:48 ` Dmitry Baryshkov
2022-11-12 7:48 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 20/22] phy: qcom-qmp-combo: clean up probe initialisation Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 7:48 ` Dmitry Baryshkov
2022-11-12 7:48 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 21/22] phy: qcom-qmp-combo: clean up PHY init Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 7:49 ` Dmitry Baryshkov
2022-11-12 7:49 ` Dmitry Baryshkov
2022-11-11 8:56 ` [PATCH 22/22] phy: qcom-qmp-combo: clean up DP callback names Johan Hovold
2022-11-11 8:56 ` Johan Hovold
2022-11-12 7:49 ` Dmitry Baryshkov
2022-11-12 7:49 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111085643.9478-3-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.