From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 11/14] phy: qcom-qmp-combo: clean up DP clock callbacks
Date: Fri, 11 Nov 2022 10:24:54 +0100 [thread overview]
Message-ID: <20221111092457.10546-12-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221111092457.10546-1-johan+linaro@kernel.org>
Clean up the DP clock callbacks somewhat by dropping the redundant
"qcom" prefix and removing line breaks after type specifiers.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 33 ++++++++++-------------
1 file changed, 14 insertions(+), 19 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
index f3d3229d3aa2..5068f8674faf 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
@@ -2316,8 +2316,7 @@ static int phy_pipe_clk_register(struct qmp_combo *qmp, struct device_node *np)
* for DP pixel clock
*
*/
-static int qcom_qmp_dp_pixel_clk_determine_rate(struct clk_hw *hw,
- struct clk_rate_request *req)
+static int qmp_dp_pixel_clk_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
{
switch (req->rate) {
case 1620000000UL / 2:
@@ -2329,8 +2328,7 @@ static int qcom_qmp_dp_pixel_clk_determine_rate(struct clk_hw *hw,
}
}
-static unsigned long
-qcom_qmp_dp_pixel_clk_recalc_rate(struct clk_hw *hw, unsigned long parent_rate)
+static unsigned long qmp_dp_pixel_clk_recalc_rate(struct clk_hw *hw, unsigned long parent_rate)
{
const struct qmp_combo *qmp;
const struct phy_configure_opts_dp *dp_opts;
@@ -2352,13 +2350,12 @@ qcom_qmp_dp_pixel_clk_recalc_rate(struct clk_hw *hw, unsigned long parent_rate)
}
}
-static const struct clk_ops qcom_qmp_dp_pixel_clk_ops = {
- .determine_rate = qcom_qmp_dp_pixel_clk_determine_rate,
- .recalc_rate = qcom_qmp_dp_pixel_clk_recalc_rate,
+static const struct clk_ops qmp_dp_pixel_clk_ops = {
+ .determine_rate = qmp_dp_pixel_clk_determine_rate,
+ .recalc_rate = qmp_dp_pixel_clk_recalc_rate,
};
-static int qcom_qmp_dp_link_clk_determine_rate(struct clk_hw *hw,
- struct clk_rate_request *req)
+static int qmp_dp_link_clk_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
{
switch (req->rate) {
case 162000000:
@@ -2371,8 +2368,7 @@ static int qcom_qmp_dp_link_clk_determine_rate(struct clk_hw *hw,
}
}
-static unsigned long
-qcom_qmp_dp_link_clk_recalc_rate(struct clk_hw *hw, unsigned long parent_rate)
+static unsigned long qmp_dp_link_clk_recalc_rate(struct clk_hw *hw, unsigned long parent_rate)
{
const struct qmp_combo *qmp;
const struct phy_configure_opts_dp *dp_opts;
@@ -2391,13 +2387,12 @@ qcom_qmp_dp_link_clk_recalc_rate(struct clk_hw *hw, unsigned long parent_rate)
}
}
-static const struct clk_ops qcom_qmp_dp_link_clk_ops = {
- .determine_rate = qcom_qmp_dp_link_clk_determine_rate,
- .recalc_rate = qcom_qmp_dp_link_clk_recalc_rate,
+static const struct clk_ops qmp_dp_link_clk_ops = {
+ .determine_rate = qmp_dp_link_clk_determine_rate,
+ .recalc_rate = qmp_dp_link_clk_recalc_rate,
};
-static struct clk_hw *
-qcom_qmp_dp_clks_hw_get(struct of_phandle_args *clkspec, void *data)
+static struct clk_hw *qmp_dp_clks_hw_get(struct of_phandle_args *clkspec, void *data)
{
struct qmp_combo *qmp = data;
unsigned int idx = clkspec->args[0];
@@ -2420,7 +2415,7 @@ static int phy_dp_clks_register(struct qmp_combo *qmp, struct device_node *np)
int ret;
snprintf(name, sizeof(name), "%s::link_clk", dev_name(qmp->dev));
- init.ops = &qcom_qmp_dp_link_clk_ops;
+ init.ops = &qmp_dp_link_clk_ops;
init.name = name;
qmp->dp_link_hw.init = &init;
ret = devm_clk_hw_register(qmp->dev, &qmp->dp_link_hw);
@@ -2428,7 +2423,7 @@ static int phy_dp_clks_register(struct qmp_combo *qmp, struct device_node *np)
return ret;
snprintf(name, sizeof(name), "%s::vco_div_clk", dev_name(qmp->dev));
- init.ops = &qcom_qmp_dp_pixel_clk_ops;
+ init.ops = &qmp_dp_pixel_clk_ops;
init.name = name;
qmp->dp_pixel_hw.init = &init;
ret = devm_clk_hw_register(qmp->dev, &qmp->dp_pixel_hw);
@@ -2464,7 +2459,7 @@ static int qmp_combo_register_clocks(struct qmp_combo *qmp, struct device_node *
if (ret)
return ret;
- ret = of_clk_add_hw_provider(dp_np, qcom_qmp_dp_clks_hw_get, qmp);
+ ret = of_clk_add_hw_provider(dp_np, qmp_dp_clks_hw_get, qmp);
if (ret)
return ret;
--
2.37.4
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 11/14] phy: qcom-qmp-combo: clean up DP clock callbacks
Date: Fri, 11 Nov 2022 10:24:54 +0100 [thread overview]
Message-ID: <20221111092457.10546-12-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221111092457.10546-1-johan+linaro@kernel.org>
Clean up the DP clock callbacks somewhat by dropping the redundant
"qcom" prefix and removing line breaks after type specifiers.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 33 ++++++++++-------------
1 file changed, 14 insertions(+), 19 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
index f3d3229d3aa2..5068f8674faf 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
@@ -2316,8 +2316,7 @@ static int phy_pipe_clk_register(struct qmp_combo *qmp, struct device_node *np)
* for DP pixel clock
*
*/
-static int qcom_qmp_dp_pixel_clk_determine_rate(struct clk_hw *hw,
- struct clk_rate_request *req)
+static int qmp_dp_pixel_clk_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
{
switch (req->rate) {
case 1620000000UL / 2:
@@ -2329,8 +2328,7 @@ static int qcom_qmp_dp_pixel_clk_determine_rate(struct clk_hw *hw,
}
}
-static unsigned long
-qcom_qmp_dp_pixel_clk_recalc_rate(struct clk_hw *hw, unsigned long parent_rate)
+static unsigned long qmp_dp_pixel_clk_recalc_rate(struct clk_hw *hw, unsigned long parent_rate)
{
const struct qmp_combo *qmp;
const struct phy_configure_opts_dp *dp_opts;
@@ -2352,13 +2350,12 @@ qcom_qmp_dp_pixel_clk_recalc_rate(struct clk_hw *hw, unsigned long parent_rate)
}
}
-static const struct clk_ops qcom_qmp_dp_pixel_clk_ops = {
- .determine_rate = qcom_qmp_dp_pixel_clk_determine_rate,
- .recalc_rate = qcom_qmp_dp_pixel_clk_recalc_rate,
+static const struct clk_ops qmp_dp_pixel_clk_ops = {
+ .determine_rate = qmp_dp_pixel_clk_determine_rate,
+ .recalc_rate = qmp_dp_pixel_clk_recalc_rate,
};
-static int qcom_qmp_dp_link_clk_determine_rate(struct clk_hw *hw,
- struct clk_rate_request *req)
+static int qmp_dp_link_clk_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
{
switch (req->rate) {
case 162000000:
@@ -2371,8 +2368,7 @@ static int qcom_qmp_dp_link_clk_determine_rate(struct clk_hw *hw,
}
}
-static unsigned long
-qcom_qmp_dp_link_clk_recalc_rate(struct clk_hw *hw, unsigned long parent_rate)
+static unsigned long qmp_dp_link_clk_recalc_rate(struct clk_hw *hw, unsigned long parent_rate)
{
const struct qmp_combo *qmp;
const struct phy_configure_opts_dp *dp_opts;
@@ -2391,13 +2387,12 @@ qcom_qmp_dp_link_clk_recalc_rate(struct clk_hw *hw, unsigned long parent_rate)
}
}
-static const struct clk_ops qcom_qmp_dp_link_clk_ops = {
- .determine_rate = qcom_qmp_dp_link_clk_determine_rate,
- .recalc_rate = qcom_qmp_dp_link_clk_recalc_rate,
+static const struct clk_ops qmp_dp_link_clk_ops = {
+ .determine_rate = qmp_dp_link_clk_determine_rate,
+ .recalc_rate = qmp_dp_link_clk_recalc_rate,
};
-static struct clk_hw *
-qcom_qmp_dp_clks_hw_get(struct of_phandle_args *clkspec, void *data)
+static struct clk_hw *qmp_dp_clks_hw_get(struct of_phandle_args *clkspec, void *data)
{
struct qmp_combo *qmp = data;
unsigned int idx = clkspec->args[0];
@@ -2420,7 +2415,7 @@ static int phy_dp_clks_register(struct qmp_combo *qmp, struct device_node *np)
int ret;
snprintf(name, sizeof(name), "%s::link_clk", dev_name(qmp->dev));
- init.ops = &qcom_qmp_dp_link_clk_ops;
+ init.ops = &qmp_dp_link_clk_ops;
init.name = name;
qmp->dp_link_hw.init = &init;
ret = devm_clk_hw_register(qmp->dev, &qmp->dp_link_hw);
@@ -2428,7 +2423,7 @@ static int phy_dp_clks_register(struct qmp_combo *qmp, struct device_node *np)
return ret;
snprintf(name, sizeof(name), "%s::vco_div_clk", dev_name(qmp->dev));
- init.ops = &qcom_qmp_dp_pixel_clk_ops;
+ init.ops = &qmp_dp_pixel_clk_ops;
init.name = name;
qmp->dp_pixel_hw.init = &init;
ret = devm_clk_hw_register(qmp->dev, &qmp->dp_pixel_hw);
@@ -2464,7 +2459,7 @@ static int qmp_combo_register_clocks(struct qmp_combo *qmp, struct device_node *
if (ret)
return ret;
- ret = of_clk_add_hw_provider(dp_np, qcom_qmp_dp_clks_hw_get, qmp);
+ ret = of_clk_add_hw_provider(dp_np, qmp_dp_clks_hw_get, qmp);
if (ret)
return ret;
--
2.37.4
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-11-11 9:26 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 9:24 [PATCH 00/14] phy: qcom-qmp-combo: fix sc8280xp binding (set 3/3) Johan Hovold
2022-11-11 9:24 ` Johan Hovold
2022-11-11 9:24 ` [PATCH 01/14] dt-bindings: phy: qcom,qmp-usb3-dp: rename current bindings Johan Hovold
2022-11-11 9:24 ` Johan Hovold
2022-11-11 15:15 ` Krzysztof Kozlowski
2022-11-11 15:15 ` Krzysztof Kozlowski
2022-11-11 9:24 ` [PATCH 02/14] dt-bindings: phy: qcom,qmp-usb3-dp: fix sc8280xp bindings Johan Hovold
2022-11-11 9:24 ` Johan Hovold
2022-11-11 13:24 ` Johan Hovold
2022-11-11 13:24 ` Johan Hovold
2022-11-11 13:30 ` Rob Herring
2022-11-11 13:30 ` Rob Herring
2022-11-11 15:17 ` Krzysztof Kozlowski
2022-11-11 15:17 ` Krzysztof Kozlowski
2022-11-14 13:27 ` Johan Hovold
2022-11-14 13:27 ` Johan Hovold
2022-11-14 14:07 ` Krzysztof Kozlowski
2022-11-14 14:07 ` Krzysztof Kozlowski
2022-11-14 14:18 ` Johan Hovold
2022-11-14 14:18 ` Johan Hovold
2022-11-14 15:19 ` Dmitry Baryshkov
2022-11-14 15:19 ` Dmitry Baryshkov
2022-11-14 15:38 ` Johan Hovold
2022-11-14 15:38 ` Johan Hovold
2022-11-14 16:14 ` Dmitry Baryshkov
2022-11-14 16:14 ` Dmitry Baryshkov
2022-11-14 16:42 ` Johan Hovold
2022-11-14 16:42 ` Johan Hovold
2022-11-14 16:51 ` Dmitry Baryshkov
2022-11-14 16:51 ` Dmitry Baryshkov
2022-11-14 16:53 ` Johan Hovold
2022-11-14 16:53 ` Johan Hovold
2022-11-14 15:49 ` Krzysztof Kozlowski
2022-11-14 15:49 ` Krzysztof Kozlowski
2022-11-14 16:32 ` Johan Hovold
2022-11-14 16:32 ` Johan Hovold
2022-11-14 16:39 ` Krzysztof Kozlowski
2022-11-14 16:39 ` Krzysztof Kozlowski
2022-11-14 16:48 ` Johan Hovold
2022-11-14 16:48 ` Johan Hovold
2022-11-14 16:56 ` Krzysztof Kozlowski
2022-11-14 16:56 ` Krzysztof Kozlowski
2022-11-14 17:08 ` Johan Hovold
2022-11-14 17:08 ` Johan Hovold
2022-11-15 8:12 ` Krzysztof Kozlowski
2022-11-15 8:12 ` Krzysztof Kozlowski
2022-11-15 14:22 ` Johan Hovold
2022-11-15 14:22 ` Johan Hovold
2022-11-15 14:56 ` Krzysztof Kozlowski
2022-11-15 14:56 ` Krzysztof Kozlowski
2022-11-12 11:43 ` Dmitry Baryshkov
2022-11-12 11:43 ` Dmitry Baryshkov
2022-11-14 13:37 ` Johan Hovold
2022-11-14 13:37 ` Johan Hovold
2022-11-14 15:31 ` Dmitry Baryshkov
2022-11-14 15:31 ` Dmitry Baryshkov
2022-11-14 16:21 ` Johan Hovold
2022-11-14 16:21 ` Johan Hovold
2022-11-11 9:24 ` [PATCH 03/14] phy: qcom-qmp-combo: drop v4 reference-clock source Johan Hovold
2022-11-11 9:24 ` Johan Hovold
2022-11-12 11:43 ` Dmitry Baryshkov
2022-11-12 11:43 ` Dmitry Baryshkov
2022-11-14 13:03 ` Johan Hovold
2022-11-14 13:03 ` Johan Hovold
2022-11-11 9:24 ` [PATCH 04/14] phy: qcom-qmp-combo: restructure PHY creation Johan Hovold
2022-11-11 9:24 ` Johan Hovold
2022-11-11 9:28 ` Johan Hovold
2022-11-11 9:28 ` Johan Hovold
2022-11-11 15:18 ` Krzysztof Kozlowski
2022-11-11 15:18 ` Krzysztof Kozlowski
2022-11-11 15:19 ` Krzysztof Kozlowski
2022-11-11 15:19 ` Krzysztof Kozlowski
2022-11-11 9:24 ` [PATCH 05/14] phy: qcom-qmp-combo: register clocks sooner Johan Hovold
2022-11-11 9:24 ` Johan Hovold
2022-11-12 11:15 ` Dmitry Baryshkov
2022-11-12 11:15 ` Dmitry Baryshkov
2022-11-14 13:42 ` Johan Hovold
2022-11-14 13:42 ` Johan Hovold
2022-11-11 9:24 ` [PATCH 06/14] phy: qcom-qmp-combo: generate pipe clock name Johan Hovold
2022-11-11 9:24 ` Johan Hovold
2022-11-12 11:15 ` Dmitry Baryshkov
2022-11-12 11:15 ` Dmitry Baryshkov
2022-11-11 9:24 ` [PATCH 07/14] phy: qcom-qmp-combo: drop redundant clock structure Johan Hovold
2022-11-11 9:24 ` Johan Hovold
2022-11-12 11:16 ` Dmitry Baryshkov
2022-11-12 11:16 ` Dmitry Baryshkov
2022-11-11 9:24 ` [PATCH 08/14] phy: qcom-qmp-combo: drop redundant clock allocation Johan Hovold
2022-11-11 9:24 ` Johan Hovold
2022-11-12 11:17 ` Dmitry Baryshkov
2022-11-12 11:17 ` Dmitry Baryshkov
2022-11-14 12:42 ` Johan Hovold
2022-11-14 12:42 ` Johan Hovold
2022-11-14 15:31 ` Dmitry Baryshkov
2022-11-14 15:31 ` Dmitry Baryshkov
2022-11-11 9:24 ` [PATCH 09/14] phy: qcom-qmp-combo: add clock registration helper Johan Hovold
2022-11-11 9:24 ` Johan Hovold
2022-11-14 10:12 ` Dmitry Baryshkov
2022-11-14 10:12 ` Dmitry Baryshkov
2022-11-11 9:24 ` [PATCH 10/14] phy: qcom-qmp-combo: separate clock and provider registration Johan Hovold
2022-11-11 9:24 ` Johan Hovold
2022-11-14 10:13 ` Dmitry Baryshkov
2022-11-14 10:13 ` Dmitry Baryshkov
2022-11-11 9:24 ` Johan Hovold [this message]
2022-11-11 9:24 ` [PATCH 11/14] phy: qcom-qmp-combo: clean up DP clock callbacks Johan Hovold
2022-11-12 11:20 ` Dmitry Baryshkov
2022-11-12 11:20 ` Dmitry Baryshkov
2022-11-11 9:24 ` [PATCH 12/14] phy: qcom-qmp-combo: rename common-register pointers Johan Hovold
2022-11-11 9:24 ` Johan Hovold
2022-11-12 11:31 ` Dmitry Baryshkov
2022-11-12 11:31 ` Dmitry Baryshkov
2022-11-14 12:54 ` Johan Hovold
2022-11-14 12:54 ` Johan Hovold
2022-11-14 15:38 ` Dmitry Baryshkov
2022-11-14 15:38 ` Dmitry Baryshkov
2022-11-14 15:51 ` Johan Hovold
2022-11-14 15:51 ` Johan Hovold
2022-11-11 9:24 ` [PATCH 13/14] phy: qcom-qmp-combo: rename DP_PHY register pointer Johan Hovold
2022-11-11 9:24 ` Johan Hovold
2022-11-12 11:31 ` Dmitry Baryshkov
2022-11-12 11:31 ` Dmitry Baryshkov
2022-11-11 9:24 ` [PATCH 14/14] phy: qcom-qmp-combo: add support for updated sc8280xp binding Johan Hovold
2022-11-11 9:24 ` Johan Hovold
2022-11-12 11:36 ` Dmitry Baryshkov
2022-11-12 11:36 ` Dmitry Baryshkov
2022-11-14 12:58 ` Johan Hovold
2022-11-14 12:58 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111092457.10546-12-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.